search

Perl-Toolchain-Gang / ExtUtils-Manifest

Utilities to write and check a MANIFEST file
https://metacpan.org/release/ExtUtils-Manifest/
Other
4 stars 7 forks source link

cope with recursive symlinks #16

Open karenetheridge opened 9 years ago

karenetheridge commented 9 years ago

re https://github.com/andk/pause/pull/172

manifind runs File::Find, which might die on recursive symlinks; we should not die.

shadowcat-mst commented 8 years ago

I just hit this - the fix is to add follow_skip => 2 to line 202 -

find({wanted => $wanted, follow_fast => 1, follow_skip => 2},

and then it'll just skip the second copy it finds; this wouldn't be nearly so much of a pain except that it applies the .SKIP patterns after this find() has completed, thereby meaning that SKIPping the symlinks doesn't save us.

eserte commented 2 years ago

Probably same issue as https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/5 and https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/6. The proposed solution with follow_skip=>2 looks good to me, is there any known or unknown problem with this solution?