search

Perl-Toolchain-Gang / Module-Metadata

Gather package and POD information from perl module files
http://metacpan.org/release/Module-Metadata/
Other
8 stars 16 forks source link

extract-version.t passing todo tests in perl-5.29.7 onwards #31

Open iabyn opened 5 years ago

iabyn commented 5 years ago

In perl 5.29.7 onwards the version 1.000033 in blead produces the following output: ../cpan/Module-Metadata/t/extract-version.t (Wstat: 0 Tests: 224 Failed: 0)

  TODO passed:   7, 11, 15, 19, 23, 27, 31, 35, 39, 43, 47
                51, 55, 59, 63, 67, 71, 75, 79, 83, 87
                91, 95, 99, 106, 110, 114, 118, 122, 126
                130, 134, 138, 142, 149, 153, 157, 161
                165, 169, 173, 177, 181, 185, 195, 199
                203

A manual run shows:

ok 7 - An object of class 'version' isa 'version' # TODO
ok 11 - An object of class 'version' isa 'version' # TODO

etc. I don't know whether something has been correctly fixed in blead or whether this is a spurious pass. If the former, it would be handy for the next release of perl to not spew lots of "todo passed" messages. We have final code freeze on 20th April (5 days time). Potentially we could just tweak the test script in blead to be quiet.

karenetheridge commented 5 years ago

This seems to be coming from a misbehaving TODO -- in some tests, $TODO is set to the empty string rather than undef, and this is resulting in tests being displayed as "todo passed".

I can still fix this in Module::Metadata, for the sake of a quieter blead in the meantime... I wil release a new Module-Metadata shortly and then update blead to match.

toddr commented 4 years ago

@karenetheridge did this ever get sorted?