search

Perl-Toolchain-Gang / Software-License

perl representation of common software licenses
18 stars 40 forks source link

Artistic classnames don't match meta spec #24

Closed Leont closed 10 years ago

Leont commented 10 years ago

The classnames of Software::License::Artistic_1_0 and Software::License::Artistic_2_0 don't match with the CPAN::Meta::Spec 2.0 entries artistic_1 and artistic_2. This confuses Module::Build.

Should they match? The fact that the rest does suggests this is the case, as does the logic in guess_license_from_meta, but this isn't explicitly state anywhere.

karenetheridge commented 10 years ago

If they are supposed to match, it would be good to add a unit test that runs through all the names known to the spec to make sure that they stay matched.

magnolia-k commented 10 years ago

I think that a good solution is adding an alias Modules.

https://github.com/magnolia-k/Software-License/commit/a0ac1ac9d63951e13ee62016b2bc8943b7efa2b6

magnolia-k commented 10 years ago

I wrote 'use parent version'.

https://github.com/magnolia-k/Software-License/commit/67d6187418710ea11ea44ee1b71fbf481184d912

rjbs commented 10 years ago

I did what we discussed and added guess_license_from_meta_key.