new_from_short_name falls back on Software::License::ShortName

Perl-Toolchain-Gang / Software-License

perl representation of common software licenses

18 stars 40 forks source link

new_from_short_name falls back on Software::License::ShortName #31

Closed dod38fr closed 8 years ago

dod38fr commented 10 years ago

Hello

Previously,new_from_short_name worked using a set of pre-defined short names like GPL-1...

Unfortunately, this means that this method failed when using a short name like MIT.

This patch fixes this behavior: when the passed short name is not known (say Foo), new_from_short_name tries to load a class like Software::License::Foo.

I believe that this behavior makes more sense.

All the best

karenetheridge commented 8 years ago

With some squashing, and correcting the typo noted above, this looks reasonable to me on first glance.

dod38fr commented 8 years ago

No problem. I'll do this tomorrow.

All the best

dod38fr commented 8 years ago

Done. The typo is fixed and the commits were squashed.

All the best

dod38fr commented 8 years ago

Actutally, this PR was merged a while ago by rjbs. I don't know why this PR was not closed before.

dod38fr commented 8 years ago

Hum, I messed up the above squash. I've now fixed everything but I cannot re-open this PR.

I'm going to create another PR.

Sorry about the mess