search

Perl-Toolchain-Gang / Software-License

perl representation of common software licenses
18 stars 40 forks source link

new_from_short_name falls back on Software::License::ShortName class #44

Closed dod38fr closed 6 years ago

dod38fr commented 8 years ago

Hello

This is a squashed version of the previous PR #31 .

Previously,new_from_short_name worked using a set of pre-defined short names like GPL-1...

Unfortunately, this means that this method failed when using a short name like MIT.

This patch fixes this behavior: when the passed short name is not known (say Foo), new_from_short_name tries to load a class like Software::License::Foo.

I believe that this behavior makes more sense.

All the best

rjbs commented 8 years ago

I'm not sure about this. Anybody else?

dod38fr commented 8 years ago

new_from_short_name could be used in App::Software::License::_build__software_license. This way, user would not have to remember the exact name of Software::License::*. I.e. the following commands would work:

software-license --holder 'J. Random Hacker' --license Perl-5 --type notice

This would make App::Software::License more user friendly. Of course, this patch could also be improved so that --license perl5 would also work.

@karenetheridge what do think ?

dod38fr commented 7 years ago

A year has passed...

Is there anything I can do to help ?

I can also new_from_short_name so more short names are accepted, e.g. not only GPL-1 but also gpl-1 gpl1... Is this something you would be interested in ?

All the best

dod38fr commented 6 years ago

Hello

This PR is going nowhere. I'm going to create a new module named Software::LicenseUtils::More to provide this feature.

I'll probably also create a new Software::LicenseUtils::Debian to provide license summaries specific to Debian which are currently provided as patches

All the best

dod38fr commented 6 years ago

Done: http://search.cpan.org/dist/Software-LicenseMoreUtils/