search

Perl-Toolchain-Gang / Test-Harness

Run Perl standard test scripts with statistics
http://testanything.org/
29 stars 65 forks source link

Let the aggregator finish gracefully after bailout #96

Closed Dominik-Sauer closed 4 years ago

Dominik-Sauer commented 4 years ago

Some derived harnesses, e.g. T:H:JUnit, do all their meaningful work (e.g. formatting aggregated test results into XML) after the aggregate_tests finishes normally. Bailing out prevented this meaningful work to be finished, causing the test results, including potential clues to why the test bailed out in first place, to be thrown away.

Leont commented 4 years ago

Sounds like a reasonable idea

choroba commented 4 years ago

Anything else to be done here? We'd like to get this fixed in the upstream instead of maintaining our patched version. Thanks.

Leont commented 4 years ago

Anything else to be done here? We'd like to get this fixed in the upstream instead of maintaining our patched version. Thanks.

Sorry about that. I would like to have this tested, but I'm not sure how to do that.

mohawk2 commented 4 years ago

Dev-release off a branch with this?

Dominik-Sauer commented 4 years ago

I'll try to amend with tests.

Dominik-Sauer commented 4 years ago

So I've written some tests for the fixed bailout.

mohawk2 commented 4 years ago

Looks good to me now.

Dominik-Sauer commented 4 years ago

So, is there anything I can do to get in merged?