search

Perl-Toolchain-Gang / module-build-tiny

A tiny replacement for Module::Build
10 stars 17 forks source link

'dzil build' and 'dzil test' fail #36

Open jkeenan opened 2 months ago

jkeenan commented 2 months ago

Today I forked the module-build-tiny repository and cloned it locally. I installed prerequisites per dzil authordeps --missing | cpanm against perl-5.40.0. I then called the following:

[module-build-tiny] 2009 $ dzil build
[DZ] beginning to build Module-Build-Tiny
[DZ] guessing dist's main_module is lib/Module/Build/Tiny.pm
[GitHub::Meta] Getting GitHub repository info
[DZ] writing Module-Build-Tiny in Module-Build-Tiny-0.001
[OnlyCorePrereqs] detected a configure requires dependency that is not in core: Module::Build::Tiny
[OnlyCorePrereqs] aborting build due to invalid dependencies
[OnlyCorePrereqs] aborting build due to invalid dependencies at inline delegation in Dist::Zilla::Plugin::OnlyCorePrereqs for logger->log_fatal (attribute declared in /home/jkeenan/perl5/perlbrew/perls/perl-5.40.0/lib/site_perl/5.40.0/Dist/Zilla/Role/Plugin.pm at line 61) line 18.

[module-build-tiny] 2010 $ dzil test
[DZ] building distribution under .build/agTtei55sd for installation
[DZ] beginning to build Module-Build-Tiny
[DZ] guessing dist's main_module is lib/Module/Build/Tiny.pm
[GitHub::Meta] Getting GitHub repository info
[DZ] writing Module-Build-Tiny in .build/agTtei55sd
[OnlyCorePrereqs] detected a configure requires dependency that is not in core: Module::Build::Tiny
[OnlyCorePrereqs] aborting build due to invalid dependencies
[OnlyCorePrereqs] aborting build due to invalid dependencies at inline delegation in Dist::Zilla::Plugin::OnlyCorePrereqs for logger->log_fatal (attribute declared in /home/jkeenan/perl5/perlbrew/perls/perl-5.40.0/lib/site_perl/5.40.0/Dist/Zilla/Role/Plugin.pm at line 61) line 18.

Can you identify what's going wrong? Thanks.

jkeenan commented 2 months ago

Today I also attempted to install Module::Build::Tiny against perl at v5.41.3-7-g869f245507 on a FreeBSD server. As you can see from the two CPANtesters results here, I first failed because I did not have CPAN::Requirements::Dynamic installed -- something which I would have expected to have been detected earlier in the cpan process. Once I separately installed that module, the Module::Build::Tiny installation proceeded successfully.

I don't know whether that problem is the same or different from what dzil was reporting.

sdt commented 2 months ago

Similar results here:

Building and testing Module-Build-Tiny-0.049 ... cp lib/Module/Build/Tiny.pm blib/lib/Module/Build/Tiny.pm
t/simple.t .. Can't locate CPAN/Requirements/Dynamic.pm in @INC (you may need to install the CPAN::Requirements::Dynamic module) (@INC entries checked: inc /root/.cpanm/work/1725413281.1/Module-Build-Tiny-0.049/blib/arch /root/.cpanm/work/1725413281.1/Module-Build-Tiny-0.049/blib/lib /usr/local/lib/perl5/site_perl/5.38.2/x86_64-linux-gnu /usr/local/lib/perl5/site_perl/5.38.2 /usr/local/lib/perl5/vendor_perl/5.38.2/x86_64-linux-gnu /usr/local/lib/perl5/vendor_perl/5.38.2 /usr/local/lib/perl5/5.38.2/x86_64-linux-gnu /usr/local/lib/perl5/5.38.2 .) at /root/.cpanm/work/1725413281.1/Module-Build-Tiny-0.049/blib/lib/Module/Build/Tiny.pm line 194.

t/simple.t .. 1/? 
#   Failed test 'Ran Build.PL'
#   at t/simple.t line 75.
#          got: '512'
#     expected: '0'
load_file() requires a valid, readable filename at t/simple.t line 140.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 22.
firefart commented 2 months ago

Same here, my docker builds keep failing on LWP::Protocol::https as down the dependency chain Module-Build-Tiny-0.049 fails with this test. Using perl v5.40.0

Building and testing Module-Build-Tiny-0.049
cp lib/Module/Build/Tiny.pm blib/lib/Module/Build/Tiny.pm
Can't locate CPAN/Requirements/Dynamic.pm in @INC (you may need to install the CPAN::Requirements::Dynamic module) (@INC entries checked: inc /root/.cpanm/work/1725433570.679/Module-Build-Tiny-0.049/blib/arch /root/.cpanm/work/1725433570.679/Module-Build-Tiny-0.049/blib/lib /usr/local/lib/perl5/site_perl/5.40.0/x86_64-linux-gnu /usr/local/lib/perl5/site_perl/5.40.0 /usr/local/lib/perl5/vendor_perl/5.40.0/x86_64-linux-gnu /usr/local/lib/perl5/vendor_perl/5.40.0 /usr/local/lib/perl5/5.40.0/x86_64-linux-gnu /usr/local/lib/perl5/5.40.0 .) at /root/.cpanm/work/1725433570.679/Module-Build-Tiny-0.049/blib/lib/Module/Build/Tiny.pm line 194.

#   Failed test 'Ran Build.PL'
#   at t/simple.t line 75.
#          got: '512'
#     expected: '0'
load_file() requires a valid, readable filename at t/simple.t line 140.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 22.
t/simple.t ..
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/22 subtests

Test Summary Report
-------------------
t/simple.t (Wstat: 512 (exited 2) Tests: 22 Failed: 1)
  Failed test:  1
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=1, Tests=22,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.18 cusr  0.01 csys =  0.20 CPU)
Result: FAIL
-> FAIL Installing Module::Build::Tiny failed. See /root/.cpanm/work/1725433570.679/build.log for details. Retry with --force to force install it.
-> FAIL Installing the dependencies failed: Module 'Module::Build::Tiny' is not installed
-> FAIL Bailing out the installation for HTTP-Daemon-6.16.
firefart commented 2 months ago

Looks like this is related to https://github.com/Perl-Toolchain-Gang/module-build-tiny/commit/e7db0c7f37fc1cf351a7ff7050127e8d27055c18

If I cpanm install CPAN::Requirements::Dynamic the error is gone.

Leont commented 2 months ago

Yeah I should have tested that change better, will revert for now.

sdt commented 2 months ago

0.050 has fixed it for me. Thank you @Leont !

jkeenan commented 2 months ago

Unfortunately, 0.050 doesn't get me any farther. Results just now:

[module-build-tiny] 2029 $ dzil build
[DZ] beginning to build Module-Build-Tiny
[Git::NextVersion] Bumping version from 0.050 to 0.051
[DZ] guessing dist's main_module is lib/Module/Build/Tiny.pm
[GitHub::Meta] Getting GitHub repository info
[DZ] writing Module-Build-Tiny in Module-Build-Tiny-0.051
[OnlyCorePrereqs] detected a configure requires dependency that is not in core: Module::Build::Tiny
[OnlyCorePrereqs] aborting build due to invalid dependencies
[OnlyCorePrereqs] aborting build due to invalid dependencies at inline delegation in Dist::Zilla::Plugin::OnlyCorePrereqs for logger->log_fatal (attribute declared in /home/jkeenan/perl5/perlbrew/perls/perl-5.40.0/lib/site_perl/5.40.0/Dist/Zilla/Role/Plugin.pm at line 61) line 18.
[module-build-tiny] 2030 $ dzil test
[DZ] building distribution under .build/k_hgjp5WR4 for installation
[DZ] beginning to build Module-Build-Tiny
[Git::NextVersion] Bumping version from 0.050 to 0.051
[DZ] guessing dist's main_module is lib/Module/Build/Tiny.pm
[GitHub::Meta] Getting GitHub repository info
[DZ] writing Module-Build-Tiny in .build/k_hgjp5WR4
[OnlyCorePrereqs] detected a configure requires dependency that is not in core: Module::Build::Tiny
[OnlyCorePrereqs] aborting build due to invalid dependencies
[OnlyCorePrereqs] aborting build due to invalid dependencies at inline delegation in Dist::Zilla::Plugin::OnlyCorePrereqs for logger->log_fatal (attribute declared in /home/jkeenan/perl5/perlbrew/perls/perl-5.40.0/lib/site_perl/5.40.0/Dist/Zilla/Role/Plugin.pm at line 61) line 18.
Leont commented 2 months ago

What's your version of Dist::Zilla::Plugin::ModuleBuildTiny? And does upgrading it fix the issue? Probably you need at least 0.016.

jkeenan commented 2 months ago

Dist::Zilla::Plugin::ModuleBuildTiny

$ perl -MDist::Zilla::Plugin::ModuleBuildTiny -E 'say $Dist::Zilla::Plugin::ModuleBuildTiny::VERSION;'
0.017
Leont commented 2 months ago

Weird, I can't explain or reproduce that.