search

Perl / docker-perl

Dockerfiles for index.docker.io (official Perl Docker image)
https://registry.hub.docker.com/_/perl/
Artistic License 2.0
117 stars 51 forks source link

Adjust "cpm" install to use hard-coded path #121

Closed tianon closed 2 years ago

tianon commented 2 years ago

This should fix "cpanm" being mistakenly removed 🙈

I also added some verification of both "cpanm" and "cpm" at least being invokable to help avoid this in the future.

Follow-up to #119 & #120

(See https://github.com/docker-library/official-images/pull/12612#issuecomment-1171780506)

tianon commented 2 years ago

@zakame this one's got a lot of "splash damage" - anything more I can do to help? :sweat_smile: :heart: :pray:

(or perhaps we can pull @PeterMartini out of hiding? :innocent: :heart:)

miyagawa commented 2 years ago

Looks good to me.

By the way what is this rm -fr ./cpanm supposed to do? I am not seeing a creation of /root/cpanm in the script. Was it meant to be ./.cpanm but a typo for that?

tianon commented 2 years ago

Ah, good catch -- I think it's a leftover from f91962cfe61d74f54f73db35a6e72d04d2391570 (where it was previously downloading the self-contained cpanm script to use to install cpanm).

zakame commented 2 years ago

Thanks @tianon @miyagawa for catching this! 👍 I realize we had a cpanm install test in https://github.com/Perl/docker-perl/commit/a2d458212582f2b800bb8f1af273b9baa4ac38c8 but that got reverted - that would have caught this earlier!

perlpunk commented 2 years ago

I was bitten by this yesterday and finally researched where the docker images are actually maintained. thanks for fixing :)