Perl / docker-perl

Dockerfiles for index.docker.io (official Perl Docker image)
https://registry.hub.docker.com/_/perl/
Artistic License 2.0
117 stars 51 forks source link

Change WORKDIR from / to /usr/src/app #141

Closed waterkip closed 11 months ago

waterkip commented 11 months ago

What changed is that in bookworm the lib dir has become a symlink to /usr/lib. This prevents COPY . . to copy over our lib dir to the layer.

For more information:

Closes: https://github.com/Perl/docker-perl/issues/140

Signed-off-by: Wesley Schwengle waterkip@cpan.org

zakame commented 11 months ago

LGTM, thanks @waterkip ! 🙏

Can we add a test in https://github.com/Perl/docker-perl/blob/master/.github/workflows/build-image.yml based on what we've observed (so on the off chance we revert WORKDIR or some other change happens, we can can catch this issue later?)

waterkip commented 11 months ago

Added the test.

It might be considered a breaking change. For example, if someone did COPY foo . and later on does RUN /foo it will stop working.

waterkip commented 11 months ago

LGTM! +1 thanks for this - as for the breaking change, I think Debian broke us first joy_cat we'll just make an update on our doc and move forward rocket

Haha, ok ok :)