Add an "update.sh" - Githubissues

Perl / docker-perl

Dockerfiles for index.docker.io (official Perl Docker image)

https://registry.hub.docker.com/_/perl/

Artistic License 2.0

119 stars 51 forks source link

Add an "update.sh" #59

Open J0WI opened 5 years ago

J0WI commented 5 years ago

@docker-library-bot can run a simple update.sh script for you to update the Perl version automatically. Just add it to the team and open a corresponding PR here: https://github.com/docker-library/oi-janky-groovy/blob/master/update.sh/vars.groovy

See e.g. here: https://github.com/docker-library/wordpress/commit/d775299ddae6dafa232166f44b7c03d23ddf7bb6

zakame commented 5 years ago

Thanks @J0WI, I think you've brought this up before in https://github.com/Perl/docker-perl/pull/24#issuecomment-439660780

I'll try taking a look at this again this weekend.

zakame commented 5 years ago

So I've taken a look, and so far a few things need to happen here:

A way to get stable/oldstable Perl release versions reliably: asking on #p5p I was pointed to looking at https://perl5.git.perl.org/perl.git tags and this seems easy enough to implement in an update.sh
A means to run Devel::PatchPerl under update.sh; this could be just as simple as running generate.pl under update.sh (after it updates config.yml) but I'm not sure of the environment update.sh runs on, particularly if I can run perl/cpanm on it. @J0WI @tianon would you know?
A better way to manage that config.yml (and maybe converting to config.json as it seems CLI tools to use under update.sh talk better in JSON than in YAML.)

I'm happy to hear of more ideas/considerations as well, thanks again for suggesting!

tianon commented 5 years ago

You definitely shouldn't rely on running perl/cpanm via update.sh if you want @docker-library-bot to be running it. It's reasonable to rely on curl/wget/jq, but perl or cpanm is too much. It might make more sense to use Travis CI or something like it, especially now that they support cron jobs (https://docs.travis-ci.com/user/cron-jobs/), since you'll be able to control the environment much better.

See https://github.com/docker-library/docs/issues/1248#issuecomment-395829086 for a bit more detail on what we use @docker-library-bot for (and how much it does). It's really not very much. :sweat_smile:

zakame commented 5 years ago

Thanks @tianon, yeah this might be more doable using Travis CI cron jobs; I've been thinking about adding CI for a while now so this might push it further.

mohawk2 commented 4 years ago

cpanm can self-bootstrap via curl though?

zakame commented 4 years ago

Yes, this is worth revisiting now that perl5 itself is now hosted here; we can probably look at https://github.com/Perl/perl5/releases to get update info (and probably have some additional tooling there so that https://github.com/Perl/perl5/releases/latest can point to the right new version.)

waterkip commented 3 years ago

There is CPAN::Perl::Releases[1] which can give you some information about where you can download the tarball. It does not give you the checksum. But I think that is just a PR away to include that information. You can than automate much of the generation of the configuration and even make it smaller because most of the info can be found in the module.

[1] https://metacpan.org/pod/CPAN::Perl::Releases

mohawk2 commented 3 years ago

It might be worth thinking about using the MetaCPAN API to get all available Perl versions (it might take a feature request, but ought to be straightforward). Also I'd think about using GitHub Actions (which can be triggered periodically) rather than the basically defunct Travis CI.

zakame commented 2 years ago

Thanks, probably high time to revisit this - we can have a GH action that can be scheduled or triggered to produce the PR needed for updating against a new Perl version.