Closed p5pRT closed 14 years ago
Blead now introduces "strict" rules for version numbers in 'package NAME VERSION' and "lax" rules for UNIVERSAL::VERSION and version->new().
Before 5.12 release\, all these new rules need to be noted in the documentation for these functions/modules.
While the rules for use() are relatively unchanged\, it would be a good idea to add documentation there as well that notes the new standards.
We should consider whether an entirely new documentation file would be helpful in explaining the strict and lax rules (and historical rationale).
-- David
Blead now introduces "strict" rules for version numbers in 'package NAME VERSION' and "lax" rules for UNIVERSAL::VERSION and version->new().
Before 5.12 release\, all these new rules need to be noted in the documentation for these functions/modules.
While the rules for use() are relatively unchanged\, it would be a good idea to add documentation there as well that notes the new standards.
We should consider whether an entirely new documentation file would be helpful in explaining the strict and lax rules (and historical rationale).
I saw that you committed docs yesterday or the day before. Do you feel like what we have is now sufficient?
The RT System itself - Status changed from 'new' to 'open'
I saw that you committed docs yesterday or the day before. Do you feel like what we have is now sufficient?
No. The documentation for version.pm needs to more formally describe the rules and the new functions is_strict and is_lax need documentation as well.
-- David
On 01/16/2010 04:32 PM\, "xdaveg@gmail.com"@vulcan.hyperbolic.net (via RT) wrote:
Blead now introduces "strict" rules for version numbers in 'package NAME VERSION' and "lax" rules for UNIVERSAL::VERSION and version->new().
Before 5.12 release\, all these new rules need to be noted in the documentation for these functions/modules.
First pass at documenting $version::LAX and $version::STRICT
http://github.com/JohnPeacock/perl/tree/document_version_strict_lax git://github.com/JohnPeacock/perl.git branch document_version_strict_lax
I'm in the midst of rewriting the pure Perl implementation for CPAN to be more like the XS code\, but there is no reason to hold up nailing down the core changes now.
John
On Tue\, Jan 26\, 2010 at 9:30 PM\, John Peacock \john\.peacock@​havurah\-software\.org wrote:
git://github.com/JohnPeacock/perl.git branch document_version_strict_lax
I wish git had a better syntax for referring to branches or other reference points. E.g.:
git://github.com/JohnPeacock/perl.git#document_version_strict_lax
If anyone in the LazyWeb is close enough to git development to suggest standardizing git URIs in such a fashion\, that would be lovely.
David
[copying my comments from another p5p thread]
I still think that version number documentation is more dense than I'd like it to be\, but I'm two weeks behind on CPAN Tester 2.0 and I don't have the round tuits to figure out what it needs or do any editing myself. Maybe it's inevitable given the complexity of the topic.
My quick notes are:
* VERSION OBJECT DETAILS should move to version::Internals (to the extent it isn't already covered there) and a very brief note about how alpha versions compare be added to the section "How to compare version objects"; that leaves version.pod entirely focused on how to get things done. It's then a "cookbook" with some method/function docs and I think that's all 99.99% of people will ever need.
* Add an OTHER FUNCTIONS section with is_strict() and is_lax() for completeness.
* In version::Internals\, remove the SUBCLASSING section or else leave it and add text discouraging people from subclassing and remove reference to version::AlphaBeta (in fact\, I recommend deleting that module from CPAN).
I've taken John's work\, made the changes I suggested above (plus some other minor cleanup and doc tweaks) and pushed the result to blead:
6369c73 move version details to version::Internals and other clean up a525e6d document version::is_strict/is_lax 42bd538 Document usage of version regexps 61a0cb1 Export and document is_lax and is_strict functions
Unless John has objections\, I believe this ticket can be closed and the new documentation can be pulled into the next CPAN release of version.pm.
-- David
On 02/06/2010 03:14 PM\, David Golden via RT wrote:
I've taken John's work\, made the changes I suggested above (plus some other minor cleanup and doc tweaks) and pushed the result to blead:
6369c73 move version details to version::Internals and other clean up a525e6d document version::is_strict/is_lax 42bd538 Document usage of version regexps 61a0cb1 Export and document is_lax and is_strict functions
Unless John has objections\, I believe this ticket can be closed and the new documentation can be pulled into the next CPAN release of version.pm.
Close away\, I'm sure that what you wrote was fine. I've just emerged
from Snowmageddon 2010 - 36 hours with no power or heat or Internet
\
I'll pull it into version.pm as soon as I get a chance. I'm inclined to bump $VERSION to 0.82 in core and then pick up the remaining doc changes (and the return value optimizations that I missed somehow) and push a new CPAN release.
John
Closing this ticket.
@xdg - Status changed from 'open' to 'resolved'
Migrated from rt.perl.org#72130 (status was 'resolved')
Searchable as RT72130$