p5pRT
commented
14 years ago From p5p@perl.wizbit.be
While writing tests for another bug I discovered a bug in the stacked
file tests.
When -T\, -t or -B are used in a stacked file tests then too much is
removed from the stack.
Example:
#!/usr/bin/perl -l use strict; use warnings; use Test::More tests => 2;
my $count;
my $t;
{
$count = 0;
for my $m ("c"\, "d") {
if ($count == 0) {
$t = -t -e $^X ? 0 : "bar";
}
elsif ($count == 1) {
is($m\, "d"\, "-t -e \$^X did not remove too many values
from the stack");
}
$count++;
}
$count = 0;
for my $m ("e"\, "f") {
if ($count == 0) {
$t = -T -e $^X ? 0 : "baz";
}
elsif ($count == 1) {
is($m\, "f"\, "-T -e \$^X did not remove too many values
from the stack");
}
$count++;
}
}
__END__
The output of this on blead (81b00ac76d16334c61edb1e9a4a364d00d0db5c6)
and perl-5.10.0:
1..2 not ok 1 - -t -e $^X did not remove too many values from the stack # Failed test '-t -e $^X did not remove too many values from the stack' # at /tmp/filetest.pl line 12. # got: 'bar' # expected: 'd' not ok 2 - -T -e $^X did not remove too many values from the stack # Failed test '-T -e $^X did not remove too many values from the stack' # at /tmp/filetest.pl line 23. # got: 'baz' # expected: 'f' # Looks like you failed 2 tests of 2.
A test case that is fatal:
#!/usr/bin/perl -l
use strict; use warnings; use Test::More tests => 1;
my $count;
my $t;
{
$count = 0;
for my $m ("g"\, "h") {
if ($count == 0) {
my $foo;
$foo->{bar} = -T -e $^X ? 0 : "baz";
}
elsif ($count == 1) {
is($m\, "f"\, "-T -e \$^X did not remove too many values
from the stack");
}
$count++;
}
}
__END__
Output: 1..1 Use of freed value in iteration at /tmp/filetest.pl line 19. # Looks like your test exited with 2 before it could output anything.
I had a talk with Jan Dubois about this (because he fixed a similar
bug with -u/-g/-k on windows) and this are his notes:
\
stacked file tests
\
filename on the stack\, it leaves the result of the test only.
\
STACKED_FTEST_CHECK and either return early with a FALSE value\, or
continue checking
\
test in the sequence
\
is nothing there in this case
\
is hidden in my_stat() in doio.c (my_stat_flags in 5.12)
\
filetest is executed. So how are you going to make the check now?
\
something like that.
\
stacked file tests but I don't know how complicated that is..
Best regards\,
Bram
Migrated from rt.perl.org#77388 (status was 'resolved')
Searchable as RT77388$