Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.97k stars 559 forks source link

[PATCH] Skip hanging taint.t test on MirBSD 10 #11095

Closed p5pRT closed 13 years ago

p5pRT commented 13 years ago

Migrated from rt.perl.org#82988 (status was 'resolved')

Searchable as RT82988$

p5pRT commented 13 years ago

From @stsc

Created by @stsc

This patch allows for make test to complete when perl is configured with ithreads support (verified for MirBSD 10 on eurynome.mirbsd.org where also the Test​::Smoke core smoker runs).

Inline Patch ```diff diff --git a/t/op/taint.t b/t/op/taint.t index e873ba2..fb8ad34 100644 --- a/t/op/taint.t +++ b/t/op/taint.t @@ -48,6 +48,7 @@ my $Is_NetWare = $^O eq 'NetWare'; my $Is_Dos = $^O eq 'dos'; my $Is_Cygwin = $^O eq 'cygwin'; my $Is_OpenBSD = $^O eq 'openbsd'; +my $Is_MirBSD = $^O eq 'mirbsd'; my $Invoke_Perl = $Is_VMS ? 'MCR Sys$Disk:[]Perl.exe' : $Is_MSWin32 ? '.\perl' : $Is_NetWare ? 'perl' : @@ -1159,8 +1160,8 @@ SKIP: { SKIP: { skip "fork() is not available", 3 unless $Config{'d_fork'}; - skip "opening |- is not stable on threaded OpenBSD with taint", 3 - if $Config{useithreads} && $Is_OpenBSD; + skip "opening |- is not stable on threaded Open/MirBSD with taint", 3 + if $Config{useithreads} and $Is_OpenBSD || $Is_MirBSD; $ENV{'PATH'} = $TAINT; local $SIG{'PIPE'} = 'IGNORE'; ```
Perl Info ``` Flags: category=install severity=medium Site configuration information for perl 5.13.9: Configured by stsc at Thu Jan 27 18:41:38 UTC 2011. Summary of my perl5 (revision 5 version 13 subversion 9) configuration: Platform: osname=mirbsd, osvers=10, archname=MirBSD.i386-mirbsd-thread-multi uname='mirbsd eurynome.mirbsd.org 10 kv#10uae-20110123 generic#1308 i386 ' config_args='-des -Dusedevel -Dusethreads -Dprefix=/home/stsc/test/perl-5.13.9' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='mgcc', ccflags ='-pthread -fhonour-copts -I/usr/mpkg/include -I/usr/local/include', optimize='-O2', cppflags='-fhonour-copts -I/usr/mpkg/include -pthread -fhonour-copts -I/usr/mpkg/include -I/usr/local/include' ccversion='', gccversion='3.4.6 (propolice; gpc; MirOS 0AAB)', gccosandvers='mirbsd10' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='mgcc', ldflags ='-pthread -Wl,-E -L/usr/mpkg/lib -L/usr/local/lib' libpth=/usr/mpkg/lib /usr/local/lib /usr/lib libs=-lgdbm -lm -lutil -lc perllibs=-lm -lutil -lc libc=/usr/lib/libc.so.41.9, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' ' cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC -L/usr/mpkg/lib -L/usr/local/lib' Locally applied patches: @INC for perl 5.13.9: /home/stsc/test/perl-5.13.9/lib/site_perl/5.13.9/MirBSD.i386-mirbsd-thread-multi /home/stsc/test/perl-5.13.9/lib/site_perl/5.13.9 /home/stsc/test/perl-5.13.9/lib/5.13.9/MirBSD.i386-mirbsd-thread-multi /home/stsc/test/perl-5.13.9/lib/5.13.9 . Environment for perl 5.13.9: HOME=/home/stsc LANG (unset) LANGUAGE (unset) LC_CTYPE=en_US.UTF-8 LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/stsc/bin:/home/stsc/.etc/bin:/usr/local/bin:/usr/mpkg/bin:/usr/bin:/bin:/usr/X11R6/bin:/usr/sbin:/sbin:/usr/mpkg/sbin:/usr/games PERL_BADLANG (unset) SHELL=/bin/mksh ```
p5pRT commented 13 years ago

From @cpansprout

On Sat Jan 29 07​:24​:53 2011\, stsc@​refcnt.org wrote​:

This is a bug report for perl from stsc@​refcnt.org\, generated with the help of perlbug 1.39 running under perl 5.13.9.

----------------------------------------------------------------- [Please describe your issue here]

This patch allows for make test to complete when perl is configured with ithreads support (verified for MirBSD 10 on eurynome.mirbsd.org where also the Test​::Smoke core smoker runs).

diff --git a/t/op/taint.t b/t/op/taint.t

Thank you. Applied as 1fb83d06.

p5pRT commented 13 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 13 years ago

@cpansprout - Status changed from 'open' to 'resolved'