Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

Minor fixes for IO::Socket.pm #113

Closed p5pRT closed 20 years ago

p5pRT commented 24 years ago

Migrated from rt.perl.org#917 (status was 'resolved')

Searchable as RT917$

p5pRT commented 24 years ago

From ian@dial.pipex.com

Here is a patch which fixes the 'usage' message for IO​::Socket​::socketpair\, and clarifies its documentation.

A couple of minor glitches in the pod text are fixed in passing.

The base for the patch is the Socket.pm with 5.00551; My previous patch would best be applied first.

Ian

*** ext/IO/lib/IO/Socket.pm Fri May 15 15​:33​:14 1998 --- ext/IO/lib/IO/Socket.pm.revised Fri Jun 25 10​:29​:03 1999 *************** *** 75\,83 ****   that was trying to connect. In a scalar context the new socket is returned\,   or undef upon failure. In an array context a two-element array is returned ! containing the new socket and the peer address\, the list will   be empty upon failure.  
  Additional methods that are provided are  
  =item timeout([VAL])  
--- 75\,92 ----   that was trying to connect. In a scalar context the new socket is returned\,   or undef upon failure. In an array context a two-element array is returned ! containing the new socket and the peer address; the list will   be empty upon failure.  
+ =item socketpair(DOMAIN\, TYPE\, PROTOCOL) + + Call C\ and return an array of the two sockets created\, + or an empty list on failure. + + =back +   Additional methods that are provided are  
+ =over 4 +   =item timeout([VAL])  
*************** *** 124\,128 ****   @​ISA = qw(IO​::Handle);  
! $VERSION = "1.1603";  
  sub import { --- 133\,137 ----   @​ISA = qw(IO​::Handle);  
! $VERSION = "1.1603"; CHANGE ME  
  sub import { *************** *** 182\,186 ****  
  sub socketpair { ! @​_ == 4 || croak 'usage​: IO​::Socket->pair(DOMAIN\, TYPE\, PROTOCOL)';   my($class\,$domain\,$type\,$protocol) = @​_;   my $fh1 = $class->new(); --- 191\,195 ----  
  sub socketpair { ! @​_ == 4 || croak 'usage​: IO​::Socket->socketpair(DOMAIN\, TYPE\, PROTOCOL)';   my($class\,$domain\,$type\,$protocol) = @​_;   my $fh1 = $class->new();

Perl Info ``` This perlbug was built using Perl 5.00551 - Mon Oct 26 11:39:16 GMT 1998 It is being executed now by Perl 5.00404 - Sun Apr 26 12:56:41 BST 1998. Site configuration information for perl 5.00404: Configured by ian at Sun Apr 26 12:56:41 BST 1998. Summary of my perl5 (5.0 patchlevel 4 subversion 4) configuration: Platform: osname=linux, osvers=2.0.0, archname=i586-linux uname='linux penstock 2.0.0 #1 mon jan 20 15:07:14 gmt 1997 i586 ' hint=previous, useposix=true, d_sigaction=define bincompat3=n useperlio=undef d_sfio=undef Compiler: cc='cc', optimize='-O2', gccversion=2.7.2 cppflags='-Dbool=char -DHAS_BOOL -I/usr/local/include' ccflags ='-Dbool=char -DHAS_BOOL -I/usr/local/include' stdchar='char', d_stdstdio=define, usevfork=false voidflags=15, castflags=0, d_casti32=define, d_castneg=define intsize=4, alignbytes=4, usemymalloc=n, prototype=define Linker and Libraries: ld='cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lgdbm -ldb -ldl -lm -lc libc=/lib/libc.so.5.3.12, so=so useshrplib=false, libperl=libperl.a Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic' cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib' Locally applied patches: @INC for perl 5.00404: /u2/ian/lib/perl5 /usr/local/lib/perl5/i586-linux/5.00404 /usr/local/lib/perl5 /usr/local/lib/perl5/site_perl/i586-linux /usr/local/lib/perl5/site_perl . Environment for perl 5.00404: HOME=/u2/ian LANG (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/u2/ian/cmd:/u2/ian/Linux:/usr/local/bin:/u2/ian/stocks/cmd:/usr/openwin/bin:/usr/bin/X11:/usr/bin:/bin:/usr/lib/teTeX/bin:/usr/etc:/sbin:/usr/sbin PERL5LIB=/u2/ian/lib/perl5 PERL_BADLANG (unset) SHELL=/bin/zsh ```