Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

Pod::Html changes broke C<> formatting #1133

Closed p5pRT closed 20 years ago

p5pRT commented 24 years ago

Migrated from rt.perl.org#2093 (status was 'resolved')

Searchable as RT2093$

p5pRT commented 24 years ago

From @jandubois

Created by @jandubois

The following change seems to have broken C\<> formatting in Pod​::HTML​:

  ____________________________________________________________________________   [ 4840] By​: gsar on 2000/01/22 12​:04​:30   Log​: heavy cleanup of Pod​::Html bug fixes (from Wolfgang Laun   \wolfgang\.laun@&#8203;alcatel\.at)   Branch​: perl   ! lib/Pod/Html.pm   ____________________________________________________________________________

Now lines like the following​:

  =item $handle->Method(ARG)

are rendered as

  $handle->Method

i.e. everything inside the parens including the parens is gone.

The same thing happens for inline C\<> blocks. In

  The Method() method call ...

the parentheses will be removed. I see that this is intentional​:

[from process_puretext]​:

  if( $notinIS && $word =~ s/^(\w+)\((.*)\)\W*$/$1/ ) {   # has parenthesis so should have been a C\<> ref   ## try for a pagename (perlXXX(1))? ...   $word = emit_C( $word );

but I disagree with that decision.

The creation of links for C\<> sections is also very broken. The following code looks very bogus to me​:

sub coderef($$){   my( $page\, $item ) = @​_;   my( $url );

  my $fid = fragment_id( $item );   return( $url\, $fid );   if( defined( $page ) ){

...

So most of the coderef() code is actually unreachable.

Perl Info ``` Site configuration information for perl 5.00564: Configured by jand at Thu Feb 3 13:41:09 2000. Summary of my perl5 (revision 5 version 5 subversion 640) configuration: Platform: osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread uname='' config_args='undef' hint=recommended, useposix=true, d_sigaction=undef usethreads=undef use5005threads=undef useithreads=define usesocks=undef useperlio=undef d_sfio=undef use64bits=undef uselargefiles=undef usemultiplicity=define Compiler: cc='cl', optimize='-Od -MDd -Zi -D_DEBUG -DDEBUGGING', gccversion= cppflags='-DWIN32' ccflags ='-Od -MDd -Zi -D_DEBUG -DDEBUGGING -DWIN32 -D_CONSOLE -DNO_STRICT -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DPERL_MSVCRT_READFIX' stdchar='char', d_stdstdio=define, usevfork=false intsize=4, longsize=4, ptrsize=4, doublesize=8 d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10 alignbytes=8, usemymalloc=n, prototype=define Linker and Libraries: ld='link', ldflags ='-nologo -nodefaultlib -debug -pdb:none -libpath:"e:\perl64dbg\lib\CORE" -machine:x86' libpth=\lib libs=-DELAYLOAD:wsock32.dll delayimp.lib oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib msvcrtd.lib libc=msvcrtd.lib, so=dll, useshrplib=yes, libperl=perl56.lib Dynamic Linking: dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -pdb:none -libpath:"e:\perl64dbg\lib\CORE" -machine:x86' Locally applied patches: @INC for perl 5.00564: E:/perl64dbg/lib E:/perl64dbg/site/lib . Environment for perl 5.00564: HOME=H:\ LANG (unset) LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=C:\Perl\bin;T:\;H:\bin;C:\WINNT\system32;C:\WINNT;C:\Program Files\Mts;C:\Program Files\Microsoft Visual Studio\Common\Tools\WinNT;C:\Program Files\Microsoft Visual Studio\Common\MSDev98\Bin;C:\Program Files\Microsoft Visual Studio\Common\Tools;C:\Program Files\Microsoft Visual Studio\VC98\bin PERL_BADLANG (unset) SHELL (unset) ```