search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.98k stars 559 forks source link

Bleadperl v5.17.0-421-ge4a2df8 and v5.17.0-425-g2e2e3f3 break INA/Char/EUCJP/Char-EUCJP-0.82.tar.gz #12428

Closed p5pRT closed 11 years ago

p5pRT commented 12 years ago

Migrated from rt.perl.org#114978 (status was 'resolved')

Searchable as RT114978$

p5pRT commented 12 years ago

From @andk

git bisect I

commit e4a2df84a6027f19dfb84f5057abfc4ff54618b6 Author​: David Mitchell \davem@​iabyn\.com Date​: Mon Mar 12 20​:50​:02 2012 +0000

  improve skipping of regex [..] char class in toker

git bisect II

commit 2e2e3f36ef0a7bee034eac9575fdb70698beec72 Author​: David Mitchell \davem@​iabyn\.com Date​: Fri Mar 30 16​:30​:26 2012 +0100

  ensure regex evals report the right location

description

The author brought it to my attention\, I just ran the bisects. The first bisect shows that two tests were failing after it. The second bisect shows that nearly all tests started failing.

Could you please explain whether the new behaviour is correct in this context?

perl -V

Summary of my perl5 (revision 5 version 17 subversion 0) configuration​:   Commit id​: 2e2e3f36ef0a7bee034eac9575fdb70698beec72   Platform​:   osname=linux\, osvers=3.2.0-3-amd64\, archname=x86_64-linux-thread-multi-ld   uname='linux k83 3.2.0-3-amd64 #1 smp mon jul 23 02​:45​:17 utc 2012 x86_64 gnulinux '   config_args='-Dprefix=/home/src/perl/repoperls/installed-perls/perl/v5.17.0-425-g2e2e3f3/a2da -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Duselongdouble -DDEBUGGING=-g'   hint=recommended\, useposix=true\, d_sigaction=define   useithreads=define\, usemultiplicity=define   useperlio=define\, d_sfio=undef\, uselargefiles=define\, usesocks=undef   use64bitint=define\, use64bitall=define\, uselongdouble=define   usemymalloc=n\, bincompat5005=undef   Compiler​:   cc='cc'\, ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'\,   optimize='-O2 -g'\,   cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'   ccversion=''\, gccversion='4.7.1'\, gccosandvers=''   intsize=4\, longsize=8\, ptrsize=8\, doublesize=8\, byteorder=12345678   d_longlong=define\, longlongsize=8\, d_longdbl=define\, longdblsize=16   ivtype='long'\, ivsize=8\, nvtype='long double'\, nvsize=16\, Off_t='off_t'\, lseeksize=8   alignbytes=16\, prototype=define   Linker and Libraries​:   ld='cc'\, ldflags =' -fstack-protector -L/usr/local/lib'   libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib   libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lpthread -lc   perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc   libc=\, so=so\, useshrplib=false\, libperl=libperl.a   gnulibc_version='2.13'   Dynamic Linking​:   dlsrc=dl_dlopen.xs\, dlext=so\, d_dlsymun=undef\, ccdlflags='-Wl\,-E'   cccdlflags='-fPIC'\, lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:   Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS   PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT   PERL_MALLOC_WRAP PERL_PRESERVE_IVUV PERL_USE_DEVEL   USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS   USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE   USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LONG_DOUBLE   USE_PERLIO USE_PERL_ATOF USE_REENTRANT_API   Built under linux   Compiled at Sep 20 2012 08​:04​:14   @​INC​:   /home/src/perl/repoperls/installed-perls/perl/v5.17.0-425-g2e2e3f3/a2da/lib/site_perl/5.17.0/x86_64-linux-thread-multi-ld   /home/src/perl/repoperls/installed-perls/perl/v5.17.0-425-g2e2e3f3/a2da/lib/site_perl/5.17.0   /home/src/perl/repoperls/installed-perls/perl/v5.17.0-425-g2e2e3f3/a2da/lib/5.17.0/x86_64-linux-thread-multi-ld   /home/src/perl/repoperls/installed-perls/perl/v5.17.0-425-g2e2e3f3/a2da/lib/5.17.0   .

-- andreas

p5pRT commented 11 years ago

From @jkeenan

On Thu Sep 20 00​:06​:52 2012\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect I ------------ commit e4a2df84a6027f19dfb84f5057abfc4ff54618b6 Author​: David Mitchell \davem@​iabyn\.com Date​: Mon Mar 12 20​:50​:02 2012 +0000

improve skipping of regex \[\.\.\] char class in toker

git bisect II ------------- commit 2e2e3f36ef0a7bee034eac9575fdb70698beec72 Author​: David Mitchell \davem@​iabyn\.com Date​: Fri Mar 30 16​:30​:26 2012 +0100

ensure regex evals report the right location

description ----------- The author brought it to my attention\, I just ran the bisects. The first bisect shows that two tests were failing after it. The second bisect shows that nearly all tests started failing.

Could you please explain whether the new behaviour is correct in this context?

perl -V ------- Summary of my perl5 (revision 5 version 17 subversion 0) configuration​: Commit id​: 2e2e3f36ef0a7bee034eac9575fdb70698beec72

I tested Char​::EUCJP against blead today and all tests passed; see attachment.

Is there any reason to keep the ticket open (and listed as a Perl 5.18-blocker)?

Thank you very much. Jim Keenan

p5pRT commented 11 years ago

From @jkeenan

/Users/jimk/perl5/perlbrew/perls/perl-blead/bin/perl5.17.9 "-Iblib/arch" "-Iblib/lib" pMakefile.PL pMakefile   INA/Char/EUCJP/Char-EUCJP-0.86.tar.gz   /usr/bin/make -- OK 'YAML' not installed\, will not store persistent state Running make test PERL_DL_NONLAZY=1 /Users/jimk/perl5/perlbrew/perls/perl-blead/bin/perl5.17.9 "-MExtUtils​::Command​::MM" "-e" "test_harness(0\, 'blib/lib'\, 'blib/arch')" t/*.t t/015_eucjphtm.t ............ ok

# snip dozens of passing tests

t/339_getc.t ................ ok
t/340_getc.t ................ ok
t/341_getc.t ................ ok
t/342_getc.t ................ ok
t/343_getc.t ................ ok
t/344_getc.t ................ ok
All tests successful. Files=280\, Tests=5710\, 275 wallclock secs ( 5.40 usr 3.62 sys + 156.13 cusr 24.70 csys = 189.85 CPU) Result​: PASS PERL_DL_NONLAZY=1 /Users/jimk/perl5/perlbrew/perls/perl-blead/bin/perl5.17.9 "-Iblib/lib" "-Iblib/arch" test.pl 1..1 ok - 1   INA/Char/EUCJP/Char-EUCJP-0.86.tar.gz   /usr/bin/make test -- OK

p5pRT commented 11 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 11 years ago

From @rjbs

Appears resolved\, closing until further evidence appears.

-- rjbs

p5pRT commented 11 years ago

From [Unknown Contact. See original ticket]

Appears resolved\, closing until further evidence appears.

-- rjbs

p5pRT commented 11 years ago

@rjbs - Status changed from 'open' to 'resolved'