Closed p5pRT closed 11 years ago
The ./Porting directory in perl.git contains a bunch of stuff used to build\, test\, or torture perl. There are a lot of files in there.
Add a README (or something) file to ./Porting that lists each file and its purpose. If the program isn't mentioned in Porting/release_managers_guide.pod\, figure out where\, if anywhere\, it is mentioned. If you can't figure it out\, flag it as maybe just being cruft.
For extra credit\, add a test to t/porting that asserts that every file in ./Porting is in the explanatory file\, and that nothing in the README doesn't exist on disk.
On Mon Jan 21 08:00:50 2013\, rjbs wrote:
The ./Porting directory in perl.git contains a bunch of stuff used to build\, test\, or torture perl. There are a lot of files in there.
Add a README (or something) file to ./Porting that lists each file and its purpose. If the program isn't mentioned in Porting/release_managers_guide.pod\, figure out where\, if anywhere\, it is mentioned. If you can't figure it out\, flag it as maybe just being cruft.
For extra credit\, add a test to t/porting that asserts that every file in ./Porting is in the explanatory file\, and that nothing in the README doesn't exist on disk.
We're starting to plan a New York Perl Hackathon and this looks like a good topic.
However\, since that event may be several weeks off\, if someone else *really\, really* wants to work on this ticket\, feel free to Steal it from me.
Thank you very much. Jim Keenan
The RT System itself - Status changed from 'new' to 'open'
On Wed Jan 23 15:59:49 2013\, jkeenan wrote:
On Mon Jan 21 08:00:50 2013\, rjbs wrote:
The ./Porting directory in perl.git contains a bunch of stuff used to build\, test\, or torture perl. There are a lot of files in there.
Add a README (or something) file to ./Porting that lists each file and its purpose. If the program isn't mentioned in Porting/release_managers_guide.pod\, figure out where\, if anywhere\, it is mentioned. If you can't figure it out\, flag it as maybe just being cruft.
For extra credit\, add a test to t/porting that asserts that every file in ./Porting is in the explanatory file\, and that nothing in the README doesn't exist on disk.
We're starting to plan a New York Perl Hackathon and this looks like a good topic.
However\, since that event may be several weeks off\, if someone else *really\, really* wants to work on this ticket\, feel free to Steal it from me.
Thank you very much. Jim Keenan
The patch is the work of Matthew Ryder\, Arthur Goldstein and myself at New York Perl Hackathon. Our objective was to create a first draft\, not a perfect document. We ask that you review this patch with respect to the following priorities:
(1) Rule out obvious errors.
(2) Improvements in descriptions of files in Porting/.
(3) Stylistic/grammatical/typographical corrections.
When you read this document\, you will no doubt spot references to Perl core functionality that is long dead. We ask that you not use *this RT ticket* discuss whether or not we should retain certain of these Porting files; open up separate tickets for that.
We'll have to decide whether this README is sufficiently useful to be included (with edits) in Perl 5.18 this spring.
Thank you very much. Jim Keenan
From dd980c21ed49b0b681d3447104b49bac19d4dbc9 Mon Sep 17 00:00:00 2001 From: James E Keenan \jkeenan@​cpan\.org Date: Sat\, 2 Mar 2013 13:02:29 -0500 Subject: [PATCH] Add README for Porting directory.
Includes work by Matthew Ryder and Arthur Goldstein at New York Perl Hackathon.
For: RT #116477
Porting/README.pod | 366 ++++++++++++++++++++++++++++++++++++++++++++++++++++ Porting/pod_lib.pl | 35 +++++- 2 files changed\, 399 insertions(+)\, 2 deletions(-) create mode 100644 Porting/README.pod
On Sat\, Mar 02\, 2013 at 12:31:47PM -0800\, James E Keenan via RT wrote:
The patch is the work of Matthew Ryder\, Arthur Goldstein and myself at New York Perl Hackathon. Our objective was to create a first draft\, not a perfect document. We ask that you review this patch with respect to the following priorities:
(1) Rule out obvious errors.
(2) Improvements in descriptions of files in Porting/.
(3) Stylistic/grammatical/typographical corrections.
When you read this document\, you will no doubt spot references to Perl core functionality that is long dead. We ask that you not use *this RT ticket* discuss whether or not we should retain certain of these Porting files; open up separate tickets for that.
We'll have to decide whether this README is sufficiently useful to be included (with edits) in Perl 5.18 this spring.
A few notes:
Some headings are missing the F\<> markup:
+ +=head2 check-cpan-polution +
+=head2 pumpkin.pod
There's a missing newline before one heading:
+This file is built by F\
. This file contains a description of all +the shell variables whose value is determined by the Configure script. +=head2 F\<how_to_write_a_perldelta.pod> + +This file contains a specification as to how to write a perldelta pod.
The notes on pod_lib.pl are a little confusing:
+=head2 F\<pod_lib.pl> + +Make it clearer when we haven't run to completion\, as we can be quite noisy +when things are working ok write_or_die\,pods_to_install does not seem to be +called within in this file. However pods_to_install does call a lot of +libraries inside this file.
The note for config_h.pl is missing a comma or a period (or has some text to be edited out.)
There is no such file as cmpVersion (presumably it should be cmpVERSION.pl):
+=head2 F\
Typo:
+=head2 F\<leakfinder.pl> + +This script executes every line in every file in the build directy and its
The headings are vaguely in alphabetical order\, but there are several exceptions.
corelist-diff\, corelist.pl aren't documented.
There is text describing expand-macro.pl and how_to_write_a_perldelta.pod but no headings.
More generally\, some documentation on when some of the scripts are or should be used would be useful\, eg:
- config_h.pl - used when importing changes from metaconfig (it's possible the text is trying to say that\, but an edit seems to have left behind a text fragment)
- checkAUTHORS.pl - used by porting/authors.t to ensure the authors list is up to date
- cmpVERSION.pl - used by porting/cmp_version.t to ensure changed modules have had their versions updated
but it's valuable without this.
Tony
On Sun Mar 03 15:04:48 2013\, tonyc wrote:
On Sat\, Mar 02\, 2013 at 12:31:47PM -0800\, James E Keenan via RT wrote:
The patch is the work of Matthew Ryder\, Arthur Goldstein and myself at New York Perl Hackathon. Our objective was to create a first draft\, not a perfect document. We ask that you review this patch with respect to the following priorities:
(1) Rule out obvious errors.
(2) Improvements in descriptions of files in Porting/.
(3) Stylistic/grammatical/typographical corrections.
When you read this document\, you will no doubt spot references to Perl core functionality that is long dead. We ask that you not use *this RT ticket* discuss whether or not we should retain certain of these Porting files; open up separate tickets for that.
We'll have to decide whether this README is sufficiently useful to be included (with edits) in Perl 5.18 this spring.
A few notes:
Some headings are missing the F\<> markup:
+ +=head2 check-cpan-polution +
+=head2 pumpkin.pod
[snip]
Thanks for the feedback. Second version attached. Since this is a new file\, I'll just keep posting the latest draft of the entire file until there's one we like enough to commit to blead.
Thank you very much. Jim Keenan
On Sun\, Mar 03\, 2013 at 04:31:41PM -0800\, James E Keenan via RT wrote:
Thanks for the feedback. Second version attached. Since this is a new file\, I'll just keep posting the latest draft of the entire file until there's one we like enough to commit to blead.
All the errors I mentioned have been fixed except for:
- the cmpVersion heading was changed to cmpVersion.pl but it's actually cmpVERSION.pl
=head2 F\<make_dot_patch.pl>
This script reads sha1 from C\<@ARGV> and then prints GitUtils::gen_dot_patch to STDOUT to determine which primary branch sha1 can be found on.
Perhaps:
Generate a C\<.patch> file to STDOUT for the specified commit id.
=head2 F\<perl5180delta.pod>
This is a template for a new perldelta file 5.18 description of what the file does.
This isn't a template\, but is a work-in-progress perldelta for 5.18.0. It will probably go away (or be renamed into pod/) once 5.18.0 is released.
=head2 F\<perldelta_template.pod>
This seems to be the same file when diffed with the perl5180delta.pod except that the previous is focused on 5.18.1.
This one is the template. Neither file mentions 5.18.1.
=head2 F\<rt_list_patches>
List patches in rt.
I don't think this should be indented.
Tony
On Sun Mar 03 17:18:41 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 04:31:41PM -0800\, James E Keenan via RT wrote:
Thanks for the feedback. Second version attached.
version 3 attached.
On Sun\, Mar 03\, 2013 at 06:20:01PM -0800\, James E Keenan via RT wrote:
On Sun Mar 03 17:18:41 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 04:31:41PM -0800\, James E Keenan via RT wrote:
Thanks for the feedback. Second version attached.
version 3 attached.
I'm happy.
Tony
On Mon Mar 04 14:14:24 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 06:20:01PM -0800\, James E Keenan via RT wrote:
On Sun Mar 03 17:18:41 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 04:31:41PM -0800\, James E Keenan via RT wrote:
Thanks for the feedback. Second version attached.
version 3 attached.
I'm happy.
Tony
Anyone else want to chime in? Otherwise\, I'll commit this to blead in about three days.
Thank you very much. Jim Keenan
On Mon\, Mar 4\, 2013 at 6:25 PM\, James E Keenan via RT \perlbug\-followup@​perl\.org wrote:
On Mon Mar 04 14:14:24 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 06:20:01PM -0800\, James E Keenan via RT wrote:
On Sun Mar 03 17:18:41 2013\, tonyc wrote:
On Sun\, Mar 03\, 2013 at 04:31:41PM -0800\, James E Keenan via RT wrote:
Thanks for the feedback. Second version attached.
version 3 attached.
I'm happy.
Tony
Anyone else want to chime in? Otherwise\, I'll commit this to blead in about three days.
Thank you very much. Jim Keenan
=head2 F\<curliff.pl>
Convert certain files in the Perl distribution that need to be in CR-LF format to CR-LF\, or back to LF format (with the -r option). The CR-LF format is NOT to be used for checking in files to the Perforce repository\, but it IS to be used when making Perl snapshots or releases.
Perl is now maintained using git not Perforce.
Slightly unrelated: That file can probably go ( git handles this )
I don't think this should be in there:
=head2 F\<perl5180delta.pod>
F\
* James E Keenan via RT \perlbug\-followup@​perl\.org [2013-03-04T19:25:55]
Anyone else want to chime in? Otherwise\, I'll commit this to blead in about three days.
I do want to give it a look-over and maybe futz with it\, but I don't see any reason that this has to happen before its current form is committed. I'd hate to hold things up.
Do we have a test (for t/Porting) that all files in ./Porting are in the index?
-- rjbs
On 3/4/13 9:07 PM\, Brad Gilbert wrote:
On Mon\, Mar 4\, 2013 at 6:25 PM\, James E Keenan via RT
=head2 F\<curliff.pl>
Convert certain files in the Perl distribution that need to be in CR-LF format to CR-LF\, or back to LF format (with the -r option). The CR-LF format is NOT to be used for checking in files to the Perforce repository\, but it IS to be used when making Perl snapshots or releases.
Perl is now maintained using git not Perforce.
Slightly unrelated: That file can probably go ( git handles this )
Please open an RT for the removal of that file.
I don't think this should be in there:
=head2 F\<perl5180delta.pod>
F\
for Perl 5.18.0: a work-in-progress file.
Do you mean: It should not be in Porting/README.pod ... or it shouldn't be in the directory at all?
Thank you very much. jimk
On Mon\, Mar 04\, 2013 at 10:46:06PM -0500\, James E Keenan wrote:
On 3/4/13 9:07 PM\, Brad Gilbert wrote:
I don't think this should be in there:
=head2 F\<perl5180delta.pod>
F\
for Perl 5.18.0: a work-in-progress file. Do you mean: It should not be in Porting/README.pod ... or it shouldn't be in the directory at all?
I don't think it belongs in the README.pod.
Tony
On Mon Mar 04 19:30:27 2013\, rjbs wrote:
* James E Keenan via RT \perlbug\-followup@​perl\.org [2013-03- 04T19:25:55]
Anyone else want to chime in? Otherwise\, I'll commit this to blead in about three days.
I do want to give it a look-over and maybe futz with it\, but I don't see any reason that this has to happen before its current form is committed. I'd hate to hold things up.
In 7ad311ab4c1db82cc8475436be976d6d564cb024\, I committed something which was equivalent to my 'v3' attachment\, except that I deleted the paragraph about the perl 5.18.0 perldelta.
Are there still inaccuracies in this README? Undoubtedly. For example\, I did not correct two references to the Perforce repository. But now the document is available for all to see. Feel free to open RTs for corrections or -- better still -- for removal from the Porting directory of files which are outmoded.
Do we have a test (for t/Porting) that all files in ./Porting are in the index?
No\, I didn't want to hold up submission of this patch for that purpose. Any test would have to take into account items like the perl 5.18 delta mentioned above\, which are found in the directory but not in the README. That's a task for someone else\, in a new RT.
Thanks again to Matt and Arthur for their work on this at the NY Perl Hackathon.
Closing ticket.
Thank you very much. Jim Keenan
@jkeenan - Status changed from 'open' to 'resolved'
Migrated from rt.perl.org#116477 (status was 'resolved')
Searchable as RT116477$