search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.97k stars 556 forks source link

[PATCH] Pedanticize podcheck.t #13070

Closed p5pRT closed 11 years ago

p5pRT commented 11 years ago

Migrated from rt.perl.org#118673 (status was 'resolved')

Searchable as RT118673$

p5pRT commented 11 years ago

From gottreu@gmail.com

This is a bug report for perl from gottreu@​gmail.com\, generated with the help of perlbug 1.39 running under perl 5.19.2.

Half the patches are by Ricardo from his podcheck-again branch. These make the 3 checks that were removed or weakened by commit f26da014a698383ac348973050af3e754752e6ab into non-default checks only enabled by --pedantic or PERL_POD_PEDANTIC=1. When the known pod problems database is regenerated the pedantic checks are included as well.

Flags​:   category=core   severity=low

Site configuration information for perl 5.19.2​:

Configured by gottreu at Fri Jun 28 16​:55​:03 CDT 2013.

Summary of my perl5 (revision 5 version 19 subversion 2) configuration​:   Commit id​: 00bf0a7d448a5ea168c0f9b0218ac9786826a42b   Platform​:   osname=linux\, osvers=3.2.0-4-amd64\, archname=x86_64-linux   uname='linux frylock 3.2.0-4-amd64 #1 smp debian 3.2.39-2 x86_64 gnulinux '   config_args='-des -Dusedevel'   hint=recommended\, useposix=true\, d_sigaction=define   useithreads=undef\, usemultiplicity=undef   useperlio=define\, d_sfio=undef\, uselargefiles=define\, usesocks=undef   use64bitint=define\, use64bitall=define\, uselongdouble=undef   usemymalloc=n\, bincompat5005=undef   Compiler​:   cc='cc'\, ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'\,   optimize='-O2'\,   cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'   ccversion=''\, gccversion='4.7.2'\, gccosandvers=''   intsize=4\, longsize=8\, ptrsize=8\, doublesize=8\, byteorder=12345678   d_longlong=define\, longlongsize=8\, d_longdbl=define\, longdblsize=16   ivtype='long'\, ivsize=8\, nvtype='double'\, nvsize=8\, Off_t='off_t'\, lseeksize=8   alignbytes=8\, prototype=define   Linker and Libraries​:   ld='cc'\, ldflags =' -fstack-protector -L/usr/local/lib'   libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib   libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat   perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc   libc=\, so=so\, useshrplib=false\, libperl=libperl.a   gnulibc_version='2.13'   Dynamic Linking​:   dlsrc=dl_dlopen.xs\, dlext=so\, d_dlsymun=undef\, ccdlflags='-Wl\,-E'   cccdlflags='-fPIC'\, lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Locally applied patches​:

@​INC for perl 5.19.2​:   lib   /usr/local/lib/perl5/site_perl/5.19.2/x86_64-linux   /usr/local/lib/perl5/site_perl/5.19.2   /usr/local/lib/perl5/5.19.2/x86_64-linux   /usr/local/lib/perl5/5.19.2   /usr/local/lib/perl5/site_perl   .

Environment for perl 5.19.2​:   HOME=/home/gottreu   LANG=en_US.UTF-8   LANGUAGE (unset)   LD_LIBRARY_PATH (unset)   LOGDIR (unset)

PATH=/home/gottreu/perl5/perlbrew/bin​:/home/gottreu/perl5/perlbrew/perls/perl-5.19.1/bin​:/home/gottreu/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/games​:/usr/games   PERLBREW_BASHRC_VERSION=0.42   PERLBREW_HOME=/home/gottreu/.perlbrew   PERLBREW_MANPATH=/home/gottreu/perl5/perlbrew/perls/perl-5.19.1/man

PERLBREW_PATH=/home/gottreu/perl5/perlbrew/bin​:/home/gottreu/perl5/perlbrew/perls/perl-5.19.1/bin   PERLBREW_PERL=perl-5.19.1   PERLBREW_ROOT=/home/gottreu/perl5/perlbrew   PERLBREW_VERSION=0.42   PERL_BADLANG (unset)   SHELL=/bin/bash

p5pRT commented 11 years ago

From gottreu@gmail.com

0001-Revert-Make-t-podcheck.t-less-sensitive.patch ```diff From 55118cd8ca93a66b78de8b1a10b8ff3a10641637 Mon Sep 17 00:00:00 2001 From: Ricardo Signes Date: Tue, 18 Jun 2013 19:27:11 -0400 Subject: [PATCH 1/4] Revert "Make t/podcheck.t less sensitive" This reverts commit f26da014a698383ac348973050af3e754752e6ab. Conflicts: t/porting/known_pod_issues.dat --- t/porting/known_pod_issues.dat | 167 +++++++++++++++++++++++++++++++++++++--- t/porting/podcheck.t | 94 +++++++++++++++++++++- 2 files changed, 247 insertions(+), 14 deletions(-) diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat index d505ef4..8578cee 100644 --- a/t/porting/known_pod_issues.dat +++ b/t/porting/known_pod_issues.dat @@ -189,15 +189,158 @@ Win32::Locale YAML YAML::Syck YAML::Tiny -pod/perlbook.pod Verbatim line length including indents exceeds 100 by 1 -pod/perldebguts.pod Verbatim line length including indents exceeds 100 by 2 -pod/perldtrace.pod Verbatim line length including indents exceeds 100 by 4 -pod/perlebcdic.pod Verbatim line length including indents exceeds 100 by 10 -pod/perlmacosx.pod Verbatim line length including indents exceeds 100 by 3 -pod/perlos2.pod Verbatim line length including indents exceeds 100 by 4 -pod/perlperf.pod Verbatim line length including indents exceeds 100 by 32 -pod/perlrun.pod Verbatim line length including indents exceeds 100 by 1 -pod/perltru64.pod Verbatim line length including indents exceeds 100 by 1 -pod/perlwin32.pod Verbatim line length including indents exceeds 100 by 6 -porting/release_managers_guide.pod Verbatim line length including indents exceeds 100 by 1 -lib/benchmark.pm Verbatim line length including indents exceeds 100 by 2 +dist/cwd/lib/file/spec/vms.pm Verbatim line length including indents exceeds 79 by 1 +dist/cwd/lib/file/spec/win32.pm Verbatim line length including indents exceeds 79 by 1 +dist/data-dumper/dumper.pm ? Should you be using L<...> instead of 1 +dist/extutils-parsexs/lib/perlxs.pod Verbatim line length including indents exceeds 79 by 1 +dist/extutils-parsexs/lib/perlxstut.pod Verbatim line length including indents exceeds 79 by 10 +dist/filter-simple/lib/filter/simple.pm Verbatim paragraph in NAME section 1 +dist/locale-maketext/lib/locale/maketext/tpj13.pod No items in =over / =back list 3 +dist/math-bigint/lib/math/bigint.pm Verbatim line length including indents exceeds 79 by 77 +dist/math-bigint/lib/math/bigint/calcemu.pm empty section in previous paragraph 3 +dist/math-bigrat/lib/math/bigrat.pm Verbatim line length including indents exceeds 79 by 7 +dist/math-bigrat/lib/math/bigrat.pm unresolved internal link 1 +dist/module-corelist/blib/script/corelist Verbatim line length including indents exceeds 79 by 1 +dist/module-corelist/lib/module/corelist.pod Verbatim line length including indents exceeds 79 by 4 +dist/net-ping/lib/net/ping.pm Verbatim line length including indents exceeds 79 by 2 +dist/safe/safe.pm Verbatim line length including indents exceeds 79 by 1 +dist/safe/safe.pm empty section in previous paragraph 1 +dist/selfloader/lib/selfloader.pm Verbatim line length including indents exceeds 79 by 13 +dist/storable/storable.pm Verbatim line length including indents exceeds 79 by 4 +dist/thread-queue/lib/thread/queue.pm Verbatim line length including indents exceeds 79 by 4 +dist/threads/lib/threads.pm Verbatim line length including indents exceeds 79 by 3 +dist/tie-file/lib/tie/file.pm Verbatim line length including indents exceeds 79 by 3 +ext/b/b/concise.pm Verbatim line length including indents exceeds 79 by 1 +ext/devel-peek/peek.pm ? Should you be using L<...> instead of 2 +ext/devel-peek/peek.pm Verbatim line length including indents exceeds 79 by 2 +ext/dynaloader/dynaloader.pm Verbatim line length including indents exceeds 79 by 1 +ext/file-glob/glob.pm Verbatim line length including indents exceeds 79 by 15 +ext/hash-util-fieldhash/lib/hash/util/fieldhash.pm Verbatim line length including indents exceeds 79 by 2 +ext/i18n-langinfo/langinfo.pm Verbatim line length including indents exceeds 79 by 1 +ext/pod-html/bin/pod2html Pod NAME already used 1 +ext/pod-html/testdir/perlpodspec-copy.pod Verbatim line length including indents exceeds 79 by 8 +ext/pod-html/testdir/perlvar-copy.pod ? Should you be using L<...> instead of 3 +ext/pod-html/testdir/perlvar-copy.pod Verbatim line length including indents exceeds 79 by 6 +ext/posix/lib/posix.pod Verbatim line length including indents exceeds 79 by 13 +ext/vms-dclsym/dclsym.pm ? Should you be using L<...> instead of 1 +ext/vms-dclsym/dclsym.pm Verbatim line length including indents exceeds 79 by 1 +ext/vms-stdio/stdio.pm Verbatim line length including indents exceeds 79 by 1 +ext/xs-apitest/apitest.pm Verbatim line length including indents exceeds 79 by 1 +install ? Should you be using F<...> or maybe L<...> instead of 1 +installhtml Verbatim line length including indents exceeds 79 by 3 +os2/os2/os2-extattr/extattr.pm ? Should you be using F<...> or maybe L<...> instead of 1 +os2/os2/os2-process/process.pm Verbatim line length including indents exceeds 79 by 27 +os2/os2/os2-rexx/dll/dll.pm Verbatim line length including indents exceeds 79 by 2 +os2/os2/os2-rexx/rexx.pm Verbatim line length including indents exceeds 79 by 1 +pod/perl.pod Verbatim line length including indents exceeds 79 by 8 +pod/perlaix.pod Verbatim line length including indents exceeds 79 by 11 +pod/perlapi.pod ? Should you be using L<...> instead of 76 +pod/perlapi.pod Verbatim line length including indents exceeds 79 by 6 +pod/perlapi.pod unresolved internal link 3 +pod/perlapio.pod Verbatim line length including indents exceeds 79 by 5 +pod/perlbook.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlcall.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlce.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlcygwin.pod Verbatim line length including indents exceeds 79 by 24 +pod/perldbmfilter.pod Verbatim line length including indents exceeds 79 by 1 +pod/perldebguts.pod Verbatim line length including indents exceeds 79 by 34 +pod/perldebtut.pod Verbatim line length including indents exceeds 79 by 22 +pod/perldebug.pod Verbatim line length including indents exceeds 79 by 3 +pod/perldiag.pod =item type mismatch 1 +pod/perldiag.pod Verbatim line length including indents exceeds 79 by 1 +pod/perldsc.pod Verbatim line length including indents exceeds 79 by 4 +pod/perldtrace.pod Verbatim line length including indents exceeds 79 by 26 +pod/perlebcdic.pod Verbatim line length including indents exceeds 79 by 13 +pod/perlembed.pod Verbatim line length including indents exceeds 79 by 27 +pod/perlfunc.pod There is more than one target 1 +pod/perlgit.pod Verbatim line length including indents exceeds 79 by 12 +pod/perlgpl.pod Verbatim line length including indents exceeds 79 by 50 +pod/perlguts.pod ? Should you be using F<...> or maybe L<...> instead of 2 +pod/perlguts.pod ? Should you be using L<...> instead of 1 +pod/perlhack.pod ? Should you be using L<...> instead of 1 +pod/perlhack.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlhist.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlhpux.pod Verbatim line length including indents exceeds 79 by 5 +pod/perlhurd.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlintern.pod ? Should you be using L<...> instead of 5 +pod/perlinterp.pod ? Should you be using L<...> instead of 1 +pod/perliol.pod Verbatim line length including indents exceeds 79 by 8 +pod/perlipc.pod Verbatim line length including indents exceeds 79 by 19 +pod/perlirix.pod Verbatim line length including indents exceeds 79 by 4 +pod/perllol.pod Verbatim line length including indents exceeds 79 by 4 +pod/perlmacosx.pod Verbatim line length including indents exceeds 79 by 4 +pod/perlmod.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlmodlib.pod Verbatim line length including indents exceeds 79 by 3 +pod/perlmodstyle.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlmroapi.pod ? Should you be using L<...> instead of 1 +pod/perlnetware.pod Verbatim line length including indents exceeds 79 by 4 +pod/perlnewmod.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlootut.pod ? Should you be using F<...> or maybe L<...> instead of 1 +pod/perlos2.pod ? Should you be using L<...> instead of 2 +pod/perlos2.pod Verbatim line length including indents exceeds 79 by 22 +pod/perlos390.pod Verbatim line length including indents exceeds 79 by 11 +pod/perlpacktut.pod Verbatim line length including indents exceeds 79 by 6 +pod/perlperf.pod Verbatim line length including indents exceeds 79 by 154 +pod/perlpodspec.pod Verbatim line length including indents exceeds 79 by 9 +pod/perlpodstyle.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlref.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlrequick.pod Verbatim line length including indents exceeds 79 by 3 +pod/perlretut.pod Verbatim line length including indents exceeds 79 by 13 +pod/perlrun.pod Verbatim line length including indents exceeds 79 by 3 +pod/perlsolaris.pod Verbatim line length including indents exceeds 79 by 14 +pod/perlsource.pod ? Should you be using F<...> or maybe L<...> instead of 1 +pod/perlsub.pod ? Should you be using F<...> or maybe L<...> instead of 3 +pod/perlsub.pod Verbatim line length including indents exceeds 79 by 4 +pod/perlsymbian.pod Verbatim line length including indents exceeds 79 by 20 +pod/perlthrtut.pod Verbatim line length including indents exceeds 79 by 5 +pod/perltie.pod Verbatim line length including indents exceeds 79 by 13 +pod/perltrap.pod ? Should you be using F<...> or maybe L<...> instead of 1 +pod/perltru64.pod ? Should you be using F<...> or maybe L<...> instead of 1 +pod/perltru64.pod Verbatim line length including indents exceeds 79 by 4 +pod/perlunifaq.pod empty section in previous paragraph 1 +pod/perluniprops.pod =item type mismatch 6 +pod/perlvms.pod ? Should you be using F<...> or maybe L<...> instead of 1 +pod/perlvms.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlwin32.pod Verbatim line length including indents exceeds 79 by 12 +porting/epigraphs.pod Verbatim line length including indents exceeds 79 by 3 +porting/expand-macro.pl Verbatim line length including indents exceeds 79 by 2 +porting/how_to_write_a_perldelta.pod There is no NAME 1 +porting/how_to_write_a_perldelta.pod Verbatim line length including indents exceeds 79 by 3 +porting/pumpkin.pod Verbatim line length including indents exceeds 79 by 9 +porting/release_managers_guide.pod Verbatim line length including indents exceeds 79 by 7 +porting/release_schedule.pod There is no NAME 1 +porting/todo.pod Verbatim line length including indents exceeds 79 by 7 +symbian/perlutil.pod Verbatim line length including indents exceeds 79 by 4 +utils/c2ph Verbatim line length including indents exceeds 79 by 44 +vms/ext/filespec.pm Verbatim line length including indents exceeds 79 by 1 +x2p/a2p.pod empty section in previous paragraph 2 +lib/benchmark.pm Verbatim line length including indents exceeds 79 by 4 +lib/class/struct.pm Verbatim line length including indents exceeds 79 by 7 +lib/config.pod ? Should you be using L<...> instead of -1 +lib/config.pod nested commands F<...F<...>...> 3 +lib/db.pm Verbatim line length including indents exceeds 79 by 2 +lib/dbm_filter.pm Verbatim line length including indents exceeds 79 by 1 +lib/dbm_filter/compress.pm Verbatim line length including indents exceeds 79 by 1 +lib/dbm_filter/encode.pm Verbatim line length including indents exceeds 79 by 1 +lib/dbm_filter/int32.pm Verbatim line length including indents exceeds 79 by 1 +lib/dbm_filter/null.pm Verbatim line length including indents exceeds 79 by 1 +lib/dbm_filter/utf8.pm Verbatim line length including indents exceeds 79 by 1 +lib/deprecate.pm Verbatim line length including indents exceeds 79 by 2 +lib/english.pm Verbatim line length including indents exceeds 79 by 1 +lib/extutils/embed.pm Verbatim line length including indents exceeds 79 by 2 +lib/extutils/xssymset.pm Verbatim line length including indents exceeds 79 by 1 +lib/file/basename.pm Verbatim line length including indents exceeds 79 by 2 +lib/file/find.pm Verbatim line length including indents exceeds 79 by 1 +lib/getopt/std.pm Verbatim line length including indents exceeds 79 by 1 +lib/integer.pm Verbatim line length including indents exceeds 79 by 1 +lib/perl5db.pl ? Should you be using L<...> instead of 1 +lib/perl5db.pl Verbatim line length including indents exceeds 79 by 1 +lib/perlio.pm Verbatim line length including indents exceeds 79 by 2 +lib/pod/text/overstrike.pm Verbatim line length including indents exceeds 79 by 1 +lib/strict.pm Verbatim line length including indents exceeds 79 by 1 +lib/tie/array.pm Verbatim line length including indents exceeds 79 by 1 +lib/tie/hash.pm Verbatim line length including indents exceeds 79 by 3 +lib/tie/scalar.pm Verbatim line length including indents exceeds 79 by 1 +lib/version.pod Verbatim line length including indents exceeds 79 by 1 +lib/version/internals.pod Verbatim line length including indents exceeds 79 by 2 +lib/vmsish.pm Verbatim line length including indents exceeds 79 by 1 diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index 76944c6..4d09b5e 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -329,7 +329,7 @@ my $known_issues = File::Spec->catfile($data_dir, 'known_pod_issues.dat'); my $MANIFEST = File::Spec->catfile(File::Spec->updir($original_dir), 'MANIFEST'); my $copy_fh; -my $MAX_LINE_LENGTH = 100; # 79 columns +my $MAX_LINE_LENGTH = 79; # 79 columns my $INDENT = 7; # default nroff indent # Our warning messages. Better not have [('"] in them, as those are used as @@ -337,6 +337,8 @@ my $INDENT = 7; # default nroff indent my $line_length = "Verbatim line length including indents exceeds $MAX_LINE_LENGTH by"; my $broken_link = "Apparent broken link"; my $broken_internal_link = "Apparent internal link is missing its forward slash"; +my $see_not_linked = "? Should you be using L<...> instead of"; +my $C_with_slash = "? Should you be using F<...> or maybe L<...> instead of"; my $multiple_targets = "There is more than one target"; my $duplicate_name = "Pod NAME already used"; my $need_encoding = "Should have =encoding statement because have non-ASCII"; @@ -812,7 +814,95 @@ package My::Pod::Checker { # Extend Pod::Checker } } } - + $paragraph = join " ", split /^/, $paragraph; + + # Matches something that looks like a file name, but is enclosed in + # C<...> + my $C_path_re = qr{ \b ( C< + # exclude various things that have slashes + # in them but aren't paths + (?! + (?: (?: s | qr | m) / ) # regexes + | \d+/\d+> # probable fractions + | OS/2> + | Perl/Tk> + | origin/blead> + | origin/maint + | - # File names don't begin with "-" + ) + [-\w]+ (?: / [-\w]+ )+ (?: \. \w+ )? > ) + }x; + + # If looks like a reference to other documentation by containing the + # word 'See' and then a likely pod directive, warn. + while ($paragraph =~ m{ + ( (?: \w+ \s+ )* ) # The phrase before, if any + \b [Ss]ee \s+ + ( ( [^L] ) + < + ( [^<]*? ) # The not < excludes nested C + ) + ( \s+ (?: under | in ) \s+ L< )? + }xg) { + my $prefix = $1 // ""; + my $construct = $2; # The whole thing, like C<...> + my $type = $3; + my $interior = $4; + my $trailing = $5; # After the whole thing ending in "L<" + + # If the full phrase is something like, "you might see C<", or + # similar, it really isn't a reference to a link. The ones I saw + # all had the word "you" in them; and the "you" wasn't the + # beginning of a sentence. + if ($prefix !~ / \b you \b /x) { + + # Now, find what the module or man page name within the + # construct would be if it actually has L<> syntax. If it + # doesn't have that syntax, will set the module to the entire + # interior. + $interior =~ m/ ^ + (?: [^|]+ \| )? # Optional arbitrary text ending + # in "|" + ( .+? ) # module, etc. name + (?: \/ .+ )? # target within module + $ + /xs; + my $module = $1; + if (! defined $trailing # not referring to something in another + # section + && $interior !~ /$non_pods/ + + # C<> that look like files have their own message below, so + # exclude them + && $construct !~ /$C_path_re/g + + # There can't be spaces (I think) in module names or man + # pages + && $module !~ / \s /x + + # F<> that end in eg \.pl are almost certainly ok, as are + # those that look like a path with multiple "/" chars + && ($type ne "F" + || (! -e $interior + && $interior !~ /\.\w+$/ + && $interior !~ /\/.+\//) + ) + ) { + $self->poderror({ -line => $line, -file => $file, + -msg => $see_not_linked, + parameter => $construct + }); + } + } + } + while ($paragraph =~ m/$C_path_re/g) { + my $construct = $1; + $self->poderror({ -line => $line, -file => $file, + -msg => $C_with_slash, + parameter => $construct + }); + } return; } -- 1.7.10.4 ```
p5pRT commented 11 years ago

From gottreu@gmail.com

0002-do-not-worry-about-long-verbatim-lines-w-o-env-var.patch ```diff From 5cc148626e43fdf5258de1b26ce5aed69156e225 Mon Sep 17 00:00:00 2001 From: Ricardo Signes Date: Tue, 18 Jun 2013 19:45:56 -0400 Subject: [PATCH 2/4] do not worry about long verbatim lines w/o env var To run these tests, set PERL_POD_PEDANTIC in the environment. This needs further testing, at least, to ensure that it behaves correctly when regenerating the known problem files. --- t/porting/podcheck.t | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index 4d09b5e..8fded27 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -784,14 +784,17 @@ package My::Pod::Checker { # Extend Pod::Checker } $lines[$i] =~ s/\s+$//; my $indent = $self->get_current_indent; - my $exceeds = length(Text::Tabs::expand($lines[$i])) - + $indent - $MAX_LINE_LENGTH; - next unless $exceeds > 0; - my ($file, $line) = $pod_para->file_line; - $self->poderror({ -line => $line + $i, -file => $file, - -msg => $line_length, - parameter => "+$exceeds (including " . ($indent - $INDENT) . " from =over's)", - }); + + if ($ENV{PERL_POD_PEDANTIC}) { + my $exceeds = length(Text::Tabs::expand($lines[$i])) + + $indent - $MAX_LINE_LENGTH; + next unless $exceeds > 0; + my ($file, $line) = $pod_para->file_line; + $self->poderror({ -line => $line + $i, -file => $file, + -msg => $line_length, + parameter => "+$exceeds (including " . ($indent - $INDENT) . " from =over's)", + }); + } } } @@ -1841,6 +1844,10 @@ foreach my $filename (@files) { next if $problems{$filename}{$message}; next if ! $known_problems{$canonical}{$message}; next if $known_problems{$canonical}{$message} < 0; # Preserve negs + + next if index($message, $line_length) == 0 + and ! $ENV{PERL_POD_PENDANTIC}; + my $diagnostic = output_thanks($filename, $known_problems{$canonical}{$message}, 0, $message); push @diagnostics, $diagnostic if $diagnostic; $thankful_diagnostics++ if $diagnostic; -- 1.7.10.4 ```
p5pRT commented 11 years ago

From gottreu@gmail.com

0003-Run-the-pedantic-checks-when-regenerating-the-databa.patch ```diff From 394a51a3dbf561565c2347aed0b3f963a7b722b0 Mon Sep 17 00:00:00 2001 From: Brian Gottreu Date: Fri, 28 Jun 2013 18:07:49 -0500 Subject: [PATCH 3/4] Run the pedantic checks when regenerating the database Make the two checks of possible poor uses of C<> pedantic checks. Allow --pedantic to turn on those tests in addition to the environmnt variable. --- t/porting/podcheck.t | 107 +++++++++++++++++++++++++++++++------------------- 1 file changed, 67 insertions(+), 40 deletions(-) diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index 8fded27..fbb07e3 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -33,7 +33,8 @@ podcheck.t - Look for possible problems in the Perl pods cd t ./perl -I../lib porting/podcheck.t [--show_all] [--cpan] [--deltas] - [--counts] [ FILE ...] + [--counts] [--pedantic] [FILE ...] + ./perl -I../lib porting/podcheck.t --add_link MODULE ... ./perl -I../lib porting/podcheck.t --regen @@ -49,7 +50,7 @@ fail a pod only if the number of such problems differs from that given in the database. It also suppresses the C<(section) deprecated> message from Pod::Checker, since specifying the man page section number is quite proper to do. -The additional checks it makes are: +The additional checks it always makes are: =over @@ -66,7 +67,7 @@ The way that the CE> pod command works (for links outside the pod) is to actually create a link to C with an embedded query for the desired pod or man page. That means that links outside the distribution are valid. podcheck.t doesn't verify the validity of such links, but instead -keeps a data base of those known to be valid. This means that if a link to a +keeps a database of those known to be valid. This means that if a link to a target not on the list is created, the target needs to be added to the data base. This is accomplished via the L<--add_link|/--add_link MODULE ...> option to podcheck.t, described below. @@ -77,6 +78,24 @@ If a link is broken, but there is an existing internal target of the same name, it is likely that the internal target was meant, and the C<"/"> is missing from the CE> pod command. +=item Missing or duplicate NAME or missing NAME short description + +A pod can't be linked to unless it has a unique name. +And a NAME should have a dash and short description after it. + +=item =encoding statement issues + +This indicates if an C<=encoding> statement should be present, or moved to the +front of the pod. + +=back + +If the C environment variable is set or the C<--pedantic> +command line argument is provided then a few more checks are made. +The pedantic checks are: + +=over + =item Verbatim paragraphs that wrap in an 80 (including 1 spare) column window It's annoying to have lines wrap when displaying pod documentation in a @@ -89,16 +108,6 @@ order to fit. Often, the easiest thing to do to gain space for these is to lower the indent to just one space. -=item Missing or duplicate NAME or missing NAME short description - -A pod can't be linked to unless it has a unique name. -And a NAME should have a dash and short description after it. - -=item =encoding statement issues - -This indicates if an C<=encoding> statement should be present, or moved to the -front of the pod. - =item Items that perhaps should be links There are mentions of apparent files in the pods that perhaps should be links @@ -140,7 +149,7 @@ cause the corresponding error to always be suppressed no matter how many there actually are. Another problem is that there is currently no check that modules listed as -valid in the data base +valid in the database actually are. Thus any errors introduced there will remain there. =head2 Specially handled pods @@ -189,24 +198,24 @@ exist, and to silence any messages that links to them are broken. podcheck.t checks that links within the Perl core distribution are valid, but it doesn't check links to man pages or external modules. When it finds -a broken link, it checks its data base of external modules and man pages, +a broken link, it checks its database of external modules and man pages, and only if not found there does it raise a message. This option just adds the list of modules and man page references that follow it on the command line -to that data base. +to that database. For example, cd t ./perl -I../lib porting/podcheck.t --add_link Unicode::Casing -causes the external module "Unicode::Casing" to be added to the data base, so +causes the external module "Unicode::Casing" to be added to the database, so CUnicode::CasingE> will be considered valid. =item --regen -Regenerate the data base used by podcheck.t to include all the existing +Regenerate the database used by podcheck.t to include all the existing potential problems. Future runs of the program will not then flag any of -these. +these. Setting this option also sets C<--pedantic>. =item --cpan @@ -233,7 +242,14 @@ any particular FILES to operate on automatically selects this option. =item --counts Instead of testing, this just dumps the counts of the occurrences of the -various types of potential problems in the data base. +various types of potential problems in the database. + +=item --pedantic + +There are three potential problems that are not checked for by default. +This options enables them. The environment variable C +can be set to 1 to enable this option also. +This option is set when C<--regen> is used. =back @@ -334,17 +350,18 @@ my $INDENT = 7; # default nroff indent # Our warning messages. Better not have [('"] in them, as those are used as # delimiters for variable parts of the messages by poderror. -my $line_length = "Verbatim line length including indents exceeds $MAX_LINE_LENGTH by"; my $broken_link = "Apparent broken link"; my $broken_internal_link = "Apparent internal link is missing its forward slash"; -my $see_not_linked = "? Should you be using L<...> instead of"; -my $C_with_slash = "? Should you be using F<...> or maybe L<...> instead of"; my $multiple_targets = "There is more than one target"; my $duplicate_name = "Pod NAME already used"; my $need_encoding = "Should have =encoding statement because have non-ASCII"; my $encoding_first = "=encoding must be first command (if present)"; my $no_name = "There is no NAME"; my $missing_name_description = "The NAME should have a dash and short description after it"; +# the pedantic warnings messages +my $line_length = "Verbatim line length including indents exceeds $MAX_LINE_LENGTH by"; +my $C_not_linked = "? Should you be using L<...> instead of"; +my $C_with_slash = "? Should you be using F<...> or maybe L<...> instead of"; # objects, tests, etc can't be pods, so don't look for them. Also skip # files output by the patch program. Could also ignore most of .gitignore @@ -517,6 +534,7 @@ my $show_counts = 0; my $regen = 0; my $add_link = 0; my $show_all = 0; +my $pedantic = 0; my $do_upstream_cpan = 0; # Assume that are to skip anything in /cpan my $do_deltas = 0; # And stable perldeltas @@ -527,6 +545,7 @@ while (@ARGV && substr($ARGV[0], 0, 1) eq '-') { $arg =~ s/^--/-/; # Treat '--' the same as a single '-' if ($arg eq '-regen') { $regen = 1; + $pedantic = 1; } elsif ($arg eq '-add_link') { $add_link = 1; @@ -543,22 +562,27 @@ while (@ARGV && substr($ARGV[0], 0, 1) eq '-') { elsif ($arg eq '-counts') { $show_counts = 1; } + elsif ($arg eq '-pedantic') { + $pedantic = 1; + } else { die < Add the MODULE and man page references to the data base + --add_link -> Add the MODULE and man page references to the database --regen -> Regenerate the data file for $0 --cpan -> Include files in the cpan subdirectory. --deltas -> Include stable perldeltas --show_all -> Show all known potential problems --counts -> Don't test, but give summary counts of the currently existing database + --pedantic -> Check for overly long lines in verbatim blocks EOF } } +$pedantic = 1 if exists $ENV{PERL_POD_PEDANTIC} and $ENV{PERL_POD_PEDANTIC}; my @files = @ARGV; my $cpan_or_deltas = $do_upstream_cpan || $do_deltas; @@ -785,15 +809,16 @@ package My::Pod::Checker { # Extend Pod::Checker $lines[$i] =~ s/\s+$//; my $indent = $self->get_current_indent; - if ($ENV{PERL_POD_PEDANTIC}) { - my $exceeds = length(Text::Tabs::expand($lines[$i])) - + $indent - $MAX_LINE_LENGTH; - next unless $exceeds > 0; - my ($file, $line) = $pod_para->file_line; - $self->poderror({ -line => $line + $i, -file => $file, - -msg => $line_length, - parameter => "+$exceeds (including " . ($indent - $INDENT) . " from =over's)", - }); + if ($pedantic) { # TODO: this check should be moved higher + # to avoid more unnecessary work + my $exceeds = length(Text::Tabs::expand($lines[$i])) + + $indent - $MAX_LINE_LENGTH; + next unless $exceeds > 0; + my ($file, $line) = $pod_para->file_line; + $self->poderror({ -line => $line + $i, -file => $file, + -msg => $line_length, + parameter => "+$exceeds (including " . ($indent - $INDENT) . " from =over's)", + }); } } } @@ -892,19 +917,21 @@ package My::Pod::Checker { # Extend Pod::Checker && $interior !~ /\/.+\//) ) ) { + # TODO: move the checking of $pedantic higher up $self->poderror({ -line => $line, -file => $file, - -msg => $see_not_linked, + -msg => $C_not_linked, parameter => $construct - }); + }) if $pedantic; } } } while ($paragraph =~ m/$C_path_re/g) { my $construct = $1; + # TODO: move the checking of $pedantic higher up $self->poderror({ -line => $line, -file => $file, -msg => $C_with_slash, parameter => $construct - }); + }) if $pedantic; } return; } @@ -1125,7 +1152,7 @@ END my @existing_issues; -while (<$data_fh>) { # Read the data base +while (<$data_fh>) { # Read the database chomp; next if /^\s*(?:#|$)/; # Skip comment and empty lines if (/\t/) { @@ -1845,8 +1872,8 @@ foreach my $filename (@files) { next if ! $known_problems{$canonical}{$message}; next if $known_problems{$canonical}{$message} < 0; # Preserve negs - next if index($message, $line_length) == 0 - and ! $ENV{PERL_POD_PENDANTIC}; + next if !$pedantic and $message =~ + /^(?:\Q$line_length\E|\Q$C_not_linked\E|\Q$C_with_slash\E)/; my $diagnostic = output_thanks($filename, $known_problems{$canonical}{$message}, 0, $message); push @diagnostics, $diagnostic if $diagnostic; @@ -1872,7 +1899,7 @@ foreach my $filename (@files) { } if (! $regen - && ! ok (keys %known_problems == 0, "The known problems data base includes no references to non-existent files")) + && ! ok (keys %known_problems == 0, "The known problems database includes no references to non-existent files")) { note("The following files were not found: " . join ", ", keys %known_problems); -- 1.7.10.4 ```
p5pRT commented 11 years ago

From gottreu@gmail.com

0004-regenerate-t-porting-known_pod_issues.dat.patch ```diff From 09d0ca509e331c43cec8b46524d452c39a191687 Mon Sep 17 00:00:00 2001 From: Brian Gottreu Date: Fri, 28 Jun 2013 18:43:41 -0500 Subject: [PATCH 4/4] regenerate t/porting/known_pod_issues.dat --- t/porting/known_pod_issues.dat | 88 +++++----------------------------------- 1 file changed, 10 insertions(+), 78 deletions(-) diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat index 8578cee..f725f58 100644 --- a/t/porting/known_pod_issues.dat +++ b/t/porting/known_pod_issues.dat @@ -61,8 +61,8 @@ fetch(1) File::chdir File::Copy::Recursive File::Findgrep -File::MMagic File::Map +File::MMagic File::ShareDir flock(3) fsync(3c) @@ -189,45 +189,25 @@ Win32::Locale YAML YAML::Syck YAML::Tiny -dist/cwd/lib/file/spec/vms.pm Verbatim line length including indents exceeds 79 by 1 -dist/cwd/lib/file/spec/win32.pm Verbatim line length including indents exceeds 79 by 1 dist/data-dumper/dumper.pm ? Should you be using L<...> instead of 1 -dist/extutils-parsexs/lib/perlxs.pod Verbatim line length including indents exceeds 79 by 1 -dist/extutils-parsexs/lib/perlxstut.pod Verbatim line length including indents exceeds 79 by 10 -dist/filter-simple/lib/filter/simple.pm Verbatim paragraph in NAME section 1 -dist/locale-maketext/lib/locale/maketext/tpj13.pod No items in =over / =back list 3 +dist/extutils-parsexs/lib/perlxstut.pod Verbatim line length including indents exceeds 79 by 9 dist/math-bigint/lib/math/bigint.pm Verbatim line length including indents exceeds 79 by 77 -dist/math-bigint/lib/math/bigint/calcemu.pm empty section in previous paragraph 3 dist/math-bigrat/lib/math/bigrat.pm Verbatim line length including indents exceeds 79 by 7 -dist/math-bigrat/lib/math/bigrat.pm unresolved internal link 1 -dist/module-corelist/blib/script/corelist Verbatim line length including indents exceeds 79 by 1 dist/module-corelist/lib/module/corelist.pod Verbatim line length including indents exceeds 79 by 4 -dist/net-ping/lib/net/ping.pm Verbatim line length including indents exceeds 79 by 2 -dist/safe/safe.pm Verbatim line length including indents exceeds 79 by 1 -dist/safe/safe.pm empty section in previous paragraph 1 +dist/module-corelist/lib/module/corelist/utils.pm Verbatim line length including indents exceeds 79 by 2 dist/selfloader/lib/selfloader.pm Verbatim line length including indents exceeds 79 by 13 dist/storable/storable.pm Verbatim line length including indents exceeds 79 by 4 dist/thread-queue/lib/thread/queue.pm Verbatim line length including indents exceeds 79 by 4 dist/threads/lib/threads.pm Verbatim line length including indents exceeds 79 by 3 dist/tie-file/lib/tie/file.pm Verbatim line length including indents exceeds 79 by 3 -ext/b/b/concise.pm Verbatim line length including indents exceeds 79 by 1 ext/devel-peek/peek.pm ? Should you be using L<...> instead of 2 -ext/devel-peek/peek.pm Verbatim line length including indents exceeds 79 by 2 ext/dynaloader/dynaloader.pm Verbatim line length including indents exceeds 79 by 1 ext/file-glob/glob.pm Verbatim line length including indents exceeds 79 by 15 -ext/hash-util-fieldhash/lib/hash/util/fieldhash.pm Verbatim line length including indents exceeds 79 by 2 -ext/i18n-langinfo/langinfo.pm Verbatim line length including indents exceeds 79 by 1 -ext/pod-html/bin/pod2html Pod NAME already used 1 ext/pod-html/testdir/perlpodspec-copy.pod Verbatim line length including indents exceeds 79 by 8 ext/pod-html/testdir/perlvar-copy.pod ? Should you be using L<...> instead of 3 ext/pod-html/testdir/perlvar-copy.pod Verbatim line length including indents exceeds 79 by 6 -ext/posix/lib/posix.pod Verbatim line length including indents exceeds 79 by 13 ext/vms-dclsym/dclsym.pm ? Should you be using L<...> instead of 1 -ext/vms-dclsym/dclsym.pm Verbatim line length including indents exceeds 79 by 1 -ext/vms-stdio/stdio.pm Verbatim line length including indents exceeds 79 by 1 -ext/xs-apitest/apitest.pm Verbatim line length including indents exceeds 79 by 1 install ? Should you be using F<...> or maybe L<...> instead of 1 -installhtml Verbatim line length including indents exceeds 79 by 3 os2/os2/os2-extattr/extattr.pm ? Should you be using F<...> or maybe L<...> instead of 1 os2/os2/os2-process/process.pm Verbatim line length including indents exceeds 79 by 27 os2/os2/os2-rexx/dll/dll.pm Verbatim line length including indents exceeds 79 by 2 @@ -236,30 +216,23 @@ pod/perl.pod Verbatim line length including indents exceeds 79 by 8 pod/perlaix.pod Verbatim line length including indents exceeds 79 by 11 pod/perlapi.pod ? Should you be using L<...> instead of 76 pod/perlapi.pod Verbatim line length including indents exceeds 79 by 6 -pod/perlapi.pod unresolved internal link 3 pod/perlapio.pod Verbatim line length including indents exceeds 79 by 5 pod/perlbook.pod Verbatim line length including indents exceeds 79 by 1 pod/perlcall.pod Verbatim line length including indents exceeds 79 by 2 -pod/perlce.pod Verbatim line length including indents exceeds 79 by 2 -pod/perlcygwin.pod Verbatim line length including indents exceeds 79 by 24 -pod/perldbmfilter.pod Verbatim line length including indents exceeds 79 by 1 +pod/perlcygwin.pod Verbatim line length including indents exceeds 79 by 25 pod/perldebguts.pod Verbatim line length including indents exceeds 79 by 34 pod/perldebtut.pod Verbatim line length including indents exceeds 79 by 22 pod/perldebug.pod Verbatim line length including indents exceeds 79 by 3 -pod/perldiag.pod =item type mismatch 1 -pod/perldiag.pod Verbatim line length including indents exceeds 79 by 1 pod/perldsc.pod Verbatim line length including indents exceeds 79 by 4 pod/perldtrace.pod Verbatim line length including indents exceeds 79 by 26 pod/perlebcdic.pod Verbatim line length including indents exceeds 79 by 13 pod/perlembed.pod Verbatim line length including indents exceeds 79 by 27 -pod/perlfunc.pod There is more than one target 1 pod/perlgit.pod Verbatim line length including indents exceeds 79 by 12 pod/perlgpl.pod Verbatim line length including indents exceeds 79 by 50 pod/perlguts.pod ? Should you be using F<...> or maybe L<...> instead of 2 pod/perlguts.pod ? Should you be using L<...> instead of 1 pod/perlhack.pod ? Should you be using L<...> instead of 1 -pod/perlhack.pod Verbatim line length including indents exceeds 79 by 1 -pod/perlhist.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlhist.pod Verbatim line length including indents exceeds 79 by 1 pod/perlhpux.pod Verbatim line length including indents exceeds 79 by 5 pod/perlhurd.pod Verbatim line length including indents exceeds 79 by 2 pod/perlintern.pod ? Should you be using L<...> instead of 5 @@ -269,78 +242,37 @@ pod/perlipc.pod Verbatim line length including indents exceeds 79 by 19 pod/perlirix.pod Verbatim line length including indents exceeds 79 by 4 pod/perllol.pod Verbatim line length including indents exceeds 79 by 4 pod/perlmacosx.pod Verbatim line length including indents exceeds 79 by 4 -pod/perlmod.pod Verbatim line length including indents exceeds 79 by 2 pod/perlmodlib.pod Verbatim line length including indents exceeds 79 by 3 -pod/perlmodstyle.pod Verbatim line length including indents exceeds 79 by 2 +pod/perlmodstyle.pod Verbatim line length including indents exceeds 79 by 1 pod/perlmroapi.pod ? Should you be using L<...> instead of 1 pod/perlnetware.pod Verbatim line length including indents exceeds 79 by 4 pod/perlnewmod.pod Verbatim line length including indents exceeds 79 by 1 pod/perlootut.pod ? Should you be using F<...> or maybe L<...> instead of 1 pod/perlos2.pod ? Should you be using L<...> instead of 2 -pod/perlos2.pod Verbatim line length including indents exceeds 79 by 22 +pod/perlos2.pod Verbatim line length including indents exceeds 79 by 21 pod/perlos390.pod Verbatim line length including indents exceeds 79 by 11 -pod/perlpacktut.pod Verbatim line length including indents exceeds 79 by 6 pod/perlperf.pod Verbatim line length including indents exceeds 79 by 154 -pod/perlpodspec.pod Verbatim line length including indents exceeds 79 by 9 -pod/perlpodstyle.pod Verbatim line length including indents exceeds 79 by 1 -pod/perlref.pod Verbatim line length including indents exceeds 79 by 1 -pod/perlrequick.pod Verbatim line length including indents exceeds 79 by 3 -pod/perlretut.pod Verbatim line length including indents exceeds 79 by 13 pod/perlrun.pod Verbatim line length including indents exceeds 79 by 3 pod/perlsolaris.pod Verbatim line length including indents exceeds 79 by 14 pod/perlsource.pod ? Should you be using F<...> or maybe L<...> instead of 1 pod/perlsub.pod ? Should you be using F<...> or maybe L<...> instead of 3 -pod/perlsub.pod Verbatim line length including indents exceeds 79 by 4 pod/perlsymbian.pod Verbatim line length including indents exceeds 79 by 20 -pod/perlthrtut.pod Verbatim line length including indents exceeds 79 by 5 pod/perltie.pod Verbatim line length including indents exceeds 79 by 13 pod/perltrap.pod ? Should you be using F<...> or maybe L<...> instead of 1 pod/perltru64.pod ? Should you be using F<...> or maybe L<...> instead of 1 -pod/perltru64.pod Verbatim line length including indents exceeds 79 by 4 -pod/perlunifaq.pod empty section in previous paragraph 1 -pod/perluniprops.pod =item type mismatch 6 +pod/perltru64.pod Verbatim line length including indents exceeds 79 by 5 pod/perlvms.pod ? Should you be using F<...> or maybe L<...> instead of 1 -pod/perlvms.pod Verbatim line length including indents exceeds 79 by 2 pod/perlwin32.pod Verbatim line length including indents exceeds 79 by 12 porting/epigraphs.pod Verbatim line length including indents exceeds 79 by 3 porting/expand-macro.pl Verbatim line length including indents exceeds 79 by 2 -porting/how_to_write_a_perldelta.pod There is no NAME 1 -porting/how_to_write_a_perldelta.pod Verbatim line length including indents exceeds 79 by 3 -porting/pumpkin.pod Verbatim line length including indents exceeds 79 by 9 porting/release_managers_guide.pod Verbatim line length including indents exceeds 79 by 7 -porting/release_schedule.pod There is no NAME 1 porting/todo.pod Verbatim line length including indents exceeds 79 by 7 -symbian/perlutil.pod Verbatim line length including indents exceeds 79 by 4 utils/c2ph Verbatim line length including indents exceeds 79 by 44 vms/ext/filespec.pm Verbatim line length including indents exceeds 79 by 1 -x2p/a2p.pod empty section in previous paragraph 2 -lib/benchmark.pm Verbatim line length including indents exceeds 79 by 4 -lib/class/struct.pm Verbatim line length including indents exceeds 79 by 7 +lib/benchmark.pm Verbatim line length including indents exceeds 79 by 2 lib/config.pod ? Should you be using L<...> instead of -1 -lib/config.pod nested commands F<...F<...>...> 3 -lib/db.pm Verbatim line length including indents exceeds 79 by 2 -lib/dbm_filter.pm Verbatim line length including indents exceeds 79 by 1 -lib/dbm_filter/compress.pm Verbatim line length including indents exceeds 79 by 1 -lib/dbm_filter/encode.pm Verbatim line length including indents exceeds 79 by 1 -lib/dbm_filter/int32.pm Verbatim line length including indents exceeds 79 by 1 -lib/dbm_filter/null.pm Verbatim line length including indents exceeds 79 by 1 -lib/dbm_filter/utf8.pm Verbatim line length including indents exceeds 79 by 1 -lib/deprecate.pm Verbatim line length including indents exceeds 79 by 2 -lib/english.pm Verbatim line length including indents exceeds 79 by 1 lib/extutils/embed.pm Verbatim line length including indents exceeds 79 by 2 -lib/extutils/xssymset.pm Verbatim line length including indents exceeds 79 by 1 -lib/file/basename.pm Verbatim line length including indents exceeds 79 by 2 lib/file/find.pm Verbatim line length including indents exceeds 79 by 1 -lib/getopt/std.pm Verbatim line length including indents exceeds 79 by 1 -lib/integer.pm Verbatim line length including indents exceeds 79 by 1 lib/perl5db.pl ? Should you be using L<...> instead of 1 -lib/perl5db.pl Verbatim line length including indents exceeds 79 by 1 -lib/perlio.pm Verbatim line length including indents exceeds 79 by 2 lib/pod/text/overstrike.pm Verbatim line length including indents exceeds 79 by 1 -lib/strict.pm Verbatim line length including indents exceeds 79 by 1 -lib/tie/array.pm Verbatim line length including indents exceeds 79 by 1 -lib/tie/hash.pm Verbatim line length including indents exceeds 79 by 3 -lib/tie/scalar.pm Verbatim line length including indents exceeds 79 by 1 -lib/version.pod Verbatim line length including indents exceeds 79 by 1 -lib/version/internals.pod Verbatim line length including indents exceeds 79 by 2 -lib/vmsish.pm Verbatim line length including indents exceeds 79 by 1 +lib/version/internals.pod Verbatim line length including indents exceeds 79 by 1 -- 1.7.10.4 ```
p5pRT commented 11 years ago

From @cpansprout

On Fri Jun 28 17​:12​:57 2013\, gottreu wrote​:

This is a bug report for perl from gottreu@​gmail.com\, generated with the help of perlbug 1.39 running under perl 5.19.2.

-----------------------------------------------------------------

Half the patches are by Ricardo from his podcheck-again branch. These make the 3 checks that were removed or weakened by commit f26da014a698383ac348973050af3e754752e6ab into non-default checks only enabled by --pedantic or PERL_POD_PEDANTIC=1. When the known pod problems database is regenerated the pedantic checks are included as well.

Thank you. Applied​:

$ git log --reverse --pretty=oneline -4 113a3f613b2d047d27db2a432213c8ea84a0a940 Revert "Make t/podcheck.t less sensitiv beabdcb7d34ad66dd4e971d43faab11930a545cd do not worry about long verbatim lines 0cbb9de550d7c53bfcc6ef3ded24eef87fa45a43 Run the pedantic checks when regenerati 4d3a1c657c85acecd021bc818bb8ff02b9ba4190 regenerate t/porting/known_pod_issues.d

--

Father Chrysostomos

p5pRT commented 11 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 11 years ago

@cpansprout - Status changed from 'open' to 'resolved'