Closed p5pRT closed 10 years ago
See attached patch. This is a WIP. Comments requested. No comments on murdering VC6 please. Patching the CPAN stuff I'm not sure how arrange the logistics of\, since it requires a new macro\, but also backcompat with older perls.
On Fri Jan 17 21:43:40 2014\, bulk88 wrote:
This is a bug report for perl from bulk88@hotmail.com\, generated with the help of perlbug 1.39 running under perl 5.19.7.
----------------------------------------------------------------- [Please describe your issue here]
See attached patch. This is a WIP. Comments requested. No comments on murdering VC6 please. Patching the CPAN stuff I'm not sure how arrange the logistics of\, since it requires a new macro\, but also backcompat with older perls.
../lib/vars.t ..................................................... ok ../lib/vars_carp.t ................................................ ok ../lib/vmsish.t ................................................... ok ../lib/warnings.t ................................................. ok x2p/find2perl.t ................................................... skipped: Nee d something vaguely POSIX x2p/s2p.t ......................................................... ok
Test Summary Report
porting/cmp_version.t (Wstat: 0 Tests: 30 Failed: 1) Failed test: 15 porting/podcheck.t (Wstat: 0 Tests: 1372 Failed: 2) Failed tests: 176\, 953 Files=2380\, Tests=693347\, 3829 wallclock secs (136.80 usr + 5.81 sys = 142.61 C PU) Result: FAIL NMAKE : fatal error U1077: '..\perl.exe' : return code '0x3' Stop.
C:\perl519\src\win32>..\perl -Ilib -V Summary of my perl5 (revision 5 version 19 subversion 8) configuration: Derived from: c57317626f225ab9dcb96d5e821be4120370c54d Ancestor: a461c2333c824cbda4d43202743a566c80f6e912 Platform: osname=MSWin32\, osvers=5.1\, archname=MSWin32-x86-multi-thread-64int uname='' config_args='undef' hint=recommended\, useposix=true\, d_sigaction=undef useithreads=define\, usemultiplicity=define use64bitint=define\, use64bitall=undef\, uselongdouble=undef usemymalloc=n\, bincompat5005=undef Compiler: cc='cl'\, ccflags ='-nologo -GF -W3 -Od -MD -Zi -DNDEBUG -DWIN32 -D_CONSOLE - DNO_STRICT -DPERL_TEXTMODE_SCRIPTS -DPERL_HASH_FUNC_ONE_AT_A_TIME -DPERL_IMPLIC IT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T'\, optimize='-Od -MD -Zi -DNDEBUG'\, cppflags='-DWIN32' ccversion='12.00.8168'\, gccversion=''\, gccosandvers='' intsize=4\, longsize=4\, ptrsize=4\, doublesize=8\, byteorder=12345678 d_longlong=undef\, longlongsize=8\, d_longdbl=define\, longdblsize=8 ivtype='__int64'\, ivsize=8\, nvtype='double'\, nvsize=8\, Off_t='__int64'\, lsee ksize=8 alignbytes=8\, prototype=define Linker and Libraries: ld='link'\, ldflags ='-nologo -nodefaultlib -debug -opt:ref\,icf -libpath:"c: \perl519\lib\CORE" -machine:x86' libpth=C:\PROGRA~1\MIAF9D~1\VC98\lib libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.l ib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32 .lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt. lib perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg 32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws 2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msv crt.lib libc=msvcrt.lib\, so=dll\, useshrplib=true\, libperl=perl519.lib gnulibc_version='' Dynamic Linking: dlsrc=dl_win32.xs\, dlext=dll\, d_dlsymun=undef\, ccdlflags=' ' cccdlflags=' '\, lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref\,icf - libpath:"c:\perl519\lib\CORE" -machine:x86'
Characteristics of this binary (from libperl): Compile-time options: HAS_TIMES HAVE_INTERP_INTERN MULTIPLICITY PERLIO_LAYERS PERL_DONT_CREATE_GVSV PERL_HASH_FUNC_ONE_AT_A_TIME PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS PERL_MALLOC_WRAP PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV USE_64_BIT_INT USE_ITHREADS USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF Locally applied patches: uncommitted-changes c57317626f225ab9dcb96d5e821be4120370c54d Built under MSWin32 Compiled at Jan 17 2014 23:31:45 @INC: lib C:/perl519/src/lib .
C:\perl519\src\win32>cl /? Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8168 for 80x86 Copyright (C) Microsoft Corp 1984-1998. All rights reserved.
C/C++ COMPILER OPTIONS
Smoke looks good. I do realize the UV2NV macro requirement makes many XS modules on CPAN with VC6 not build\, so that disclaimer will probably have to go into README.win32.
-- bulk88 ~ bulk88 at hotmail.com
Some fixes in the patch. Clearer notes about the limitations of VC6 and 64 bit IVs. 1 cmp_version fix.
-- bulk88 ~ bulk88 at hotmail.com
On Mon Jan 20 11:10:02 2014\, bulk88 wrote:
Some fixes in the patch. Clearer notes about the limitations of VC6 and 64 bit IVs. 1 cmp_version fix.
I don't think this change belongs in perl.
It's working around a fairly severe breakage in a compiler for which is no longer supported by the vendor and for which free alternatives are available (MSVC as bundled with the platform SDK).
Even if applied\, this would be a ghetto in that any CPAN XS that (correctly!) expects to convert UV to NV implicitly will fail to build\, with the side effect that the user might blame the CPAN author instead of their broken tools.
Tony
The RT System itself - Status changed from 'new' to 'open'
On Sun Jan 26 15:35:58 2014\, tonyc wrote:
On Mon Jan 20 11:10:02 2014\, bulk88 wrote:
Some fixes in the patch. Clearer notes about the limitations of VC6 and 64 bit IVs. 1 cmp_version fix.
I don't think this change belongs in perl.
It's working around a fairly severe breakage in a compiler for which is no longer supported by the vendor and for which free alternatives are available (MSVC as bundled with the platform SDK).
Even if applied\, this would be a ghetto in that any CPAN XS that (correctly!) expects to convert UV to NV implicitly will fail to build\, with the side effect that the user might blame the CPAN author instead of their broken tools.
Per this\, I'm rejecting this patch\, thanks for submitting it though.
Tony
@tonycoz - Status changed from 'open' to 'rejected'
Migrated from rt.perl.org#121029 (status was 'rejected')
Searchable as RT121029$