Bleadperl v5.19.2-231-g7db6405 breaks MLEHMANN/Devel-FindRef-1.43.tar.gz

p5pRT commented 10 years ago

Migrated from rt.perl.org#121899 (status was 'resolved')

Searchable as RT121899$

p5pRT commented 10 years ago

From @andk

git bisect

78ea8184089842949690 Author: Father Chrysostomos \sprout@cpan\.org Date: Mon Jul 29 20:40:24 2013 -0700

Skip trailing constants when searching pads

rt.cpan ticket

https://rt.cpan.org/Ticket/Display.html?id=95724

perl -V

http://www.cpantesters.org/cpan/report/40a5364a-dcd7-11e3-a795-b9addfbfc7aa

-- andreas

p5pRT commented 10 years ago

From @iabyn

On Fri\, May 16\, 2014 at 11:58:12PM -0700\, Andreas J. Koenig via RT wrote:

# New Ticket Created by (Andreas J. Koenig) # Please include the string: [perl #121899] # in the subject line of all future correspondence about this issue. # \<URL: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121899 >

git bisect ---------- 78ea8184089842949690 Author: Father Chrysostomos \sprout@cpan\.org Date: Mon Jul 29 20:40:24 2013 -0700
Skip trailing constants when searching pads
rt.cpan ticket -------------- https://rt.cpan.org/Ticket/Display.html?id=95724

perl -V ------- http://www.cpantesters.org/cpan/report/40a5364a-dcd7-11e3-a795-b9addfbfc7aa

I can't commit 78ea8184089842949690\, but 7db6405c07905ec5 seems to be the commit in question.

That commit repurposes the SvMAGIC field of AVs which hold the names of pad elements\, to hold a count of the number of named elements in the pad (if I'm reading the commit correctly).

Since Devel-FindRef scans arenas\, it finds such hidden gems. I'd suggest to Marc that he guards the 'while (mg)' block of code in find_() with an 'if (SvMAGICAL(sv))'.

-- Please note that ash-trays are provided for the use of smokers\, whereas the floor is provided for the use of all patrons. -- Bill Royston

p5pRT commented 10 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 10 years ago

From schmorp@schmorp.de

On Sat\, May 17\, 2014 at 04:18:26PM +0100\, Dave Mitchell \davem@iabyn\.com wrote:

That commit repurposes the SvMAGIC field of AVs which hold the names of pad elements\, to hold a count of the number of named elements in the pad (if I'm reading the commit correctly).

Since Devel-FindRef scans arenas\, it finds such hidden gems.

Yeah\, despite skipping them elsewhere because we are not interested in those AVs :)

I'd suggest to Marc that he guards the 'while (mg)' block of code in find_() with an 'if (SvMAGICAL(sv))'.

Looks fine to me\, thanks!

-- The choice of a Deliantra\, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de -=====/_/_//_/\_\,_/ /_/\_\

p5pRT commented 10 years ago

@iabyn - Status changed from 'open' to 'resolved'

Perl / perl5