search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.99k stars 559 forks source link

New sub(){$var} deprecation breaks CPAN #14243

Closed p5pRT closed 9 years ago

p5pRT commented 10 years ago

Migrated from rt.perl.org#123213 (status was 'resolved')

Searchable as RT123213$

p5pRT commented 10 years ago

From @cpansprout

So far these two seem to be broken​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz

I’m still testing other dists.

--

Father Chrysostomos

p5pRT commented 10 years ago

From @jkeenan

On Fri Nov 14 22​:03​:32 2014\, sprout wrote​:

So far these two seem to be broken​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz

I’m still testing other dists.

Searching through 'git log'\, I came across 'sub ()' more than once in the past month.

Is there a particular commit which describes this new deprecation? Or has there been an addition to the docs about it? (I'm having trouble figuring out what the change in functionality actually was.)

Thank you very much.

-- James E Keenan (jkeenan@​cpan.org)

p5pRT commented 10 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 10 years ago

From @cpansprout

On Sat Nov 15 04​:18​:34 2014\, jkeenan wrote​:

On Fri Nov 14 22​:03​:32 2014\, sprout wrote​:

So far these two seem to be broken​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz

I’m still testing other dists.

Searching through 'git log'\, I came across 'sub ()' more than once in the past month.

Is there a particular commit which describes this new deprecation?

0ac016fc6

Or has there been an addition to the docs about it? (I'm having trouble figuring out what the change in functionality actually was.)

d3c633bad

--

Father Chrysostomos

p5pRT commented 10 years ago

From @cpansprout

On Fri Nov 14 22​:03​:32 2014\, sprout wrote​:

So far these two seem to be broken​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz

I’m still testing other dists.

HKOBA/YATT-v0.0.8.tar.gz SAMV/Net-SSLeay-OO-0.02.tar.gz [rt.cpan.org #100364]

Test​::LeakTrace apparently broken by other blead changes (at least under debugging builds). Needed for testing SYOHEX/Text-Xslate-3.3.3.tar.gz.

SUPER broken in blead\, which prevents testing BAREFOOT/Debuggit-2.05.tar.gz.

MONS/XML-Hash-LX-0.0603.tar.gz broken (blead-related?)\, which prevents testing MONS/XML-RPC-Fast-0.8.tar.gz

--

Father Chrysostomos

p5pRT commented 10 years ago

From @andk

On Sat\, 15 Nov 2014 22​:50​:35 -0800\, "Father Chrysostomos via RT" \perlbug\-followup@​perl\.org said​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz   > HKOBA/YATT-v0.0.8.tar.gz

For me all three already broken since v5.21.1-11-g4077a6b

  > SAMV/Net-SSLeay-OO-0.02.tar.gz [rt.cpan.org #100364]   > Test​::LeakTrace apparently broken by other blead changes (at least under debugging builds). Needed for testing SYOHEX/Text-Xslate-3.3.3.tar.gz.

Leaktrace bisected to v5.21.5-396-ga635561

  > SUPER broken in blead\, which prevents testing BAREFOOT/Debuggit-2.05.tar.gz.

https://github.com/Test-More/test-more/issues/476 https://rt.cpan.org/Ticket/Display.html?id=97939

  > MONS/XML-Hash-LX-0.0603.tar.gz broken (blead-related?)\, which   > prevents testing MONS/XML-RPC-Fast-0.8.tar.gz

https://rt.cpan.org/Ticket/Display.html?id=81645

new BBC

I would make this a new BBC\, but you seem to prefer to have it here? GPHAT/MooseX-Method-0.44.tar.gz broken by v5.21.5-413-gd0a32af

-- andreas

p5pRT commented 10 years ago

From @cpansprout

On Sun Nov 16 02​:31​:21 2014\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sat\, 15 Nov 2014 22​:50​:35 -0800\, "Father Chrysostomos via RT" \perlbug\-followup@​perl\.org said​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz HKOBA/YATT-v0.0.8.tar.gz

For me all three already broken since v5.21.1-11-g4077a6b

I didn’t actually do any bisecting. I just tested suspicious-looking modules that I found via CPAN grep.

SAMV/Net-SSLeay-OO-0.02.tar.gz [rt.cpan.org #100364] Test​::LeakTrace apparently broken by other blead changes (at least under debugging builds). Needed for testing SYOHEX/Text-Xslate- 3.3.3.tar.gz.

Leaktrace bisected to v5.21.5-396-ga635561

I have opened #123223. Fixing that will be rather involved\, and may break other modules.

SUPER broken in blead\, which prevents testing BAREFOOT/Debuggit- 2.05.tar.gz.

https://github.com/Test-More/test-more/issues/476 https://rt.cpan.org/Ticket/Display.html?id=97939

MONS/XML-Hash-LX-0.0603.tar.gz broken (blead-related?)\, which prevents testing MONS/XML-RPC-Fast-0.8.tar.gz

https://rt.cpan.org/Ticket/Display.html?id=81645

new BBC -------

I would make this a new BBC\, but you seem to prefer to have it here? GPHAT/MooseX-Method-0.44.tar.gz broken by v5.21.5-413-gd0a32af

On the contrary\, this one is different enough that I have opened #123224 for it.

--

Father Chrysostomos

p5pRT commented 10 years ago

From @karenetheridge

On Sat\, Nov 15\, 2014 at 10​:50​:35PM -0800\, Father Chrysostomos via RT wrote​:

On Fri Nov 14 22​:03​:32 2014\, sprout wrote​:

So far these two seem to be broken​:

HKOBA/YATT-Lite-0.0.9.tar.gz ABW/Badger-0.09.tar.gz

I’m still testing other dists.

HKOBA/YATT-v0.0.8.tar.gz SAMV/Net-SSLeay-OO-0.02.tar.gz [rt.cpan.org #100364]

Also\, aliased.pm is affected​: https://rt.cpan.org/Ticket/Display.html?id=100359

Test​::LeakTrace apparently broken by other blead changes (at least under debugging builds). Needed for testing SYOHEX/Text-Xslate-3.3.3.tar.gz.

We've encountered this in Moose's tests too​: https://s3.amazonaws.com/archive.travis-ci.org/jobs/41186826/log.txt

SUPER broken in blead\, which prevents testing BAREFOOT/Debuggit-2.05.tar.gz.

I see chromatic just released a new SUPER today.

p5pRT commented 10 years ago

From @cpansprout

On Sun Nov 16 02​:31​:21 2014\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

SUPER broken in blead\, which prevents testing BAREFOOT/Debuggit- 2.05.tar.gz.

https://github.com/Test-More/test-more/issues/476 https://rt.cpan.org/Ticket/Display.html?id=97939

Debuggit passes its tests\, but warns. I’ve submitted a patch to \https://rt.cpan.org/Ticket/Display.html?id=90433.

MONS/XML-Hash-LX-0.0603.tar.gz broken (blead-related?)\, which prevents testing MONS/XML-RPC-Fast-0.8.tar.gz

https://rt.cpan.org/Ticket/Display.html?id=81645

With the patch from that ticket\, I was able to test MONS/XML-RPC-Fast-0.8.tar.gz\, which is fine.

--

Father Chrysostomos

p5pRT commented 10 years ago

From @andk

Also Affected​: JSWARTZ/Mason-2.22.tar.gz Bisect​: v5.21.5-402-g0ac016f Report​: http​://www.cpantesters.org/cpan/report/f5837424-7119-11e4-9a97-65c510862755 -- andreas

p5pRT commented 10 years ago

From @cpansprout

On Fri Nov 21 21​:36​:58 2014\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also Affected​: JSWARTZ/Mason-2.22.tar.gz Bisect​: v5.21.5-402-g0ac016f Report​: http​://www.cpantesters.org/cpan/report/f5837424-7119-11e4- 9a97-65c510862755

Patch at \https://rt.cpan.org/Ticket/Display.html?id=100507.

--

Father Chrysostomos

p5pRT commented 9 years ago

From @andk

Also affected​:

Exact bisect​: v5.21.5-402-g0ac016f PREACTION/Statocles-0.026.tar.gz http​://www.cpantesters.org/cpan/report/4704cc42-7e96-11e4-aaa8-d1ac52b25338

-- andreas

p5pRT commented 9 years ago

From @cpansprout

On Mon Dec 08 12​:27​:19 2014\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​:

Exact bisect​: v5.21.5-402-g0ac016f PREACTION/Statocles-0.026.tar.gz http​://www.cpantesters.org/cpan/report/4704cc42-7e96-11e4-aaa8-d1ac52b25338

It depends on Type​::Tiny\, which fails assertions added by the multideref code​:

Assertion failed​: (!(o->op_flags & ~(OPf_WANT|OPf_KIDS|OPf_MOD)))\, function S_maybe_multideref\, file op.c\, line 12520.

--

Father Chrysostomos

p5pRT commented 9 years ago

From @cpansprout

On Mon Dec 08 16​:16​:11 2014\, sprout wrote​:

On Mon Dec 08 12​:27​:19 2014\, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​:

Exact bisect​: v5.21.5-402-g0ac016f PREACTION/Statocles-0.026.tar.gz http​://www.cpantesters.org/cpan/report/4704cc42-7e96-11e4-aaa8- d1ac52b25338

It depends on Type​::Tiny\, which fails assertions added by the multideref code​:

Assertion failed​: (!(o->op_flags & ~(OPf_WANT|OPf_KIDS|OPf_MOD)))\, function S_maybe_multideref\, file op.c\, line 12520.

Type​::Tiny was fixed by 1553b1d30\, so I was able to test Statocles\, which passes if I apply the aliased patch from \https://rt.cpan.org/Ticket/Display.html?id=100359.  So there is nothing more I can do here.

--

Father Chrysostomos

p5pRT commented 9 years ago

From @andk

Also affected on the detour to O/OV/OVID/aliased-0.31.tar.gz​: FLORA/MooseX-MultiMethods-0.10.tar.gz

But only if MooseX​::Declare and Test​::NoWarnings are installed. In this case\, when the patch https://rt.cpan.org/Ticket/Display.html?id=100359 is applied\, MooseX-MultiMethods-0.10 passes its tests again.

-- andreas

p5pRT commented 9 years ago

From @tonycoz

Out of the dists mentioned so far\, the following haven't had fixes released​:

HKOBA/YATT-Lite-0.0.9.tar.gz HKOBA/YATT-v0.0.8.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=95311 - author said he'd fix both dists in this ticket

ABW/Badger-0.09.tar.gz - https​://rt.cpan.org/Ticket/Display.html?id=99200 - fixed in git at https://github.com/abw/Badger

SAMV/Net-SSLeay-OO-0.02.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=100364 - no response to ticket since November

JSWARTZ/Mason-2.22.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=100507 - has a patch\, has had a few recent releases without this being fixed

The following appears to be unrelated to sub () {$var}​:

MONS/XML-Hash-LX-0.0603.tar.gz - failure seems to be caused by hash randomization

The following have been fixed​:

BAREFOOT/Debuggit-2.05.tar.gz - fixed in 2.06

OVID/aliased-0.31.tar.gz - fixed in 0.33

The following have been fixed by the fix to aliased​:

PREACTION/Statocles-0.026.tar.gz

FLORA/MooseX-MultiMethods-0.10.tar.gz

p5pRT commented 9 years ago

From @iabyn

On Tue\, Apr 07\, 2015 at 05​:19​:51PM -0700\, Tony Cook via RT wrote​:

Out of the dists mentioned so far\, the following haven't had fixes released​:

HKOBA/YATT-Lite-0.0.9.tar.gz HKOBA/YATT-v0.0.8.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=95311 - author said he'd fix both dists in this ticket

There have since been releases of both these modules that claim to be fixed.

ABW/Badger-0.09.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=99200 - fixed in git at https://github.com/abw/Badger

Still no new release

SAMV/Net-SSLeay-OO-0.02.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=100364 - no response to ticket since November

No new release since 2009.

JSWARTZ/Mason-2.22.tar.gz - https://rt.cpan.org/Ticket/Display.html?id=100507 - has a patch\, has had a few recent releases without this being fixed

Still unfixed. I've just emailed the author asking if he's aware of the ticket.

My feeling is that this ticket no longer needs to be blocker.

-- Dave's first rule of Opera​: If something needs saying\, say it​: don't warble it.

p5pRT commented 9 years ago

From @rjbs

Used to update Known Problems list.

-- rjbs

p5pRT commented 9 years ago

@rjbs - Status changed from 'open' to 'resolved'