Closed p5pRT closed 9 years ago
An offline local perl user noted to me that VC Perl on Win64 gives a screenful of warnings in hv_func.h every time hv_func.h is included. This is with not only core .c files\, but XS modules too\, core XS and CPAN XS. While the perl core .c files have always produced screenfulls of warnings on VC Win64\, because GCC never warnings about assignment to a smaller type that would result in truncation ("-Wconversion" on GCC\, and AFAIK no meta -W flags include -Wconversion). So while core warnings are fine on VC Win64\, a screenful of warnings with every CPAN XS module .c file on Win64 is unacceptable and needs to be fixed. I will address the wider warnings problem in a separate ML post.
I plan to silence the warnings in hv_func.h with a patch I'll attach soon to this thread. I'd also like a backport to 5.20 and 5.18 since these warnings didn't exist in VC Win64 5.10 since hv_func.h didn't exist until 5.12 series.
---------------------------------------------------------------- cl -c -nologo -GF -W3 -O1 -MD -Zi -DDEBUGGING -fp:precise -DWIN32 -D_ CONSOLE -DNO_STRICT -DWIN64 -DCONSERVATIVE -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NON STDC_NO_DEPRECATE -DPERL_TEXTMODE_SCRIPTS -DPERL_HASH_FUNC_ONE_AT_A_TIME -DNO_MA THOMS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -O1 -MD -Zi -DDEB UGGING -fp:precise -DVERSION=\"3.54\" -DXS_VERSION=\"3.54\" "-I..\..\lib\CO RE" -DDOUBLE_SLASHES_SPECIAL=0 -DNO_PPPORT_H Cwd.c Cwd.c c:\p521\srcnew\lib\core\hv_func.h(272) : warning C4267: 'initializing' : convers ion from 'size_t' to 'U32'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(382) : warning C4267: 'initializing' : convers ion from 'size_t' to 'I32'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(405) : warning C4267: 'initializing' : convers ion from 'size_t' to 'int'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(446) : warning C4267: 'initializing' : convers ion from 'size_t' to 'int'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(470) : warning C4267: 'initializing' : convers ion from 'size_t' to 'U32'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(480) : warning C4267: 'initializing' : convers ion from 'size_t' to 'U32'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(506) : warning C4267: 'initializing' : convers ion from 'size_t' to 'U32'\, possible loss of data c:\p521\srcnew\lib\core\hv_func.h(521) : warning C4267: 'initializing' : convers ion from 'size_t' to 'U32'\, possible loss of data "..\..\miniperl.exe" "-I..\..\lib" "-I..\..\lib" -MExtUtils::Mksymlists -e "Mksymlists('NAME'=>\"Cwd\"\, 'DLBASE' => 'Cwd'\, 'DL_FUNCS' => { }\, 'FUNCLIS T' => []\, 'IMPORTS' => { }\, 'DL_VARS' => []);" link -out:..\..\lib\auto\Cwd\Cwd.dll -dll -nologo -nodefaultlib -debug - opt:ref\,icf -libpath:"c:\p521\lib\CORE" -machine:AMD64 "/manifestdependency:ty pe='Win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorA rchitecture='*' publicKeyToken='6595b64144ccf1df' language='*'" Cwd.obj "..\.. \lib\CORE\perl521.lib" oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.l ib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib u uid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl 32.lib msvcrt.lib -def:Cwd.def ---------------------------------------------------------------
patch attached
-- bulk88 ~ bulk88 at hotmail.com
On Tue Dec 23 02:27:35 2014\, bulk88 wrote:
patch attached
Thank you. Applied as b4045391.
--
Father Chrysostomos
The RT System itself - Status changed from 'new' to 'open'
@cpansprout - Status changed from 'open' to 'pending release'
Thanks for submitting this ticket
The issue should be resolved with the release today of Perl v5.22\, available at http://www.perl.org/get.html If you find that the problem persists\, feel free to reopen this ticket
-- Karl Williamson for the Perl 5 porters team
@khwilliamson - Status changed from 'pending release' to 'resolved'
Migrated from rt.perl.org#123483 (status was 'resolved')
Searchable as RT123483$