Closed p5pRT closed 8 years ago
For 5.23. See attached patch.
On Sun May 10 13:50:00 2015\, bulk88 wrote:
For 5.23. See attached patch.
Presumably an edit glitch in the patch comment:
I this in observed in XS-Typemap's DLL.
This looks like an unrelated change:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) RX_ENGINE(prog)->rxfree(aTHX_ (prog))
It doesn't really need a new name\, it could be just:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) (RX_ENGINE(prog)->free)(aTHX_ (prog))
but should be separate anyway.
Tony
The RT System itself - Status changed from 'new' to 'open'
On Sun May 10 18:12:50 2015\, tonyc wrote:
On Sun May 10 13:50:00 2015\, bulk88 wrote:
For 5.23. See attached patch.
Presumably an edit glitch in the patch comment:
I this in observed in XS-Typemap's DLL.
fixed in attached patch
This looks like an unrelated change:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) RX_ENGINE(prog)->rxfree(aTHX_ (prog))
It doesn't really need a new name\, it could be just:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) (RX_ENGINE(prog)->free)(aTHX_ (prog))
but should be separate anyway.
Tony
doesn't work
cl -c -nologo -GF -W3 -I..\lib\CORE -I.\include -I. -I.. -DWIN32 -D_CONSOLE -DNO _STRICT -DPERLDLL -DPERL_CORE -O1 -MD -Zi -DNDEBUG -GL -DPERL_EXTERN AL_GLOB -DPERL_IS_MINIPERL -Fomini\regcomp.obj -Fdmini\regcomp.pdb ..\regcomp.c regcomp.c ..\regcomp.c(17210) : error C2039: 'win32_free' : is not a member of 'regexp_eng ine' c:\perl521\srcnewb4opt\regexp.h(157) : see declaration of 'regexp_engine ' b88dmake: Error code 130\, while making 'mini\regcomp.obj'
the define in win32iop.h is
#define free win32_free
not "#define free(a) win32_free(a)"
-- bulk88 ~ bulk88 at hotmail.com
On Sun May 10 20:32:12 2015\, bulk88 wrote:
On Sun May 10 18:12:50 2015\, tonyc wrote:
On Sun May 10 13:50:00 2015\, bulk88 wrote:
For 5.23. See attached patch.
Presumably an edit glitch in the patch comment:
I this in observed in XS-Typemap's DLL.
fixed in attached patch
Thanks
This looks like an unrelated change:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) RX_ENGINE(prog)->rxfree(aTHX_ (prog))
It doesn't really need a new name\, it could be just:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) (RX_ENGINE(prog)->free)(aTHX_ (prog))
but should be separate anyway.
Tony
doesn't work ... the define in win32iop.h is
#define free win32_free
not "#define free(a) win32_free(a)"
Thanks for the correction\, added to my post 5.22 branch.
Tony
On Sun May 10 21:49:15 2015\, tonyc wrote:
On Sun May 10 20:32:12 2015\, bulk88 wrote:
On Sun May 10 18:12:50 2015\, tonyc wrote:
On Sun May 10 13:50:00 2015\, bulk88 wrote:
For 5.23. See attached patch.
Presumably an edit glitch in the patch comment:
I this in observed in XS-Typemap's DLL.
fixed in attached patch
Thanks
This looks like an unrelated change:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) RX_ENGINE(prog)->rxfree(aTHX_ (prog))
It doesn't really need a new name\, it could be just:
#define CALLREGFREE_PVT(prog) \ - if(prog) RX_ENGINE(prog)->free(aTHX_ (prog)) + if(prog) (RX_ENGINE(prog)->free)(aTHX_ (prog))
but should be separate anyway.
Tony
doesn't work ... the define in win32iop.h is
#define free win32_free
not "#define free(a) win32_free(a)"
Thanks for the correction\, added to my post 5.22 branch.
Thanks\, applied to blead as fc6bde6fcee5810d400f6080fe2039469c4d2ad3.
Tony
@tonycoz - Status changed from 'open' to 'resolved'
@tonycoz - Status changed from 'resolved' to 'pending release'
Thank you for submitting this report. You have helped make Perl better.
With the release of Perl 5.24.0 on May 9\, 2016\, this and 149 other issues have been resolved.
Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0
@khwilliamson - Status changed from 'pending release' to 'resolved'
Migrated from rt.perl.org#125147 (status was 'resolved')
Searchable as RT125147$