search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.92k stars 551 forks source link

5.22.0/5.23.1 does not build clean on Cygwin Windows 10 #14821

Open p5pRT opened 9 years ago

p5pRT commented 9 years ago

Migrated from rt.perl.org#125701 (status was 'open')

Searchable as RT125701$

p5pRT commented 9 years ago

From @jmaslak

Created by @jmaslak

This impacts all versions of Perl - I tested with 5.23.1 and 5.22.0\, but anything using module Win32 is impacted. Win 10 is releasing officially very soon.

The Win32 module (both current CPAN and bundled version) does not understand Windows 10 versions. Windows 10 (at least the preview I am using) identifies itself as major 10\, minor 0. The problem is that Win32​::_GetOSName() returns nothing (and emits a warning) when it encounters major version 10.

I put a very simple patch together as a pull request to the maintainer's Github repo​:   https://github.com/jandubois/win32/pull/8

This probably isn't the right way to fix it (it identifies all versions of Win 10 as simply "Win10"\, no differentiation for different editions\, server vs. workstation\, etc). But at least this lets the tests complete.

Perl Info ``` Flags: category=library severity=medium module=Win32 Site configuration information for perl 5.23.1: Configured by jmaslak at Mon Jul 27 22:19:15 PDT 2015. Summary of my perl5 (revision 5 version 23 subversion 1) configuration: Platform: osname=cygwin, osvers=2.1.0(0.28753), archname=cygwin-thread-multi uname='cygwin_nt-10.0 win-cvlv0hlkdu7 2.1.0(0.28753) 2015-07-14 21:28 x86_64 cygwin ' config_args='-de -Dprefix=/home/jmaslak/perl5/perlbrew/perls/perl-5.23.1 -Dusedevel -Aeval:scriptdir=/home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/bin' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='gcc', ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -D_FORTIFY_SOURCE=2', optimize='-O3', cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong' ccversion='', gccversion='4.9.3', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='g++', ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -fstack-protector-strong -L/usr/local/lib' libpth=/usr/lib/gcc/x86_64-pc-cygwin/4.9.3/include-fixed /usr/lib /usr/lib/gcc/x86_64-pc-cygwin/4.9.3/../../../../lib/../include/w32api /usr/local/lib /lib libs=-lpthread -ldb -ldl -lcrypt perllibs=-lpthread -ldl -lcrypt libc=/usr/lib/libc.a, so=dll, useshrplib=true, libperl=cygperl5_23_1.dll gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags=' --shared -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -L/usr/local/lib -fstack-protector-strong' Locally applied patches: Devel::PatchPerl 1.38 @INC for perl 5.23.1: /home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/lib/site_perl/5.23.1/cygwin-thread-multi /home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/lib/site_perl/5.23.1 /home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/lib/5.23.1/cygwin-thread-multi /home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/lib/5.23.1 . Environment for perl 5.23.1: HOME=/home/jmaslak LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/jmaslak/perl5/perlbrew/bin:/home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/bin:/usr/local/bin:/usr/bin:/cygdrive/c/Windows/system32:/cygdrive/c/Windows:/cygdrive/c/Windows/System32/Wbem:/cygdrive/c/Windows/System32/WindowsPowerShell/v1.0:/usr/lib/lapack:/usr/sbin:~/perltest/bin PERLBREW_BASHRC_VERSION=0.73 PERLBREW_HOME=/home/jmaslak/.perlbrew PERLBREW_MANPATH=/home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/man PERLBREW_PATH=/home/jmaslak/perl5/perlbrew/bin:/home/jmaslak/perl5/perlbrew/perls/perl-5.23.1/bin PERLBREW_PERL=perl-5.23.1 PERLBREW_ROOT=/home/jmaslak/perl5/perlbrew PERLBREW_VERSION=0.73 PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 9 years ago

From @jmaslak

On Mon Jul 27 15​:59​:36 2015\, jmaslak@​antelope.net wrote​:

This impacts all versions of Perl - I tested with 5.23.1 and 5.22.0\,

I didn't mention the impact\, sorry - the impact is test failures when Win32 is tested during Perl build. The failures are confined to the Win32 module's tests.

p5pRT commented 7 years ago

From @jkeenan

On Mon\, 27 Jul 2015 23​:02​:28 GMT\, jmaslak@​antelope.net wrote​:

On Mon Jul 27 15​:59​:36 2015\, jmaslak@​antelope.net wrote​:

This impacts all versions of Perl - I tested with 5.23.1 and 5.22.0\,

I didn't mention the impact\, sorry - the impact is test failures when Win32 is tested during Perl build. The failures are confined to the Win32 module's tests.

Have you been able to test this version of Windows on perl-5.24?

If so\, could you attach to this ticket the output of 'perl -V' as well as a transcript of any test failures?

Thank you very much.

-- James E Keenan (jkeenan@​cpan.org)

p5pRT commented 7 years ago

The RT System itself - Status changed from 'new' to 'open'