search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.94k stars 554 forks source link

[PATCH] Remove unused CHR_DIST macro #15795

Closed p5pRT closed 7 years ago

p5pRT commented 7 years ago

Migrated from rt.perl.org#130519 (status was 'resolved')

Searchable as RT130519$

p5pRT commented 7 years ago

From @petdance

Created by @petdance

Remove an unused macro from one file.

Perl Info ``` Flags: category=core severity=low Type=Patch PatchStatus=HasPatch Site configuration information for perl 5.25.8: Configured by andy at Wed Nov 30 14:44:36 CST 2016. Summary of my perl5 (revision 5 version 25 subversion 8) configuration: Local Commit: 55f5cd16ae841ab06142d68239189066dc7c46eb Ancestor: a45b01953cfca7a8420399357537c5df6f3a63bd Platform: osname=linux osvers=3.10.0-327.18.2.el7.x86_64 archname=x86_64-linux-thread-multi-ld uname='linux clifford 3.10.0-327.18.2.el7.x86_64 #1 smp thu may 12 11:03:55 utc 2016 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Dusethreads -Duselongdouble -Doptimize=-O3 -Acc=clang -Accflags=-DDEBUGGING -Dprefix=/var/perl/blead -Dmydomain=.petdance.com -Dcf_email=andy@petdance.com -Dperladmin=andy@petdance.com' hint=recommended useposix=true d_sigaction=define useithreads=define usemultiplicity=define use64bitint=define use64bitall=define uselongdouble=define usemymalloc=n bincompat5005=undef Compiler: cc=' clang' ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2' optimize='-O3' cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='' gccversion='4.2.1 Compatible Clang 3.4.2 (tags/RELEASE_34/dot2-final)' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='long double' nvsize=16 Off_t='off_t' lseeksize=8 alignbytes=16 prototype=define Linker and Libraries: ld=' clang' ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /usr/bin/../lib/clang/3.4.2/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64 /usr/lib64 /usr/local/lib64 libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.17.so so=so useshrplib=false libperl=libperl.a gnulibc_version='2.17' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -O3 -L/usr/local/lib -fstack-protector' Locally applied patches: 00614f1b218d4346c49a54c35a0e746bcc61ca99 ffdff4a12c348019789be9437db6053060c6fd70 c9668bc116b106d7b0258fa8661d80692940f09e f4d243dc5118b86f8e80f856d43d79b04667d155 15f1cdaa794f4296441c49c43bb734aa7e2070e4 d96523cf661a4bd422eeb7ca06028da583f7cc02 @INC for perl 5.25.8: lib /var/perl/blead/lib/site_perl/5.25.8/x86_64-linux-thread-multi-ld /var/perl/blead/lib/site_perl/5.25.8 /var/perl/blead/lib/5.25.8/x86_64-linux-thread-multi-ld /var/perl/blead/lib/5.25.8 Environment for perl 5.25.8: HOME=/home/andy LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin:/home/andy/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin PERLBREW_BASHRC_VERSION=0.75 PERLBREW_HOME=/home/andy/.perlbrew PERLBREW_MANPATH=/home/andy/perl5/perlbrew/perls/perl-5.24.0/man PERLBREW_PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin PERLBREW_PERL=perl-5.24.0 PERLBREW_ROOT=/home/andy/perl5/perlbrew PERLBREW_VERSION=0.75 PERLCRITIC=/home/andy/tw/Dev/perlcriticrc PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 7 years ago

From @petdance

0001-Removed-unused-CHR_DIST-macros.patch ```diff From 553968a43072508f3060a0610651255f3bd8b85c Mon Sep 17 00:00:00 2001 From: Andy Lester Date: Sat, 26 Nov 2016 22:46:13 -0600 Subject: [PATCH] Removed unused CHR_DIST macros --- regexec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/regexec.c b/regexec.c index e315965..2327e3b 100644 --- a/regexec.c +++ b/regexec.c @@ -119,7 +119,6 @@ static const char* const non_utf8_target_but_utf8_required */ #define CHR_SVLEN(sv) (utf8_target ? sv_len_utf8(sv) : SvCUR(sv)) -#define CHR_DIST(a,b) (reginfo->is_utf8_target ? utf8_distance(a,b) : a - b) #define HOPc(pos,off) \ (char *)(reginfo->is_utf8_target \ -- 1.8.3.1 ```
p5pRT commented 7 years ago

From @jkeenan

On Fri\, 06 Jan 2017 05​:14​:55 GMT\, petdance wrote​:

This is a bug report for perl from andy@​petdance.com\, generated with the help of perlbug 1.40 running under perl 5.25.8.

----------------------------------------------------------------- [Please describe your issue here]

Remove an unused macro from one file.

Is the identically named\, apparently unused\, but differently defined\, macro in regcomp.c also removable?

##### $ ack CHR_DIST . regcomp.c 559​:#define CHR_DIST(a\,b) (UTF ? utf8_distance(a\,b) : a - b)

regexec.c 122​:#define CHR_DIST(a\,b) (reginfo->is_utf8_target ? utf8_distance(a\,b) : a - b) #####

[Please do not change anything below this line] ----------------------------------------------------------------- --- Flags​: category=core severity=low Type=Patch PatchStatus=HasPatch --- Site configuration information for perl 5.25.8​:

Configured by andy at Wed Nov 30 14​:44​:36 CST 2016.

Summary of my perl5 (revision 5 version 25 subversion 8) configuration​: Local Commit​: 55f5cd16ae841ab06142d68239189066dc7c46eb Ancestor​: a45b01953cfca7a8420399357537c5df6f3a63bd Platform​: osname=linux osvers=3.10.0-327.18.2.el7.x86_64 archname=x86_64-linux-thread-multi-ld uname='linux clifford 3.10.0-327.18.2.el7.x86_64 #1 smp thu may 12 11​:03​:55 utc 2016 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Dusethreads -Duselongdouble -Doptimize=-O3 -Acc=clang -Accflags=-DDEBUGGING -Dprefix=/var/perl/blead -Dmydomain=.petdance.com -Dcf_email=andy@​petdance.com -Dperladmin=andy@​petdance.com' hint=recommended useposix=true d_sigaction=define useithreads=define usemultiplicity=define use64bitint=define use64bitall=define uselongdouble=define usemymalloc=n bincompat5005=undef Compiler​: cc=' clang' ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict- aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2' optimize='-O3' cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict- aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='' gccversion='4.2.1 Compatible Clang 3.4.2 (tags/RELEASE_34/dot2- final)' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='long double' nvsize=16 Off_t='off_t' lseeksize=8 alignbytes=16 prototype=define Linker and Libraries​: ld=' clang' ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /usr/bin/../lib/clang/3.4.2/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64 /usr/lib64 /usr/local/lib64 libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.17.so so=so useshrplib=false libperl=libperl.a gnulibc_version='2.17' Dynamic Linking​: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl\,-E' cccdlflags='-fPIC' lddlflags='-shared -O3 -L/usr/local/lib -fstack-protector'

Locally applied patches​: 00614f1b218d4346c49a54c35a0e746bcc61ca99 ffdff4a12c348019789be9437db6053060c6fd70 c9668bc116b106d7b0258fa8661d80692940f09e f4d243dc5118b86f8e80f856d43d79b04667d155 15f1cdaa794f4296441c49c43bb734aa7e2070e4 d96523cf661a4bd422eeb7ca06028da583f7cc02

--- @​INC for perl 5.25.8​: lib /var/perl/blead/lib/site_perl/5.25.8/x86_64-linux-thread-multi-ld /var/perl/blead/lib/site_perl/5.25.8 /var/perl/blead/lib/5.25.8/x86_64-linux-thread-multi-ld /var/perl/blead/lib/5.25.8

--- Environment for perl 5.25.8​: HOME=/home/andy LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/andy/perl5/perlbrew/bin​:/home/andy/perl5/perlbrew/perls/perl- 5.24.0/bin​:/home/andy/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/bin​:/usr/local/sbin​:/usr/sbin PERLBREW_BASHRC_VERSION=0.75 PERLBREW_HOME=/home/andy/.perlbrew PERLBREW_MANPATH=/home/andy/perl5/perlbrew/perls/perl-5.24.0/man PERLBREW_PATH=/home/andy/perl5/perlbrew/bin​:/home/andy/perl5/perlbrew/perls/perl- 5.24.0/bin PERLBREW_PERL=perl-5.24.0 PERLBREW_ROOT=/home/andy/perl5/perlbrew PERLBREW_VERSION=0.75 PERLCRITIC=/home/andy/tw/Dev/perlcriticrc PERL_BADLANG (unset) SHELL=/bin/bash

-- James E Keenan (jkeenan@​cpan.org)

p5pRT commented 7 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 7 years ago

From @petdance

On Jan 6\, 2017\, at 6​:45 AM\, James E Keenan via RT \perlbug\-followup@​perl\.org wrote​:

Is the identically named\, apparently unused\, but differently defined\, macro in regcomp.c also removable?

Yes\, I’m sorry I forgot about that one.

-- Andy Lester => www.petdance.com

p5pRT commented 7 years ago

From @jkeenan

On Fri\, 06 Jan 2017 14​:56​:10 GMT\, petdance wrote​:

On Jan 6\, 2017\, at 6​:45 AM\, James E Keenan via RT \<perlbug- followup@​perl.org> wrote​:

Is the identically named\, apparently unused\, but differently defined\, macro in regcomp.c also removable?

Yes\, I’m sorry I forgot about that one.

-- Andy Lester => www.petdance.com

Pushed to blead in​: commit 12e1fa63201ac1c5e2c5ecb94649c3ac6af7b057 and commit fca54fd6f66b9ef09b08370f19c6b709b5c2b89c

Thank you very much. -- James E Keenan (jkeenan@​cpan.org)

p5pRT commented 7 years ago

@jkeenan - Status changed from 'open' to 'resolved'