search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.88k stars 530 forks source link

[PATCH] perlfaq3 and perlfaq9 broken links fixes #16352

Closed p5pRT closed 6 years ago

p5pRT commented 6 years ago

Migrated from rt.perl.org#132693 (status was 'resolved')

Searchable as RT132693$

p5pRT commented 6 years ago

From dctabuyz@yandex.ru

Created by dctabuyz@yandex.ru

This is a bug report for perl from dctabuyz@​yandex.ru\, generated with the help of perlbug 1.41 running under perl 5.27.8.

----------------------------------------------------------------- there are some broken links in perlfaq\, some of them i've fixed\, some of them are not fixed because it is not clear for me how to do it right

links fixed​:

perlfaq3​:

  http​://www.cpan.org/authors/id/TOMC/scripts/toms.exrc.gz   http​://www.cpan.org/authors/Tom_Christiansen/scripts/rep.gz   http​://www.cpan.org/authors/Tom_Christiansen/scripts/toms.exrc.gz

  http​://dickey.his.com/vile/vile.html

  http​://www.perl.com/lpt/a/850

perlfaq9​:   http​://www.perl.com/cgi-bin/cpan_mod

links NOT fixed​:

http​://perl-zeitung.at.tf (connection timeout) http​://par.perl.org/ (NXDOMAIN) http​://www.solutionsoft.com/perl.htm (NXDOMAIN) http​://www.fastcgi.com/ (connection timeout\, seems not supported anymore​: https://redd.it/4bywjn)

http​://web.cse.msu.edu/~cse320/Documents/FloatingPoint.pdf (not found\, accessible via webarchive)

Perl Info ``` Flags: category=docs severity=low Type=Patch PatchStatus=HasPatch Site configuration information for perl 5.27.8: Configured by someuser at Mon Jan 8 23:19:48 +05 2018. Summary of my perl5 (revision 5 version 27 subversion 8) configuration: Local Commit: d98a8304d1105624823d312a03576c4fb9bec372 Ancestor: 807d97fa921ab01e56e08aa52dc8bbdc14f85ce6 Platform: osname=linux osvers=4.4.0-104-generic archname=x86_64-linux uname='linux somehost 4.4.0-104-generic #127-ubuntu smp mon dec 11 12:16:42 utc 2017 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel' hint=recommended useposix=true d_sigaction=define useithreads=undef usemultiplicity=undef use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='cc' ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' optimize='-O2' cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include' ccversion='' gccversion='5.4.0 20160609' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='cc' ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.23.so so=so useshrplib=false libperl=libperl.a gnulibc_version='2.23' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong' Locally applied patches: 51546e694f27021eb4575199846bb732ffabb4e4 0c9f8ff766e576469d0c6e93526150ca7c18a0a3 9165d5d1874c0eaf7ce6e31de47f26b2a2da8df3 d98a8304d1105624823d312a03576c4fb9bec372 @INC for perl 5.27.8: lib /usr/local/lib/perl5/site_perl/5.27.8/x86_64-linux /usr/local/lib/perl5/site_perl/5.27.8 /usr/local/lib/perl5/5.27.8/x86_64-linux /usr/local/lib/perl5/5.27.8 Environment for perl 5.27.8: HOME=/home/someuser LANG=ru_RU.UTF-8 LANGUAGE=ru_RU LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/someuser/bin:/home/someuser/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 6 years ago

From dctabuyz@yandex.ru

0004-perlfaq9-fixed-broken-links-in-examples-tiny-code-up.patch ```diff From c24c1a96c2c42e8e217b4a0f177acefe5c31422b Mon Sep 17 00:00:00 2001 From: dctabuyz Date: Mon, 8 Jan 2018 23:17:04 +0500 Subject: [PATCH 4/4] perlfaq9: fixed broken links in examples, tiny code update --- cpan/perlfaq/lib/perlfaq9.pod | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpan/perlfaq/lib/perlfaq9.pod b/cpan/perlfaq/lib/perlfaq9.pod index 7fca820..07ba404 100644 --- a/cpan/perlfaq/lib/perlfaq9.pod +++ b/cpan/perlfaq/lib/perlfaq9.pod @@ -131,8 +131,8 @@ the form using the C method: use LWP::Simple; use URI::URL; - my $url = url('L; - $url->query_form(module => 'DB_File', readme => 1); + my $url = url('https://metacpan.org/search'); + $url->query_form(q => 'DB_File', lucky => 1); $content = get($url); If you're using the POST method, create your own user agent and encode @@ -142,9 +142,10 @@ the content appropriately. use LWP::UserAgent; my $ua = LWP::UserAgent->new(); - my $req = POST 'L, - [ module => 'DB_File', readme => 1 ]; - my $content = $ua->request($req)->as_string; + my $req = POST 'https://metacpan.org/search', + [ q => 'DB_File', lucky => 1 ]; + push @{ $ua->requests_redirectable }, 'POST'; + my $content = $ua->request($req)->content; =head2 How do I decode or create those %-encodings on the web? X X X -- 2.7.4 ```
p5pRT commented 6 years ago

From dctabuyz@yandex.ru

0003-perlfaq3-link-to-Vile-updated-301-redirect-for-the-o.patch ```diff From c0e294362a9229452cb4df4faeecd40968634234 Mon Sep 17 00:00:00 2001 From: dctabuyz Date: Mon, 8 Jan 2018 22:56:09 +0500 Subject: [PATCH 3/4] perlfaq3: link to Vile updated (301 redirect for the old one) --- cpan/perlfaq/lib/perlfaq3.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpan/perlfaq/lib/perlfaq3.pod b/cpan/perlfaq/lib/perlfaq3.pod index 8c85ecb..b28bece 100644 --- a/cpan/perlfaq/lib/perlfaq3.pod +++ b/cpan/perlfaq/lib/perlfaq3.pod @@ -497,7 +497,7 @@ L =item Vile -L +L =back -- 2.7.4 ```
p5pRT commented 6 years ago

From dctabuyz@yandex.ru

0002-perlfaq3-broken-link-to-Profiling-Perl-article-fixed.patch ```diff From 3f2ad9299ecb442000765fbf2a10eb11c94d68c5 Mon Sep 17 00:00:00 2001 From: dctabuyz Date: Mon, 8 Jan 2018 22:54:42 +0500 Subject: [PATCH 2/4] perlfaq3: broken link to "Profiling Perl" article fixed --- cpan/perlfaq/lib/perlfaq3.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpan/perlfaq/lib/perlfaq3.pod b/cpan/perlfaq/lib/perlfaq3.pod index ce714d8..8c85ecb 100644 --- a/cpan/perlfaq/lib/perlfaq3.pod +++ b/cpan/perlfaq/lib/perlfaq3.pod @@ -300,8 +300,8 @@ L , and "Profiling in Perl" L . Perl.com has two interesting articles on profiling: "Profiling Perl", -by Simon Cozens, L and "Debugging and -Profiling mod_perl Applications", by Frank Wiles, +by Simon Cozens, L +and "Debugging and Profiling mod_perl Applications", by Frank Wiles, L . Randal L. Schwartz writes about profiling in "Speeding up Your Perl -- 2.7.4 ```
p5pRT commented 6 years ago

From dctabuyz@yandex.ru

0001-perlfaq3-broken-links-to-Tom-Christiansen-s-archives.patch ```diff From ada762b676a08ca2b07382dd7fbd0319b71ef1c7 Mon Sep 17 00:00:00 2001 From: dctabuyz Date: Mon, 8 Jan 2018 22:51:43 +0500 Subject: [PATCH 1/4] perlfaq3: broken links to Tom Christiansen's archives fixed --- cpan/perlfaq/lib/perlfaq3.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpan/perlfaq/lib/perlfaq3.pod b/cpan/perlfaq/lib/perlfaq3.pod index dcab664..ce714d8 100644 --- a/cpan/perlfaq/lib/perlfaq3.pod +++ b/cpan/perlfaq/lib/perlfaq3.pod @@ -340,7 +340,7 @@ Put that in your F<.exrc> file (replacing the caret characters with control characters) and away you go. In insert mode, ^T is for indenting, ^D is for undenting, and ^O is for blockdenting--as it were. A more complete example, with comments, can be found at -L +L =head2 Is there an IDE or Windows Perl Editor? @@ -558,7 +558,7 @@ are text editors for OS X that have a Perl sensitivity mode =head2 Where can I get Perl macros for vi? For a complete version of Tom Christiansen's vi configuration file, -see L , +see L , the standard benchmark file for vi emulators. The file runs best with nvi, the current version of vi out of Berkeley, which incidentally can be built with an embedded Perl interpreter--see L . @@ -581,7 +581,7 @@ For CPerlMode, see L The Curses module from CPAN provides a dynamically loadable object module interface to a curses library. A small demo can be found at the -directory L ; +directory L ; this program repeats a command and updates the screen as needed, rendering B similar to B. -- 2.7.4 ```
p5pRT commented 6 years ago

From @jkeenan

On Mon\, 08 Jan 2018 19​:05​:54 GMT\, dctabuyz@​yandex.ru wrote​:

This is a bug report for perl from dctabuyz@​yandex.ru\, generated with the help of perlbug 1.41 running under perl 5.27.8.

----------------------------------------------------------------- there are some broken links in perlfaq\, some of them i've fixed\, some of them are not fixed because it is not clear for me how to do it right

links fixed​:

perlfaq3​:

http​://www.cpan.org/authors/id/TOMC/scripts/toms.exrc.gz http​://www.cpan.org/authors/Tom_Christiansen/scripts/rep.gz http​://www.cpan.org/authors/Tom_Christiansen/scripts/toms.exrc.gz

http​://dickey.his.com/vile/vile.html

http​://www.perl.com/lpt/a/850

perlfaq9​: http​://www.perl.com/cgi-bin/cpan_mod

links NOT fixed​:

http​://perl-zeitung.at.tf (connection timeout) http​://par.perl.org/ (NXDOMAIN) http​://www.solutionsoft.com/perl.htm (NXDOMAIN) http​://www.fastcgi.com/ (connection timeout\, seems not supported anymore​: https://redd.it/4bywjn)

http​://web.cse.msu.edu/~cse320/Documents/FloatingPoint.pdf (not found\, accessible via webarchive)

Thank you very much for preparing these patches. perlfaq is maintained upstream on CPAN\, so change requests must go there first. It appears that perlfaq uses github rather than rt.cpan.org as its bug tracker\, so I have opened this issue​:

https://github.com/perl-doc-cats/perlfaq/issues/71

Because github.com does not accept file attachments ending in '.patch'\, I was unable to attach your patches to that issue. Instead\, I included links to them inline in the issue message. Please communicate with the perlfaq maintainers via that issue. After the patches are applied upstream\, we will merge them into Perl 5 blead.

Thank you very much.

-- James E Keenan (jkeenan@​cpan.org)

p5pRT commented 6 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 6 years ago

@jkeenan - Status changed from 'open' to 'resolved'