Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.91k stars 542 forks source link

Constants/vars changing type after comparison #17078

Open p5pRT opened 5 years ago

p5pRT commented 5 years ago

Migrated from rt.perl.org#134261 (status was 'open')

Searchable as RT134261$

p5pRT commented 5 years ago

From david@pgbackrest.org

Created by david@pgbackrest.org

In the following versions of Perl​:

This is perl\, v5.10.1 (*) built for x86_64-linux-thread-multi (CentOS 6) This is perl 5\, version 14\, subversion 2 (v5.14.2) built for i686-linux-gnu-thread-multi-64int (Ubuntu 12.04) This is perl 5\, version 16\, subversion 3 (v5.16.3) built for x86_64-linux-thread-multi (CentOS 7) This is perl 5\, version 26\, subversion 1 (v5.26.1) built for x86_64-linux-gnu-thread-multi (Ubuntu 18.04)

This code fragment​:

------------------------

#!/usr/bin/perl use strict; use warnings FATAL => qw(all);

use JSON​::PP; use Scalar​::Util qw(reftype);

use constant VERSION => '9.1';

print("constant in JSON before comparison is " . JSON​::PP->new()->allow_nonref()->encode(VERSION) . "\n");

if (VERSION > 9.0) {   print("constant in JSON after comparison is " . JSON​::PP->new()->allow_nonref()->encode(VERSION) . "\n"); }

my $version = '9.2';

print("var in JSON before comparison is " . JSON​::PP->new()->allow_nonref()->encode($version) . "\n");

if ($version > 9.1) {   print("var in JSON after comparison is " . JSON​::PP->new()->allow_nonref()->encode($version) . "\n"); }

------------------------

Returns​:

$ ./bug.pl constant in JSON before comparison is "9.1" constant in JSON after comparison is "9.1" var in JSON before comparison is "9.2" var in JSON after comparison is "9.2"

But in "This is perl 5\, version 28\, subversion 2 (v5.28.2) built for x86_64-linux-thread-multi" (Fedora 30) it returns​:

$ ./bug.pl constant in JSON before comparison is 9.1 constant in JSON after comparison is 9.1 var in JSON before comparison is "9.2" var in JSON after comparison is 9.2

vagrant@​pgbackrest-test​:\~$ docker exec -it test-0 perl -v

This behavioral difference causes some interesting issues in our project. We have "fixed" them by appending '' when passing the var to JSON\, but hoping there is a more elegant fix and wondering if this could be a bug.

We have been unable to find a specific issue or release note that explains this behavior.

perl -V output below​:

This is perl 5\, version 28\, subversion 2 (v5.28.2) built for x86_64-linux-thread-multi (with 48 registered patches\, see perl -V for more detail)

Copyright 1987-2019\, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the GNU General Public License\, which may be found in the Perl 5 source kit.

Complete documentation for Perl\, including FAQ lists\, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet\, point your browser at http​://www.perl.org/\, the Perl Home Page.

vagrant@​pgbackrest-test​:\~$ docker exec -it test-0 perl -V Summary of my perl5 (revision 5 version 28 subversion 2) configuration​:

  Platform​:   osname=linux   osvers=5.0.6-200.fc29.x86_64   archname=x86_64-linux-thread-multi   uname='linux buildvm-07.phx2.fedoraproject.org 5.0.6-200.fc29.x86_64 #1 smp wed apr 3 15​:09​:51 utc 2019 x86_64 x86_64 x86_64 gnulinux '   config_args='-des -Doptimize=none -Dccflags=-O2 -g -pipe -Wall -Werror=format-security -Wp\,-D_FORTIFY_SOURCE=2 -Wp\,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Dldflags=-Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Dccdlflags=-Wl\,--enable-new-dtags -Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Dlddlflags=-shared -Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Dshrpdir=/usr/lib64 -DDEBUGGING=-g -Dversion=5.28.2 -Dmyhostname=localhost -Dperladmin=root@​localhost -Dcc=gcc -Dcf_by=Red Hat\, Inc. -Dprefix=/usr -Dvendorprefix=/usr -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl5 -Dsitearch=/usr/local/lib64/perl5 -Dprivlib=/usr/share/perl5 -Dvendorlib=/usr/share/perl5/vendor_perl -Darchlib=/usr/lib64/perl5 -Dvendorarch=/usr/lib64/perl5/vendor_perl -Darchname=x86_64-linux-thread-multi -Dlibpth=/usr/local/lib64 /lib64 /usr/lib64 -Duseshrplib -Dusethreads -Duseithreads -Dusedtrace=/usr/bin/dtrace -Duselargefiles -Dd_semctl_semun -Di_db -Ui_ndbm -Di_gdbm -Di_shadow -Di_syslog -Dman3ext=3pm -Duseperlio -Dinstallusrbinperl=n -Ubincompat5005 -Uversiononly -Dpager=/usr/bin/less -isr -Dd_gethostent_r_proto -Ud_endhostent_r_proto -Ud_sethostent_r_proto -Ud_endprotoent_r_proto -Ud_setprotoent_r_proto -Ud_endservent_r_proto -Ud_setservent_r_proto -Dscriptdir=/usr/bin -Dusesitecustomize -Duse64bitint'   hint=recommended   useposix=true   d_sigaction=define   useithreads=define   usemultiplicity=define   use64bitint=define   use64bitall=define   uselongdouble=undef   usemymalloc=n   default_inc_excludes_dot=define   bincompat5005=undef   Compiler​:   cc='gcc'   ccflags ='-D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Werror=format-security -Wp\,-D_FORTIFY_SOURCE=2 -Wp\,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'   optimize=' -g'   cppflags='-D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Werror=format-security -Wp\,-D_FORTIFY_SOURCE=2 -Wp\,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/include'   ccversion=''   gccversion='9.0.1 20190312 (Red Hat 9.0.1-0.10)'   gccosandvers=''   intsize=4   longsize=8   ptrsize=8   doublesize=8   byteorder=12345678   doublekind=3   d_longlong=define   longlongsize=8   d_longdbl=define   longdblsize=16   longdblkind=3   ivtype='long'   ivsize=8   nvtype='double'   nvsize=8   Off_t='off_t'   lseeksize=8   alignbytes=8   prototype=define   Linker and Libraries​:   ld='gcc'   ldflags ='-Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fstack-protector-strong -L/usr/local/lib'   libpth=/usr/local/lib64 /lib64 /usr/lib64 /usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib   libs=-lpthread -lresolv -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat   perllibs=-lpthread -lresolv -ldl -lm -lcrypt -lutil -lc   libc=libc-2.29.so   so=so   useshrplib=true   libperl=libperl.so   gnulibc_version='2.29'   Dynamic Linking​:   dlsrc=dl_dlopen.xs   dlext=so   d_dlsymun=undef   ccdlflags='-Wl\,--enable-new-dtags -Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'   cccdlflags='-fPIC'   lddlflags='-lpthread -shared -Wl\,-z\,relro -Wl\,--as-needed -Wl\,-z\,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:   Compile-time options​:   HAS_TIMES   MULTIPLICITY   PERLIO_LAYERS   PERL_COPY_ON_WRITE   PERL_DONT_CREATE_GVSV   PERL_IMPLICIT_CONTEXT   PERL_MALLOC_WRAP   PERL_OP_PARENT   PERL_PRESERVE_IVUV   USE_64_BIT_ALL   USE_64_BIT_INT   USE_ITHREADS   USE_LARGE_FILES   USE_LOCALE   USE_LOCALE_COLLATE   USE_LOCALE_CTYPE   USE_LOCALE_NUMERIC   USE_LOCALE_TIME   USE_PERLIO   USE_PERL_ATOF   USE_REENTRANT_API   USE_SITECUSTOMIZE   Locally applied patches​:   Fedora Patch1​: Removes date check\, Fedora/RHEL specific   Fedora Patch2​: support for libdir64   Fedora Patch3​: use libresolv instead of libbind   Fedora Patch4​: USE_MM_LD_RUN_PATH   Fedora Patch5​: Provide MM​::maybe_command independently (bug #1129443)   Fedora Patch6​: Dont run one io test due to random builder failures   Fedora Patch8​: Define SONAME for libperl.so   Fedora Patch9​: Install libperl.so to -Dshrpdir value   Fedora Patch10​: Document Math​::BigInt​::CalcEmu requires Math​::BigInt (CPAN RT#85015)   Fedora Patch11​: Make *DBM_File desctructors thread-safe (RT#61912)   Fedora Patch12​: Replace EU​::MakeMaker dependency with EU​::MM​::Utils in IPC​::Cmd (bug #1129443)   Fedora Patch13​: Fix executing arybase​::_tie_it() in Safe compartement (RT#131588)   Fedora Patch14​: Link XS modules to pthread library to fix linking with -z defs   Fedora Patch17​: Fix printing a warning about a wide character when matching a regular expression while ISO-8859-1 locale is in effect   Fedora Patch18​: Fix invoking a check for wide characters while ISO-8859-1 locale is in effect   Fedora Patch20​: Fix build conditions in locale.c   Fedora Patch21​: Fix a file descriptor leak in in-place edits (RT#133314)   Fedora Patch23​: Fix a buffer overrun in deprecated S_is_utf8_common()   Fedora Patch24​: Fix a time race in Time-HiRes/t/itimer.t test   Fedora Patch26​: Fix Time​::Piece to handle objects in overloaded methods correctly   Fedora Patch27​: Fix an assignment to a lexical variable in multiconcatenation expressions (RT#133441)   Fedora Patch28​: Fix a spurious warning about uninitialized value in warn (RT#132683)   Fedora Patch30​: Pass the correct CFLAGS to dtrace   Fedora Patch33​: Fix PathTools tests to cope with ESTALE error (RT#133534)   Fedora Patch34​: Fix an undefined behaviour in S_hv_delete_common()   Fedora Patch38​: Fix compiling regular expressions that contain both compile- and run-time compiled code blocks (RT#133687)   Fedora Patch39​: Adjust tests to gdbm-1.15 (RT#133295)   Fedora Patch44​: Fix reporting a line number for non-terminated prototypes (RT#133524)   Fedora Patch45​: Fix first eof() return value (RT#133721)   Fedora Patch49​: Prevent long jumps from clobbering local variables (RT#133575)   Fedora Patch50​: Fix a mismatch with a case-insesitive regular expression on a text with ligatures (RT#133756)   Fedora Patch53​: Fix setting magic when changing $^R (RT#133782)   Fedora Patch54​: Fix a race when loading XS modules   Fedora Patch56​: Fix a leak when compiling a typed hash dereference   Fedora Patch58​: Fix a buffer overread when handling a scope error in qr/\(?{/ (RT#133879)   Fedora Patch59​: Fix a buffer overread when parsing a regular expression with an unknown character name (RT#133880)   Fedora Patch60​: Fix mbstate_t initialization in POSIX​::mblen (RT#133928)   Fedora Patch61​: Fix a memory leak when cloning a regular expression   Fedora Patch62​: Fix a memory leak when spawning threads in a BEGIN phase   Fedora Patch63​: Fix a memory leak when assigning a regular expression to a non-copy-on-write string   Fedora Patch64​: Fix a memory leak when assignig to a localized ${^WARNING_BITS}   Fedora Patch65​: Fix a memory leak when parsing misindented here-documents   Fedora Patch66​: Fix a memory leak in package name lookup (RT#133977)   Fedora Patch68​: Fix a memory leak when deletion in a tied hash dies   Fedora Patch69​: Fix a crash when matching case insensitively (RT#133892)   Fedora Patch70​: Fix a memory leak when warning about malformed UTF-8 string   Fedora Patch200​: Link XS modules to libperl.so with EU​::CBuilder on Linux   Fedora Patch201​: Link XS modules to libperl.so with EU​::MM on Linux   Built under linux   Compiled at Apr 23 2019 08​:24​:20   @​INC​:   /usr/local/lib64/perl5   /usr/local/share/perl5   /usr/lib64/perl5/vendor_perl   /usr/share/perl5/vendor_perl   /usr/lib64/perl5   /usr/share/perl5

Perl Info ``` Flags: category=core severity=high Site configuration information for perl 5.26.1: Configured by Ubuntu at Mon Nov 19 15:54:44 UTC 2018. Summary of my perl5 (revision 5 version 26 subversion 1) configuration: Platform: osname=linux osvers=4.9.0 archname=x86_64-linux-gnu-thread-multi uname='linux localhost 4.9.0 #1 smp debian 4.9.0 x86_64 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=-DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/perl-hx1dVS/perl-5.26.1=. -fstack-protector-strong -Wformat -Werror=format-security -Dldflags= -Wl,-Bsymbolic-functions -Wl,-z,relro -Dlddlflags=-shared -Wl,-Bsymbolic-functions -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.26 -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.26 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux-gnu/perl5/5.26 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.26.1 -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.26.1 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -Ui_xlocale -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib -Dlibperl=libperl.so.5.26.1' hint=recommended useposix=true d_sigaction=define useithreads=define usemultiplicity=define use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='x86_64-linux-gnu-gcc' ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' optimize='-O2 -g' cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='' gccversion='7.3.0' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='x86_64-linux-gnu-gcc' ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=libc-2.27.so so=so useshrplib=true libperl=libperl.so.5.26 gnulibc_version='2.27' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -L/usr/local/lib -fstack-protector-strong' Locally applied patches: DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS default for modules installed from CPAN. DEBPKG:debian/db_file_ver - https://bugs.debian.org/340047 Remove overly restrictive DB_File version check. DEBPKG:debian/doc_info - Replace generic man(1) instructions with Debian-specific information. DEBPKG:debian/enc2xs_inc - https://bugs.debian.org/290336 Tweak enc2xs to follow symlinks and ignore missing @INC directories. DEBPKG:debian/errno_ver - https://bugs.debian.org/343351 Remove Errno version check due to upgrade problems with long-running processes. DEBPKG:debian/libperl_embed_doc - https://bugs.debian.org/186778 Note that libperl-dev package is required for embedded linking DEBPKG:fixes/respect_umask - Respect umask during installation DEBPKG:debian/writable_site_dirs - Set umask approproately for site install directories DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of libperl.a under /usr/lib DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or perllocal.pod for perl or vendor DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to the binary targets. DEBPKG:debian/instmodsh_doc - Debian policy doesn't install .packlist files for core or vendor. DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH as per Debian policy. DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to /etc/perl/Net as /usr may not be writable. DEBPKG:debian/perlivp - https://bugs.debian.org/510895 Make perlivp skip include directories in /usr/local DEBPKG:debian/deprecate-with-apt - https://bugs.debian.org/747628 Point users to Debian packages of deprecated core modules DEBPKG:debian/squelch-locale-warnings - https://bugs.debian.org/508764 Squelch locale warnings in Debian package maintainer scripts DEBPKG:debian/patchlevel - https://bugs.debian.org/567489 List packaged patches for 5.26.1-6ubuntu0.3 in patchlevel.h DEBPKG:fixes/document_makemaker_ccflags - https://bugs.debian.org/628522 [rt.cpan.org #68613] Document that CCFLAGS should include $Config{ccflags} DEBPKG:debian/find_html2text - https://bugs.debian.org/640479 Configure CPAN::Distribution with correct name of html2text DEBPKG:debian/perl5db-x-terminal-emulator.patch - https://bugs.debian.org/668490 Invoke x-terminal-emulator rather than xterm in perl5db.pl DEBPKG:debian/cpan-missing-site-dirs - https://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with nonexisting site dirs if a parent is writable DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] https://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' option not respected DEBPKG:debian/makemaker-pasthru - https://bugs.debian.org/758471 Pass LD settings through to subdirectories DEBPKG:debian/makemaker-manext - https://bugs.debian.org/247370 Make EU::MakeMaker honour MANnEXT settings in generated manpage headers DEBPKG:debian/kfreebsd-softupdates - https://bugs.debian.org/796798 Work around Debian Bug#796798 DEBPKG:fixes/autodie-scope - https://bugs.debian.org/798096 Fix a scoping issue with "no autodie" and the "system" sub DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in Memoize DEBPKG:debian/hurd-softupdates - https://bugs.debian.org/822735 Fix t/op/stat.t failures on hurd DEBPKG:fixes/math_complex_doc_great_circle - https://bugs.debian.org/697567 [rt.cpan.org #114104] Math::Trig: clarify definition of great_circle_midpoint DEBPKG:fixes/math_complex_doc_see_also - https://bugs.debian.org/697568 [rt.cpan.org #114105] Math::Trig: add missing SEE ALSO DEBPKG:fixes/math_complex_doc_angle_units - https://bugs.debian.org/731505 [rt.cpan.org #114106] Math::Trig: document angle units DEBPKG:fixes/cpan_web_link - https://bugs.debian.org/367291 CPAN: Add link to main CPAN web site DEBPKG:fixes/time_piece_doc - https://bugs.debian.org/817925 Time::Piece: Improve documentation for add_months and add_years DEBPKG:fixes/extutils_makemaker_reproducible - https://bugs.debian.org/835815 https://bugs.debian.org/834190 Make perllocal.pod files reproducible DEBPKG:fixes/file_path_hurd_errno - File-Path: Fix test failure in Hurd due to hard-coded ENOENT DEBPKG:debian/hppa_op_optimize_workaround - https://bugs.debian.org/838613 Temporarily lower the optimization of op.c on hppa due to gcc-6 problems DEBPKG:debian/installman-utf8 - https://bugs.debian.org/840211 Generate man pages with UTF-8 characters DEBPKG:fixes/file_path_chmod_race - https://bugs.debian.org/863870 [rt.cpan.org #121951] Prevent directory chmod race attack. DEBPKG:fixes/extutils_file_path_compat - Correct the order of tests of chmod(). (#294) DEBPKG:fixes/getopt-long-2 - [rt.cpan.org #120300] Withdraw part of commit 5d9947fb445327c7299d8beb009d609bc70066c0, which tries to implement more GNU getopt_long campatibility. GNU DEBPKG:fixes/getopt-long-3 - provide a default value for optional arguments DEBPKG:fixes/getopt-long-4 - https://bugs.debian.org/864544 [rt.cpan.org #122068] Fix issue #122068. DEBPKG:fixes/test-builder-reset - https://bugs.debian.org/865894 Reset inside subtest maintains parent DEBPKG:debian/hppa_opmini_optimize_workaround - https://bugs.debian.org/869122 Lower the optimization level of opmini.c on hppa DEBPKG:debian/sh4_op_optimize_workaround - https://bugs.debian.org/869373 Also lower the optimization level of op.c and opmini.c on sh4 DEBPKG:fixes/json-pp-example - [rt.cpan.org #92793] https://bugs.debian.org/871837 fix RT-92793: bug in SYNOPSIS DEBPKG:debian/perldoc-pager - https://bugs.debian.org/870340 [rt.cpan.org #120229] Fix perldoc terminal escapes when sensible-pager is less DEBPKG:debian/prune_libs - https://bugs.debian.org/128355 Prune the list of libraries wanted to what we actually need. DEBPKG:debian/configure-regen - https://bugs.debian.org/762638 Regenerate Configure et al. after probe unit changes DEBPKG:fixes/rename-filexp.U-phase1 - regen-configure: rename filexp.U to filexp_path.U, phase 1 DEBPKG:fixes/rename-filexp.U-phase2 - regen-configure: rename filexp.U to filexp_path.U, phase 2 DEBPKG:fixes/packaging_test_skips - Skip various tests if PERL_BUILD_PACKAGING is set DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian DEBPKG:fixes/encode-alias-regexp - https://bugs.debian.org/880085 fix https://github.com/dankogai/p5-encode/issues/127 DEBPKG:fixes/regex-memory-leak - [910a6a8] https://bugs.debian.org/891196 [perl #132892] perl #132892: avoid leak by mortalizing temporary copy of pattern DEBPKG:fixes/CVE-2018-6797 - [perl #132227] (perl #132227) restart a node if we change to uni rules within the node and encounter a sharp S DEBPKG:fixes/CVE-2018-6798/pt1 - [perl #132063] Heap buffer overflow DEBPKG:fixes/CVE-2018-6798/pt2 - [perl #132063] 5.26.1: fix TRIE_READ_CHAR and DECL_TRIE_TYPE to account for non-utf8 target DEBPKG:fixes/CVE-2018-6798/pt3 - [perl #132063] (perl #132063) we should no longer warn for this code DEBPKG:fixes/CVE-2018-6798/pt4 - [perl #132063] utf8.c: Don't dump malformation past first NUL DEBPKG:fixes/CVE-2018-6913 - [perl #131844] (perl #131844) fix various space calculation issues in pp_pack.c DEBPKG:fixes/CVE-2018-12015.patch - [PATCH] [PATCH] Remove existing files before overwriting them DEBPKG:fixes/CVE-2018-18311.patch - [PATCH] Perl_my_setenv(); handle integer wrap DEBPKG:fixes/CVE-2018-18312.patch - [PATCH 242/242] PATCH: [perl #133423] for 5.26 maint DEBPKG:fixes/CVE-2018-18313.patch - [PATCH] regcomp.c: Convert some strchr to memchr DEBPKG:fixes/CVE-2018-18314.patch - [PATCH] fix #131649 - extended charclass can trigger assert @INC for perl 5.26.1: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.1 /usr/local/share/perl/5.26.1 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base Environment for perl 5.26.1: HOME=/home/vagrant LANG=C.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 5 years ago

From @iabyn

On Wed\, Jul 03\, 2019 at 01​:00​:49PM -0700\, David Steele (via RT) wrote​:

$ ./bug.pl constant in JSON before comparison is "9.1" constant in JSON after comparison is "9.1" var in JSON before comparison is "9.2" var in JSON after comparison is "9.2"

But in "This is perl 5\, version 28\, subversion 2 (v5.28.2) built for x86_64-linux-thread-multi" (Fedora 30) it returns​:

$ ./bug.pl constant in JSON before comparison is 9.1 constant in JSON after comparison is 9.1 var in JSON before comparison is "9.2" var in JSON after comparison is 9.2

Its not clear in your report which behaviours you consider buggy in which versions of perl.

Are all the outputs in the first run above "correct"\, while any outputs in the second run which differ from the first are incorrect???

-- The optimist believes that he lives in the best of all possible worlds. As does the pessimist.

p5pRT commented 5 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 5 years ago

From david@pgbackrest.org

Hi Dave\,

On 7/4/19 3​:36 AM\, Dave Mitchell via RT wrote​:

On Wed\, Jul 03\, 2019 at 01​:00​:49PM -0700\, David Steele (via RT) wrote​:

$ ./bug.pl constant in JSON before comparison is "9.1" constant in JSON after comparison is "9.1" var in JSON before comparison is "9.2" var in JSON after comparison is "9.2"

But in "This is perl 5\, version 28\, subversion 2 (v5.28.2) built for x86_64-linux-thread-multi" (Fedora 30) it returns​:

$ ./bug.pl constant in JSON before comparison is 9.1 constant in JSON after comparison is 9.1 var in JSON before comparison is "9.2" var in JSON after comparison is 9.2

Its not clear in your report which behaviours you consider buggy in which versions of perl.

I consider the new behavior in 5.28 to be buggy -- or at least a significant behavioral change.

Are all the outputs in the first run above "correct"\, while any outputs in the second run which differ from the first are incorrect???

Yes -- the range of Perls (5.10 - 5.26) represent all the versions we currently test on and exhibit the first behavior. The behavior of 5.28 differs and has caused some breakage in our code base.

It appears strings are being converted to numbers after a comparison to a number\, at least from the perspective of JSON. This seems odd at the least and certainly represents a behavior change from the last eleven years of Perl versions.

Regards\, -- -David david@​pgbackrest.org

p5pRT commented 5 years ago

From @grinnz

On Thu\, 04 Jul 2019 09​:33​:40 -0700\, david@​pgbackrest.org wrote​:

Hi Dave\,

On 7/4/19 3​:36 AM\, Dave Mitchell via RT wrote​:

On Wed\, Jul 03\, 2019 at 01​:00​:49PM -0700\, David Steele (via RT) wrote​:

$ ./bug.pl constant in JSON before comparison is "9.1" constant in JSON after comparison is "9.1" var in JSON before comparison is "9.2" var in JSON after comparison is "9.2"

But in "This is perl 5\, version 28\, subversion 2 (v5.28.2) built for x86_64-linux-thread-multi" (Fedora 30) it returns​:

$ ./bug.pl constant in JSON before comparison is 9.1 constant in JSON after comparison is 9.1 var in JSON before comparison is "9.2" var in JSON after comparison is 9.2

Its not clear in your report which behaviours you consider buggy in which versions of perl.

I consider the new behavior in 5.28 to be buggy -- or at least a significant behavioral change.

Are all the outputs in the first run above "correct"\, while any outputs in the second run which differ from the first are incorrect???

Yes -- the range of Perls (5.10 - 5.26) represent all the versions we currently test on and exhibit the first behavior. The behavior of 5.28 differs and has caused some breakage in our code base.

It appears strings are being converted to numbers after a comparison to a number\, at least from the perspective of JSON. This seems odd at the least and certainly represents a behavior change from the last eleven years of Perl versions.

Regards\,

JSON​::PP is maintained on CPAN so that is probably a better place to discuss this. This was an intentional change in JSON​::PP 2.92 to detect numbers better in the usual case\, but of course with the lack of typing in Perl\, there is no foolproof solution\, these are all heuristics. The benefit of the new detection heuristic is the opposite direction​: numbers don't suddenly become strings because you interpolated them in a string or printed them.

* https://metacpan.org/source/ISHIGAKI/JSON-PP-4.04/Changes#L70-72

-Dan

p5pRT commented 5 years ago

From @grinnz

On Thu\, 04 Jul 2019 10​:00​:12 -0700\, grinnz@​gmail.com wrote​:

JSON​::PP is maintained on CPAN so that is probably a better place to discuss this. This was an intentional change in JSON​::PP 2.92 to detect numbers better in the usual case\, but of course with the lack of typing in Perl\, there is no foolproof solution\, these are all heuristics. The benefit of the new detection heuristic is the opposite direction​: numbers don't suddenly become strings because you interpolated them in a string or printed them.

* https://metacpan.org/source/ISHIGAKI/JSON-PP-4.04/Changes#L70-72

As an addendum\, you might consider Cpanel​::JSON​::XS​::Type as a way to declare types for your JSON output and avoid relying on heuristics if it's important.

-Dan

p5pRT commented 5 years ago

From david@pgbackrest.org

Hi Dan\,

On 7/4/19 1​:00 PM\, Dan Book via RT wrote​:

On Thu\, 04 Jul 2019 09​:33​:40 -0700\, david@​pgbackrest.org wrote​:

It appears strings are being converted to numbers after a comparison to a number\, at least from the perspective of JSON. This seems odd at the least and certainly represents a behavior change from the last eleven years of Perl versions.

Regards\,

JSON​::PP is maintained on CPAN so that is probably a better place to discuss this. This was an intentional change in JSON​::PP 2.92 to detect numbers better in the usual case\, but of course with the lack of typing in Perl\, there is no foolproof solution\, these are all heuristics. The benefit of the new detection heuristic is the opposite direction​: numbers don't suddenly become strings because you interpolated them in a string or printed them.

Hmm\, OK. Still seems odd that the output varies based on whether a numeric comparison has been performed or not\, but I have installed JSON​::PP 2.97 on Perl 5.26 and confirmed that the behavior is related to the JSON​:PP version.

This drives our unit tests nuts because we have always treated version numbers as strings\, but now they may be output as strings or numbers depending on which code paths are followed in the particular test.

Thanks for pointing me in the right direction.

Regards\, -- -David david@​pgbackrest.org

p5pRT commented 5 years ago

From david@pgbackrest.org

Hi Dan\,

On 7/4/19 1​:01 PM\, Dan Book via RT wrote​:

On Thu\, 04 Jul 2019 10​:00​:12 -0700\, grinnz@​gmail.com wrote​:

JSON​::PP is maintained on CPAN so that is probably a better place to discuss this. This was an intentional change in JSON​::PP 2.92 to detect numbers better in the usual case\, but of course with the lack of typing in Perl\, there is no foolproof solution\, these are all heuristics. The benefit of the new detection heuristic is the opposite direction​: numbers don't suddenly become strings because you interpolated them in a string or printed them.

* https://metacpan.org/source/ISHIGAKI/JSON-PP-4.04/Changes#L70-72

As an addendum\, you might consider Cpanel​::JSON​::XS​::Type as a way to declare types for your JSON output and avoid relying on heuristics if it's important.

Thanks for the tip!

We're currently migrating off Perl so I don't want to introduce a new module at this point\, even assuming it is packaged for all the platforms we support.

Appending '' seems to be working fine in testing so we'll go with that until the migration is complete in a few months.

Regards\, -- -David david@​pgbackrest.org

dwsteele commented 4 years ago

We have completed our migration off of Perl so we are no longer affected by this issue. Feel free to close it.