Closed djerius closed 3 years ago
djerius
commented
4 years ago Further note, since I can't replicate this outside of the one host, I can only raise this as a concern, so that if you do see other bug reports there's some added history.
Unless File::Find does a run-time test to see if directory link counts are accurate indications of the number of directories, I don't see much that can be done.
Grinnz
commented
4 years ago $File::Find::dont_use_nlink always defaults to 1 since Perl 5.30. On older Perls you can set this manually. See https://perldoc.perl.org/File::Find#CAVEAT and https://github.com/perl/perl5/issues/16759.
Leont
commented
4 years ago $File::Find::dont_use_nlink always defaults to 1 since Perl 5.30. On older Perls you can set this manually. See https://perldoc.perl.org/File::Find#CAVEAT and #16759.
Yeah, it was an optimization that kept biting us in the tail
djerius
commented
4 years ago The incorrect directory link count was caused by a mis-configured system.
Anyway, glad to hear that had I upgraded to 5.30 I wouldn't have had this problem (but then I wouldn't have fixed the underlying problem).
jkeenan
commented
3 years ago The incorrect directory link count was caused by a mis-configured system.
Anyway, glad to hear that had I upgraded to 5.30 I wouldn't have had this problem (but then I wouldn't have fixed the underlying problem).
If I understand the comments in this ticket correctly, the original problem is not a problem in supported versions of Perl. Hence, this ticket should be closable. Comments?
Thank you very much. Jim Keenan
jkeenan
commented
3 years ago The incorrect directory link count was caused by a mis-configured system. Anyway, glad to hear that had I upgraded to 5.30 I wouldn't have had this problem (but then I wouldn't have fixed the underlying problem).
If I understand the comments in this ticket correctly, the original problem is not a problem in supported versions of Perl. Hence, this ticket should be closable. Comments?
No one has indicated this is not closable and no one has commented further. Closing ticket.
Thank you very much. Jim Keenan
karenetheridge
commented
3 years ago Anyway, glad to hear that had I upgraded to 5.30 I wouldn't have had this problem (but then I wouldn't have fixed the underlying problem).
You don't need to upgrade to perl 5.30 -- all you need to do is update File::Find to at least version 1.35 (it's available separately on cpan), or set local $File::Find::dont_use_link = 1; before using File::Find functions.
Module: File::Find
Description
tldr;
File::Findto believe either that there are no subdirectories (if nlinks==2) or that there are fewer subdirectories present, producing incorrect results.Caveats
Steps to Reproduce As mentioned above, I've found it hard to duplicate, but here's my setup. The Dockerfile:
At the command line:
The link count is 3. `
Note that
File::Finddescends into the apt directory. Now, modify the directoryThe link count has decreased from 3 to 2.
and
File::Findno longer descends into aptAnalysis
File::Findmay use the link count of a directory to determine the number of subdirectories. This is controlled by the $File::Find::dont_use_nlink variable, which depends upon a configuration variable:(From
File::Findversion 1.34). On Debian 10,Later, in
_find_dir, the link count to the directory is used to determine if there are any subdirectories, as well as the number of subdirectories. As Perl is configured to trust the link count, the revised link count of 2 after adding the file to the directory convincesFile::Findthat there are no subdirectories, when in fact there are.Expected behavior
I expect File::Find to traverse all of the subdirectories
Perl configuration