search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.88k stars 530 forks source link

[doc] correction for perl 7 faq page #18527

Closed wchristian closed 3 years ago

wchristian commented 3 years ago

Please integrate this correction into the Perl 7 FAQ page: https://github.com/wchristian/perl5_wiki/commit/dc0cda7ca311da4d25ac32ba18631a4129d1c21d

(I'd have preferred to do a normal PR, but this isn't supported for wiki pages.)

Here's the local wiki page: https://github.com/Perl/perl5/wiki/Perl7-FAQ

leonerd commented 3 years ago

LGTM.

Anyone else want to comment?

atoomic commented 3 years ago

Looks good to me too

karenetheridge commented 3 years ago

the repository for the wiki is git@github.com:Perl/perl5.wiki.git

edit.. but it looks like https://github.com/Perl/perl5.wiki does not work, alas... so you can only make branches, not PRs...

leonerd commented 3 years ago

So, at this point I'm happy to do "the thing" to apply this; I'm just unclear on what "the thing" is. Can someone enlighten me?

karenetheridge commented 3 years ago

@leonerd I would make the commit on the command line against git@github.com:Perl/perl5.wiki.git in the master branch.

wchristian commented 3 years ago

Thanks y'all.

And yeah, what ether says, either checkout the perl5 wiki repo and edit that, then push. (Maybe using my repo as a remote in the local checkout as well.) Or just pasting the text into the wiki's browser interface.

karenetheridge commented 3 years ago

done, in commit 02fc81953e9d.