search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 524 forks source link

functionise and simplify TRIE_BITMAP_SET_FOLDED #22114

Closed iabyn closed 4 weeks ago

iabyn commented 1 month ago

These two commits turn the private TRIE_BITMAP_SET_FOLDED() macro into a static function and then simplify it a bit, mainly in a quest to silence a Coverity warning.

iabyn commented 4 weeks ago

Added the suggested code comments and merged.

iabyn commented 4 weeks ago

On Tue, Apr 02, 2024 at 03:03:18AM -0700, Yves Orton wrote:

IMO it shouldn't be called uvc when this is a function.

Now fixed up with v5.39.9-28-ga73aa540c8.

-- If life gives you lemons, you'll probably develop a citric acid allergy.

khwilliamson commented 4 weeks ago

Note that the added comment is wrong w.r.t. EBCDIC. The first byte is neither C2 nor C3

iabyn commented 4 weeks ago

On Tue, Apr 02, 2024 at 09:02:25AM -0700, Karl Williamson wrote:

Note that the added comment is wrong w.r.t. EBCDIC. The first byte is neither C2 nor C3

Sigh! Fixed up with v5.39.9-29-gbcd28b1883.

-- Any [programming] language that doesn't occasionally surprise the novice will pay for it by continually surprising the expert. -- Larry Wall