search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

podlators: load PerlIO before trying to use its functions #22165

Closed xenu closed 3 weeks ago

xenu commented 3 weeks ago

Cherry-picked from https://github.com/rra/podlators/pull/28

Since it's a cherry-pick, podlators was marked as CUSTOMIZED and its version was bumped.

Fixes #21841

Leont commented 3 weeks ago

The fix looks good to me, but I'd like it if someone commits to uncustomizing things after 5.40 comes out. This step is often forgotten (or done incompletely) creating extra work later when someone has to figure out what's going on.

Leont commented 3 weeks ago

An alternative solution may be to release a 4.15 release with only this fix (that wouldn't be indexed as it's version is lower than the current highest), and sync that to blead.

Leont commented 2 weeks ago

This is causing the following warning in MakeMaker

Argument "5.01_01" isn't numeric in numeric ge (>=) at /home/leont/perl5/perlbrew/perls/perl-5.39.10/lib/5.39.10/ExtUtils/Command/MM.pm line 127.

That line does

delete $options{utf8} unless $Pod::Man::VERSION >= 2.17;

Either we need to include version evals on the podlator sites, or it needs to call the VERSION method on that line. Or both.

mauke commented 2 weeks ago

I don't think calling ->VERSION would make a difference here.

Also, eval is massive overkill. Wouldn't

our $VERSION = '5.01_01';
$VERSION =~ tr/_//d;

suffice?

Leont commented 2 weeks ago

Also, eval is massive overkill. Wouldn't tr suffice?

Yeah that's exactly what @haarg ended up doing in 22180