search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

cpan/Encode/Byte/Makefile.PL: ensure build reproducibility #22172

Closed kanavin closed 3 weeks ago

kanavin commented 3 weeks ago

Sort the Encode::Byte byte_t.fnm file output (and the makefile depends whilst there for good measure).

Otherwise the output is non-deterministic and can change from one build to the next.

jkeenan commented 3 weeks ago

Sort the Encode::Byte byte_t.fnm file output (and the makefile depends whilst there for good measure).

Otherwise the output is non-deterministic and can change from one build to the next.

While this change set looks acceptable, you will have to submit it at https://github.com/dankogai/p5-encode. Encode is a library maintained on CPAN for multiple versions of perl and shipped with the core distribution. So the upstream maintainer has to verify that your proposed changes will work with older versions of Encode. Please file your merge request at that URL.

Marking this ticket send-to-cpan and closing here.