search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

remove underscore from VERSION in podlators #22180

Closed haarg closed 1 week ago

haarg commented 2 weeks ago

When using versions with underscores, best practice is to remove the underscore on a later line, to allow using the version as a number when accessing the variable directly.

jkeenan commented 1 week ago

@haarg, could you run:

$ cd t; ./perl -I../lib porting/customized.t --regen; cd -

... to enable t/porting/customized.t to pass? Thanks.

jkeenan commented 1 week ago

Thanks. I note that the podlators distribution is moving to semantic versioning, so we can expect to have to modify its entry in Porting/Maintainers.pl in the future.

haarg commented 1 week ago

The underscores only exist because we needed to patch the module in core. Once blead is open for new development, we should be able to just sync the new stable version and eliminate the customizations.

If in the future we need to customize a module that declares its version using the package statement, it will require extra work because that type of declaration doesn't allow underscores.