search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.96k stars 555 forks source link

Unexpected complaint of NE deprecation #2226

Closed p5pRT closed 20 years ago

p5pRT commented 24 years ago

Migrated from rt.perl.org#3537 (status was 'resolved')

Searchable as RT3537$

p5pRT commented 24 years ago

From rherbert@sycamorehq.com

Created by ryan@sycamorehq.com

Perl unexpectedly complains about the use of NE in a script that resembles this one​:

  #!/usr/bin/perl -w

  use Data​::Dumper;

  %test = (   MT => 'Montana'\,   NE => 'Nebraska'\,   NV => 'Nevada'\,   );

  print Dumper(\%test);

When this script is run or is checked with -c\, the following error message is generated​:

  Use of NE is deprecated at test.pl line 7.

However\, the data in the hash are correct. This problem does not occur if 'NE' is quoted.

Perl Info ``` Site configuration information for perl 5.00503: Configured by root at Wed Feb 2 15:34:50 EST 2000. Summary of my perl5 (5.0 patchlevel 5 subversion 3) configuration: Platform: osname=linux, osvers=2.2.5-22smp, archname=i386-linux uname='linux porky.devel.redhat.com 2.2.5-22smp #1 smp wed jun 2 09:11:51 edt 1999 i686 unknown ' hint=recommended, useposix=true, d_sigaction=define usethreads=undef useperlio=undef d_sfio=undef Compiler: cc='cc', optimize='-O2 -m486 -fno-strength-reduce', gccversion=egcs-2.91.66 19990314/Linux (egcs-1.1.2 release) cppflags='-Dbool=char -DHAS_BOOL -I/usr/local/include' ccflags ='-Dbool=char -DHAS_BOOL -I/usr/local/include' stdchar='char', d_stdstdio=undef, usevfork=false intsize=4, longsize=4, ptrsize=4, doublesize=8 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 alignbytes=4, usemymalloc=n, prototype=define Linker and Libraries: ld='cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lnsl -ldl -lm -lc -lposix -lcrypt libc=, so=so, useshrplib=false, libperl=libperl.a Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic' cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib' Locally applied patches: @INC for perl 5.00503: /usr/lib/perl5/5.00503/i386-linux /usr/lib/perl5/5.00503 /usr/lib/perl5/site_perl/5.005/i386-linux /usr/lib/perl5/site_perl/5.005 . Environment for perl 5.00503: HOME=/home/rherbert LANG=en_US LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin:/home/rherbert/bin PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 24 years ago

From [Unknown Contact. See original ticket]

On Jul 17\, Ryan Herbert said​:

Perl unexpectedly complains about the use of NE in a script that resembles this one​:

   \#\!/usr/bin/perl \-w
   %test = \(
       MT => 'Montana'\,
       NE => 'Nebraska'\,
       NV => 'Nevada'\,
   \);

   Use of NE is deprecated at test\.pl line 7\.

You'll get the same message for EQ\, LE\, GE\, LT\, and GT\, which are the string comparison operators in capital letters (except for 'cmp' which is oddly not among them).

  $foo NE $bar

is "legal" Perl code\, except that -w complains that 'NE' is deprecated.

You got away with murder because the 'NE' is followed by a =>\, which quotes the preceeding string.

  perl -we 'open NE\, "foo"' Use of NE is deprecated at -e line 1. Not enough arguments for open at -e line 1\, near "open NE" syntax error at -e line 1\, near "NE\," Execution of -e aborted due to compilation errors.

  perl -we 'open NE => "foo"' Precedence problem​: open NE should be open(NE) at -e line 1. Use of NE is deprecated at -e line 1. Name "main​::NE" used only once​: possible typo at -e line 1.

Whatever the issue\, Perl allows the two-character string comparison operators to be used in lowercase and uppercase\, although uppercase ones get you whacked.

p5pRT commented 24 years ago

From @mjdominus

Perl unexpectedly complains about the use of NE in a script that resembles this one​: %test = ( NE => 'Nebraska'\,

'NE' is a long-dead synonym for 'ne'. The warning is probably generated by the lexer as soon as the NE token is seen. It is certainly a bug that the warning is generated for a token on the left-hand side of the => operator; this might be fixable.

But I think it might be better to just eliminate support for NE entirely. Jarkko\, do you think this is the right approach? NE has been deprecated since Perl 5.000.

p5pRT commented 24 years ago

From [Unknown Contact. See original ticket]

2000-07-17-12​:59​:32 Mark-Jason Dominus​:

But I think it might be better to just eliminate support for NE entirely. [...] NE has been deprecated since Perl 5.000.

Looks safe to me; I don't think any current module uses NE in a way that would break if it were removed. Here's the result of

  find . -type f -printf '%P\n' | \   egrep -i '\.p[hlm]$' | \   xargs grep -w NE

on my modules-unpacked directory\, the generated using the script I posted in

  Date​: Thu\, 13 Jul 2000 13​:33​:53 -0400   From​: Bennett Todd \bet@​rahul\.net   To​: Alan Burlison \Alan\.Burlison@​uk\.sun\.com   Cc​: perl5-porters@​perl.org   Subject​: CPAN module unpack/index (was Re​: Mirroring all of CPAN ...)   Message-Id​: \20000713133353\.B4230@​oven\.com

-Bennett

Apache-iNcom-0.09/lib/HTML/FormValidator.pm​:MA MI MN MS MO MT NE NV NH NJ NM NY NC ND OH OK OR PA PR RI Aviation-Report-1.02/Report.pm​:NE​:northeast Data-Dump-0.03/Dump.pm​:DESTROY END EQ GE GT INIT LE LT NE abs accept alarm and atan2 bind GD-1.30/GD.pm​: $diagonal_brush->line(0\,4\,4\,0\,$black); # NE diagonal Geography-USStates-0.12/USStates.pm​: 'NE' => 'Nebraska'\, NJ => 'New Jersey'\, NH => 'New Hampshire'\, Gtk-Perl-0.7000/Gtk/samples/testpacker.pl​: my($button_ne) = new Gtk​::ToggleButton "NE"; HTML-Format-1.23/lib/HTML/FormatPS.pm​:/NE { %def HTML-Format-1.23/lib/HTML/FormatPS.pm​: push(@​prolog\, "ISOLatin1Encoding/$full-ISO/$full NE\n"); InfoBrief-0.14/InfoBrief.pm​:/NE { %def InfoBrief-0.14/InfoBrief.pm​:ISOLatin1Encoding /AvantGarde-Demi-ISO /AvantGarde-Demi NE Locale-SubCountry-1.02/SubCountry.pm​:NE​:Nebraska Logfile-0.202/lib/Net/Country.pm​:NE Niger Mac-Glue-0.58/blib/lib/Mac/AETE/Format/Glue.pm​: $self->{'NE'} = $id; Mac-Glue-0.58/blib/lib/Mac/AETE/Format/Glue.pm​: undef $self->{'NE'}; Mac-Glue-0.58/blib/lib/Mac/AETE/Format/Glue.pm​: $self->{N }{$self->{'NE'}}{$en}{id} = $id; Mac-Glue-0.58/blib/lib/Mac/AETE/Format/Glue.pm​: $self->{N }{$self->{'NE'}}{$en}{desc} = $desc; Mac-Glue-0.58/blib/lib/Mac/AETE/Format/Glue.pm​: $self->{DN}{$self->{'NE'}}{$en}{desc} = $desc; Net-Whois-1.9/Whois.pm​: 'NE' => 'NEBRASKA'\, Unicode-String-2.06/lib/Unicode/CharName.pm​:306D HIRAGANA LETTER NE Unicode-String-2.06/lib/Unicode/CharName.pm​:30CD KATAKANA LETTER NE Unicode-String-2.06/lib/Unicode/CharName.pm​:32E7 CIRCLED KATAKANA NE Unicode-String-2.06/lib/Unicode/CharName.pm​:FF88 HALFWIDTH KATAKANA LETTER NE WWW-Search-2.14/lib/WWW/Search/Infoseek.pm​: $WEB_HITS\, $WEB_NEXT\, $DESC_SPLIT) = qw( ST HE HI DE PE SI DA NE CN TR WH WN DS );

p5pRT commented 24 years ago

From @TimToady

Mark-Jason Dominus writes​: : > Perl unexpectedly complains about the use of NE in a script that resembles : > this one​: : > %test = ( : > NE => 'Nebraska'\, : : 'NE' is a long-dead synonym for 'ne'. The warning is probably : generated by the lexer as soon as the NE token is seen. It is : certainly a bug that the warning is generated for a token on the : left-hand side of the => operator; this might be fixable. : : But I think it might be better to just eliminate support for NE : entirely. Jarkko\, do you think this is the right approach? NE has : been deprecated since Perl 5.000.

I'd say kill it.

Larry

p5pRT commented 24 years ago

From [Unknown Contact. See original ticket]

Lightning flashed\, thunder crashed and Larry Wall \larry@​wall\.org whispered​: | I'd say kill it.

This is the first time in a long time that I've tried to submit a patch. Please check it over. It compiles and passes all tests on my machine\, including the original bug script.

-spp

Inline Patch ```diff diff -bBru perl-5.6.0/t/op/do.t perl-5.6.work/t/op/do.t --- perl-5.6.0/t/op/do.t Wed Mar 8 13:12:52 2000 +++ perl-5.6.work/t/op/do.t Tue Jul 18 14:23:52 2000 @@ -21,18 +21,18 @@ $_[0] = "not ok 1\n"; $result = do foo1("ok 1\n"); print "#2\t:$result: eq :value:\n"; -if ($result EQ 'value') { print "ok 2\n"; } else { print "not ok 2\n"; } -if ($_[0] EQ "not ok 1\n") { print "ok 3\n"; } else { print "not ok 3\n"; } +if ($result eq 'value') { print "ok 2\n"; } else { print "not ok 2\n"; } +if ($_[0] eq "not ok 1\n") { print "ok 3\n"; } else { print "not ok 3\n"; } $_[0] = "not ok 4\n"; $result = do foo2("not ok 4\n","ok 4\n","not ok 4\n"); print "#5\t:$result: eq :value:\n"; -if ($result EQ 'value') { print "ok 5\n"; } else { print "not ok 5\n"; } -if ($_[0] EQ "not ok 4\n") { print "ok 6\n"; } else { print "not ok 6\n"; } +if ($result eq 'value') { print "ok 5\n"; } else { print "not ok 5\n"; } +if ($_[0] eq "not ok 4\n") { print "ok 6\n"; } else { print "not ok 6\n"; } $result = do{print "ok 7\n"; 'value';}; print "#8\t:$result: eq :value:\n"; -if ($result EQ 'value') { print "ok 8\n"; } else { print "not ok 8\n"; } +if ($result eq 'value') { print "ok 8\n"; } else { print "not ok 8\n"; } sub blather { print @_; diff -bBru perl-5.6.0/t/pragma/warn/2use perl-5.6.work/t/pragma/warn/2use --- perl-5.6.0/t/pragma/warn/2use Mon Mar 13 05:32:18 2000 +++ perl-5.6.work/t/pragma/warn/2use Tue Jul 18 15:11:53 2000 @@ -12,28 +12,6 @@ BEGIN failed--compilation aborted at - line 3. ######## -# Check compile time scope of pragma -use warnings 'deprecated' ; -{ - no warnings ; - 1 if $a EQ $b ; -} -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 8. -######## - -# Check compile time scope of pragma -no warnings; -{ - use warnings 'deprecated' ; - 1 if $a EQ $b ; -} -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 6. -######## - # Check runtime scope of pragma use warnings 'uninitialized' ; { @@ -67,55 +45,27 @@ Use of uninitialized value in scalar chop at - line 6. ######## -use warnings 'deprecated' ; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 3. -######## - --FILE-- abc -1 if $a EQ $b ; +1 if $a eq $b ; 1; --FILE-- -use warnings 'deprecated' ; require "./abc"; EXPECT ######## --FILE-- abc -use warnings 'deprecated' ; 1; --FILE-- require "./abc"; -1 if $a EQ $b ; +1 if $a eq $b ; EXPECT ######## ---FILE-- abc -use warnings 'deprecated' ; -1 if $a EQ $b ; -1; ---FILE-- -use warnings 'uninitialized' ; -require "./abc"; -my $a ; chop $a ; -EXPECT -Use of EQ is deprecated at ./abc line 2. -Use of uninitialized value in scalar chop at - line 3. -######## - ---FILE-- abc.pm -use warnings 'deprecated' ; -1 if $a EQ $b ; -1; ---FILE-- use warnings 'uninitialized' ; -use abc; my $a ; chop $a ; EXPECT -Use of EQ is deprecated at abc.pm line 2. Use of uninitialized value in scalar chop at - line 3. ######## @@ -164,49 +114,6 @@ # Check scope of pragma with eval no warnings ; -eval { - 1 if $a EQ $b ; -}; print STDERR $@ ; -1 if $a EQ $b ; -EXPECT - -######## - -# Check scope of pragma with eval -no warnings ; -eval { - use warnings 'deprecated' ; - 1 if $a EQ $b ; -}; print STDERR $@ ; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 6. -######## - -# Check scope of pragma with eval -use warnings 'deprecated' ; -eval { - 1 if $a EQ $b ; -}; print STDERR $@ ; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 5. -Use of EQ is deprecated at - line 7. -######## - -# Check scope of pragma with eval -use warnings 'deprecated' ; -eval { - no warnings ; - 1 if $a EQ $b ; -}; print STDERR $@ ; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 8. -######## - -# Check scope of pragma with eval -no warnings ; eval ' my $b ; chop $b ; '; print STDERR $@ ; @@ -248,61 +155,10 @@ Use of uninitialized value in scalar chop at - line 8. ######## -# Check scope of pragma with eval -no warnings ; -eval ' - 1 if $a EQ $b ; -'; print STDERR $@ ; -1 if $a EQ $b ; -EXPECT - -######## - -# Check scope of pragma with eval -no warnings ; -eval q[ - use warnings 'deprecated' ; - 1 if $a EQ $b ; -]; print STDERR $@; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at (eval 1) line 3. -######## - -# Check scope of pragma with eval -use warnings 'deprecated' ; -eval ' - 1 if $a EQ $b ; -'; print STDERR $@; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 7. -Use of EQ is deprecated at (eval 1) line 2. -######## - -# Check scope of pragma with eval -use warnings 'deprecated' ; -eval ' - no warnings ; - 1 if $a EQ $b ; -'; print STDERR $@; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 8. -######## - # Check the additive nature of the pragma -1 if $a EQ $b ; my $a ; chop $a ; -use warnings 'deprecated' ; -1 if $a EQ $b ; -my $b ; chop $b ; +use warnings 'deprecated'; use warnings 'uninitialized' ; -my $c ; chop $c ; -no warnings 'deprecated' ; -1 if $a EQ $b ; -EXPECT -Use of EQ is deprecated at - line 6. -Use of uninitialized value in scalar chop at - line 9. -Use of uninitialized value in string eq at - line 11. -Use of uninitialized value in string eq at - line 11. +my $b ; chop $b ; +EXPECT +Use of uninitialized value in scalar chop at - line 6. diff -bBru perl-5.6.0/t/pragma/warn/4lint perl-5.6.work/t/pragma/warn/4lint --- perl-5.6.0/t/pragma/warn/4lint Mon Dec 27 19:00:21 1999 +++ perl-5.6.work/t/pragma/warn/4lint Tue Jul 18 15:18:53 2000 @@ -4,12 +4,9 @@ -W # lint: check compile time $^W is zapped BEGIN { $^W = 0 ;} -$a = $b = 1 ; -$a = 1 if $a EQ $b ; close STDIN ; print STDIN "abc" ; EXPECT -Use of EQ is deprecated at - line 5. -print() on closed filehandle main::STDIN at - line 6. +print() on closed filehandle main::STDIN at - line 4. ######## -W # lint: check runtime $^W is zapped @@ -30,12 +27,9 @@ -W # lint: check "no warnings" is zapped no warnings ; -$a = $b = 1 ; -$a = 1 if $a EQ $b ; close STDIN ; print STDIN "abc" ; EXPECT -Use of EQ is deprecated at - line 5. -print() on closed filehandle main::STDIN at - line 6. +print() on closed filehandle main::STDIN at - line 4. ######## -W # lint: check "no warnings" is zapped @@ -57,56 +51,40 @@ ######## -W --FILE-- abc.pm -no warnings 'deprecated' ; -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- no warnings 'uninitialized' ; use abc; my $a ; chop $a ; EXPECT -Use of EQ is deprecated at abc.pm line 3. Use of uninitialized value in scalar chop at - line 3. ######## -W --FILE-- abc -no warnings 'deprecated' ; -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- no warnings 'uninitialized' ; require "./abc"; my $a ; chop $a ; EXPECT -Use of EQ is deprecated at ./abc line 3. Use of uninitialized value in scalar chop at - line 3. ######## -W --FILE-- abc.pm -BEGIN {$^W = 0} -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- $^W = 0 ; use abc; my $a ; chop $a ; EXPECT -Use of EQ is deprecated at abc.pm line 3. Use of uninitialized value in scalar chop at - line 3. ######## -W --FILE-- abc -BEGIN {$^W = 0} -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- $^W = 0 ; require "./abc"; my $a ; chop $a ; EXPECT -Use of EQ is deprecated at ./abc line 3. Use of uninitialized value in scalar chop at - line 3. diff -bBru perl-5.6.0/t/pragma/warn/5nolint perl-5.6.work/t/pragma/warn/5nolint --- perl-5.6.0/t/pragma/warn/5nolint Fri Dec 3 23:22:07 1999 +++ perl-5.6.work/t/pragma/warn/5nolint Tue Jul 18 14:45:21 2000 @@ -4,8 +4,6 @@ -X # nolint: check compile time $^W is zapped BEGIN { $^W = 1 ;} -$a = $b = 1 ; -$a = 1 if $a EQ $b ; close STDIN ; print STDIN "abc" ; EXPECT ######## @@ -26,8 +24,6 @@ -X # nolint: check "no warnings" is zapped use warnings ; -$a = $b = 1 ; -$a = 1 if $a EQ $b ; close STDIN ; print STDIN "abc" ; EXPECT ######## @@ -49,9 +45,6 @@ ######## -X --FILE-- abc.pm -use warnings 'deprecated' ; -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- use warnings 'uninitialized' ; @@ -61,9 +54,6 @@ ######## -X --FILE-- abc -use warnings 'deprecated' ; -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- use warnings 'uninitialized' ; @@ -73,9 +63,6 @@ ######## -X --FILE-- abc.pm -BEGIN {$^W = 1} -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- $^W = 1 ; @@ -85,9 +72,6 @@ ######## -X --FILE-- abc -BEGIN {$^W = 1} -my ($a, $b) = (0,0); -1 if $a EQ $b ; 1; --FILE-- $^W = 1 ; diff -bBru perl-5.6.0/t/pragma/warn/7fatal perl-5.6.work/t/pragma/warn/7fatal --- perl-5.6.0/t/pragma/warn/7fatal Wed Dec 8 01:23:15 1999 +++ perl-5.6.work/t/pragma/warn/7fatal Tue Jul 18 15:17:38 2000 @@ -2,18 +2,6 @@ __END__ -# Check compile time warning -use warnings FATAL => 'deprecated' ; -{ - no warnings ; - 1 if $a EQ $b ; -} -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at - line 8. -######## - # Check runtime scope of pragma use warnings FATAL => 'uninitialized' ; { @@ -38,51 +26,10 @@ Use of uninitialized value in scalar chop at - line 6. ######## ---FILE-- abc -1 if $a EQ $b ; -1; ---FILE-- -use warnings FATAL => 'deprecated' ; -require "./abc"; -EXPECT - -######## - ---FILE-- abc -use warnings FATAL => 'deprecated' ; -1; ---FILE-- -require "./abc"; -1 if $a EQ $b ; -EXPECT - -######## - ---FILE-- abc -use warnings 'deprecated' ; -1 if $a EQ $b ; -1; ---FILE-- use warnings FATAL => 'uninitialized' ; -require "./abc"; my $a ; chop $a ; print STDERR "The End.\n" ; EXPECT -Use of EQ is deprecated at ./abc line 2. -Use of uninitialized value in scalar chop at - line 3. -######## - ---FILE-- abc.pm -use warnings 'deprecated' ; -1 if $a EQ $b ; -1; ---FILE-- -use warnings FATAL => 'uninitialized' ; -use abc; -my $a ; chop $a ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at abc.pm line 2. Use of uninitialized value in scalar chop at - line 3. ######## @@ -125,52 +72,6 @@ # Check scope of pragma with eval no warnings ; -eval { - use warnings FATAL => 'deprecated' ; - 1 if $a EQ $b ; -}; print STDERR "-- $@" ; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at - line 6. -######## - -# Check scope of pragma with eval -use warnings FATAL => 'deprecated' ; -eval { - 1 if $a EQ $b ; -}; print STDERR "-- $@" ; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at - line 5. -######## - -# Check scope of pragma with eval -use warnings FATAL => 'deprecated' ; -eval { - no warnings ; - 1 if $a EQ $b ; -}; print STDERR $@ ; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at - line 8. -######## - -# Check scope of pragma with eval -no warnings ; -eval { - use warnings FATAL => 'deprecated' ; -}; print STDERR $@ ; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -The End. -######## - -# Check scope of pragma with eval -no warnings ; eval q[ use warnings FATAL => 'uninitialized' ; my $b ; chop $b ; @@ -204,39 +105,3 @@ print STDERR "The End.\n" ; EXPECT Use of uninitialized value in scalar chop at - line 8. -######## - -# Check scope of pragma with eval -no warnings ; -eval q[ - use warnings FATAL => 'deprecated' ; - 1 if $a EQ $b ; -]; print STDERR "-- $@"; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT --- Use of EQ is deprecated at (eval 1) line 3. -The End. -######## - -# Check scope of pragma with eval -use warnings FATAL => 'deprecated' ; -eval ' - 1 if $a EQ $b ; -'; print STDERR "-- $@"; -print STDERR "The End.\n" ; -EXPECT --- Use of EQ is deprecated at (eval 1) line 2. -The End. -######## - -# Check scope of pragma with eval -use warnings FATAL => 'deprecated' ; -eval ' - no warnings ; - 1 if $a EQ $b ; -'; print STDERR "-- $@"; -1 if $a EQ $b ; -print STDERR "The End.\n" ; -EXPECT -Use of EQ is deprecated at - line 8. diff -bBru perl-5.6.0/t/pragma/warn/8signal perl-5.6.work/t/pragma/warn/8signal --- perl-5.6.0/t/pragma/warn/8signal Thu Mar 2 14:24:16 2000 +++ perl-5.6.work/t/pragma/warn/8signal Tue Jul 18 15:20:11 2000 @@ -6,13 +6,13 @@ # 8signal BEGIN { $| = 1; $SIG{__WARN__} = sub { print "WARN -- @_" } } BEGIN { $SIG{__DIE__} = sub { print "DIE -- @_" } } -1 if 1 EQ 2 ; -use warnings qw(deprecated) ; -1 if 1 EQ 2 ; -use warnings FATAL => qw(deprecated) ; -1 if 1 EQ 2 ; +1 if chop($a); +use warnings qw(uninitialized) ; +1 if chop($a); +use warnings FATAL => qw(uninitialized) ; +1 if chop($a); print "The End.\n" ; EXPECT -WARN -- Use of EQ is deprecated at - line 6. -DIE -- Use of EQ is deprecated at - line 8. -Use of EQ is deprecated at - line 8. +WARN -- Use of uninitialized value in scalar chop at - line 6. +DIE -- Use of uninitialized value in scalar chop at - line 8. +Use of uninitialized value in scalar chop at - line 8. diff -bBru perl-5.6.0/t/pragma/warn/toke perl-5.6.work/t/pragma/warn/toke --- perl-5.6.0/t/pragma/warn/toke Tue Feb 22 03:53:00 2000 +++ perl-5.6.work/t/pragma/warn/toke Tue Jul 18 14:38:48 2000 @@ -3,12 +3,6 @@ we seem to have lost a few ambiguous warnings!! - 1 if $a EQ $b ; - 1 if $a NE $b ; - 1 if $a LT $b ; - 1 if $a GT $b ; - 1 if $a GE $b ; - 1 if $a LE $b ; $a = <<; Use of comma-less variable list is deprecated (called 3 times via depcom) @@ -131,27 +125,6 @@ __END__ # toke.c -use warnings 'deprecated' ; -1 if $a EQ $b ; -1 if $a NE $b ; -1 if $a GT $b ; -1 if $a LT $b ; -1 if $a GE $b ; -1 if $a LE $b ; -no warnings 'deprecated' ; -1 if $a EQ $b ; -1 if $a NE $b ; -1 if $a GT $b ; -1 if $a LT $b ; -1 if $a GE $b ; -1 if $a LE $b ; -EXPECT -Use of EQ is deprecated at - line 3. -Use of NE is deprecated at - line 4. -Use of GT is deprecated at - line 5. -Use of LT is deprecated at - line 6. -Use of GE is deprecated at - line 7. -Use of LE is deprecated at - line 8. ######## # toke.c use warnings 'deprecated' ; diff -bBru perl-5.6.0/toke.c perl-5.6.work/toke.c --- perl-5.6.0/toke.c Tue Mar 21 00:30:21 2000 +++ perl-5.6.work/toke.c Tue Jul 18 14:20:30 2000 @@ -5076,7 +5076,6 @@ } break; case 'E': - if (strEQ(d,"EQ")) { deprecate(d); return -KEY_eq;} if (strEQ(d,"END")) return KEY_END; break; case 'e': @@ -5142,12 +5141,6 @@ break; } break; - case 'G': - if (len == 2) { - if (strEQ(d,"GT")) { deprecate(d); return -KEY_gt;} - if (strEQ(d,"GE")) { deprecate(d); return -KEY_ge;} - } - break; case 'g': if (strnEQ(d,"get",3)) { d += 3; @@ -5247,12 +5240,6 @@ if (strEQ(d,"kill")) return -KEY_kill; } break; - case 'L': - if (len == 2) { - if (strEQ(d,"LT")) { deprecate(d); return -KEY_lt;} - if (strEQ(d,"LE")) { deprecate(d); return -KEY_le;} - } - break; case 'l': switch (len) { case 2: @@ -5303,9 +5290,6 @@ if (strEQ(d,"msgsnd")) return -KEY_msgsnd; break; } - break; - case 'N': - if (strEQ(d,"NE")) { deprecate(d); return -KEY_ne;} break; case 'n': if (strEQ(d,"next")) return KEY_next; ```
p5pRT commented 24 years ago

From @pmqs

From​: Stephen P. Potter [mailto​:spp@​ds.net]

Lightning flashed\, thunder crashed and Larry Wall \larry@&#8203;wall\.org whispered​: | I'd say kill it.

This is the first time in a long time that I've tried to submit a patch. Please check it over. It compiles and passes all tests on my machine\, including the original bug script.

Uh oh! The majority of the tests you've removed from the warnings test harness are testing functionality of the pragma\, rather than the specific deprecated warnings.

Paul

p5pRT commented 24 years ago

From @jhi

On Wed\, Jul 19\, 2000 at 08​:05​:49PM +0100\, Paul Marquess wrote​:

From​: Stephen P. Potter [mailto​:spp@​ds.net]

Lightning flashed\, thunder crashed and Larry Wall \larry@&#8203;wall\.org whispered​: | I'd say kill it.

This is the first time in a long time that I've tried to submit a patch. Please check it over. It compiles and passes all tests on my machine\, including the original bug script.

Uh oh! The majority of the tests you've removed from the warnings test harness are testing functionality of the pragma\, rather than the specific deprecated warnings.

Paul

Could you rework the patch?

p5pRT commented 24 years ago

From @pmqs

From​: Jarkko Hietaniemi [mailto​:jhi@​iki.fi]

On Wed\, Jul 19\, 2000 at 08​:05​:49PM +0100\, Paul Marquess wrote​:

From​: Stephen P. Potter [mailto​:spp@​ds.net]

Lightning flashed\, thunder crashed and Larry Wall \larry@&#8203;wall\.org whispered​: | I'd say kill it.

This is the first time in a long time that I've tried to submit a patch. Please check it over. It compiles and passes all tests on my machine\, including the original bug script.

Uh oh! The majority of the tests you've removed from the warnings test harness are testing functionality of the pragma\, rather than the specific deprecated warnings.

Paul

Could you rework the patch?

Sure.

Paul

p5pRT commented 24 years ago

From @pmqs

...

Could you rework the patch?

Here you are.

Paul

begin 666 DEP.UUE M8F5G​:6X@​-C8T(&1E\<"YP871C​:"YG>@​I-)UA\,*"(G.4\_4T1@​8%8Q13PB65 X M-S%#.F C/3\<W14]65#@​V7U5/7B4B7E)@​/41)*3\<M6#)'\,ETR*4I("DTP.TI. M1#-+3DE$-SLM-D(I14!!\,TDD*3$\/5)\,3U]/+C$X2T(K.$941%!))3@​W*497 M2U-71E\<_+5$^4R\,*35=#63P^1B\,N65Q872$E+5M@​-RQ3)B14+5\O2UU9/V ] M*& M/C\,\/E8C6"8G0E)5.#XD35\Y8"5>.%A4(@​I-4UM?3T$Q-$5@​4EHV*TI7 M\,T@​]\,$A'\,%LL/S9?0D93+EA\,6"U)2V N6$PQ5"M38#\<X6T=0.3@​B2CA334P[ M"DU.+SXV+"\[8%TP*CA&25\V\,C!%0"%4(SM>4"58+5I22T8W14M!\,U8Y2%5- M4SA&)2)0/3 L*BI&\,5H\*BT*33$[3U-/\,45-7#Q*.U\,W54LZ2T0K)ETM7SE? M1"Y/+S$G-%\I4#M -5='1UTK.2E\<)E ]4%@​O2UI;3EY/+0I-/#DW/E(I3#U/ M5TM77$]3.#=@​.3-355P\7UXQ+3\,_/THO64)*6C)​:+BA26EI'5T]73SPC5#Y9 M+E]"-& L"DTC7R\Z4%TQ7T\S0#-(+RY98%A.24U7\,R8\)E8A(2E8+S173%)- M-U(F\,"PY*#0N(EPY-&!)*S$\-D0S4BX*35)&6$-%\,TTH6CXG(2]10EHX72M? M+EU\<4CE=/EA@​1T9945A+/C0V.R\<Y1B\,B0SX\6%=-5B)%.%M-1E%/2 I-0T\<A M-R8L/DY632U​:.$Q?4UL\15$\+E\,M0UP]/BM>0R125BI/75U​:6CA>3E-@​.U\<U M3EM71U-97R='54P_"DU+(R=\<.R](8#\T(5U@​5$8F*D@​D1$).*3Y-74TM-3]1 M25HX(D1 \,C [1$@​[2TQ(2R]55UY4(5!$*3Q!7T@​*32A\<(R%5\,5]"-U=@​*CLZ M*C170E9 +UU75B(W1T\V6$Y%)%Y@​\,DLK8%='2#PN5EM35$(A\,R\_/4PM2"M4 M3PI-7S%$.$\J2"%51#Q0+TE'+E1#*$A$-CU 5UPA03(F0U@​B5S%(.#X\*$]( M\,TTL-$8I52@​T)TPA4%Q>120A"DU96#@​W04HP2$M903!'+455.D\<H\,2TU6BA6 M/%PP-RQ$\,3\<C2BQ542\,Z5#%>44U63C!*(TTC2$$X*4@​Q.2\,*34A*\,$!4.$I( M.C9.\,%$D\,U]\,0BI 5%-*/%19+B=.*E-=1S8W3257)S=#5RY7-B5;(TTV+4)0 M7SM!(E=81@​I-+U4[75$]-"E-\,$)&5B]"3UM&+$HM0EI\,\,5LD44@​W7B@​X3CTA M3$LE0E%2(UDV031;\,UTZ6B4K3$!03%%="DT\4RA30UY=+%=35C8\+R$L04E) M-#XS4T8I8$Y#6"DL3#HO5TQ.\,S J*#%&\,#HL0C) /TM+-#)#-3A#5#P*34H[ M2D$C+RLC)#DH)38P7R-4\,UM?+#8S5CP\4E\<Q2SY@​7%DL64(]0B$O/"XQ/UXS M+3HY6V!.3#\<C\,#\H)@​I-5$M'33-!.S F-4Q88%%*.4 S-TY@​(4\<R)"4K-S95 M-$) 5$%>0F!314 T1EQ47"152S175"M?559>+4Y;"DU8.DTK-R\P2S)5)5 B M/%A"-4-4(5-\,0EI8+4).(3]7/CU&*DPL/$-8.4-0-C(]/C@​E)4I>)2];\,E\,Q M\,F *33I@​+#LR7EHA.E%#*U$[5#M&*5\K45\<E5C-2\,%U?\,%@​K)SA*/SXA-RD_ M1B5=3$]0)25/.ELT7"(]7E([+@​I-)T%=3UXE.")5/%=8)4(N-CDX5CHK0F I M03X[*"4V-BE..SPC5E\<S3$]7)U]5+4]!52%'\,RQ15TPE5#DS"DT[55LD\,BLF M(5M*0D@​\14M\,.T\_)TU6/2-+*%=&73)"\,R\C2BE54DE5*"M;53PX1D\<F/2-. M)S8N*ELQ0B\,*32\,N-D)32$Q)*5%#*5HJ2&!'/51​:2U@​A*S1'/S=-(F W)DHZ M7BE44$M2)5PU45DM\,C@​F+$I=.SDT3S$I10I-6BQ51T-8*"I*.");5E T+5%& M5ST\(6 W4S!6/%Y>028C(U-.62L[5#E.-49'\,B$\.$TO43 E*C\O/#Y)"DTU M2R=%.R\,B5EM;-"Q!\,#A\,+B9?/$=\,05PZ7#9"2DU71C@​](BQ4-CM&4RE(2B@​E M5BY\,1C@​^6B$L(4="55@​*338[0R-/-C\,Z(2\Q544J\,40Y*6!'/V!;4E]/*U5\< M+B@​B(T58-%%>254I.CI9*"X\45-@​.5=9-R1-\,UQ+1@​I-2TTR6"Q+)S0U-"0R M7ELU04XU-EY/0B\<Z+EH[4%X[*C4Y\,E!5.E14-2X]\,3Y)-DE​:0%XI3BTH)4Q@​ M*"HB"DTR-$9>.RTP)DXV6S\<Y."X[\,S8Z4D0Z05\_12U=/RXL(3Y45E Q149' M)D51\,DE1.U53\,2)/7DE2635))E\<*351-0RQ3\,$@​U(CDH6E8M1%L]5R@​M34LM M4TE@​35E7+3\<J+D%&\,2M(/EM+\,BH]22(E(4M")S(_/U C/4A!50I-/UHT1%9- M6%\G12E>5"4E3E]%03\,B+4$D/E\<[5EU'22E0)4PW-D9)\,%HD5T(W0"U@​)2- M\,4Y/)%PG3BY\,"DU>22PE2T%$3#\R3SPM*%XV)$TM74E;+UI3.3PC(BA72T(L M.54M)R1(1R5&\,#%*+DA4.$(R0TPM.EM92C@​*34U.5SPX72\,[6EDX52\,O8$ S M7$).45I(.3!#3E0H7UHS7D(U33E?7CE963TJ7$DQ3$%;\,4E8)D]@​)3HW(@​I- M/C(].T F4S-64RE26E0W*3) +DXI5"\H4D-%*TLX*T]​:)E="-SD[6T8[02HI M14\V6U57-CY!34U&-TU/"DU​:-6!*6T5\<2DXG6TI+)%)​:\,$U8+BE"5RU7+"I$ M*3I5*U\,N-4LZ4#$R)U0S\,5 O72DB+2% +"Q#/%!6\,2T*321)3CA 5D\,[+%). M531 \,D1!)T4U75 M-2\<T*R10*")$34A8+E]/3B%.+EI?4S]'/"9.+DHO4%\,_ M3R-6)PI-*U\S72HX05!\<3"(U0$)#8"HQ5$I?25(N(D(O)U!\<+B)5\,5TS0B%$ M(S]&2C-9.U!-64U)7%M?1U B(U(W"DU$\,5\S6%4I\,U1154\,B-CI&6S%()EI2 M*5\\2#A!*"PA\,C4K03=+4%PU12LJ.D\,U8$A'6E\,U(30F-DA\,0D(*34@​H0"5& M32HN)C996R\,Y(D0O7U$G.F!"(RA5724M2#-#1E4X+34Q/#!$0RDN\,$4A/%1" M3T%!\,$1$0T!&)PI-(5HZ8$T^8"A85RA((DXI\,5$^5DTM.RLM6U9;*3TR5C1) M52%​:+DA".E8Q.4TC0D9"\,UDG)UDP6U\<X\,CXD"DTH2E]=\,S)%+#Q105P_\,4DA M3R)?5RXN1U\,N131\<\,TP[-B9802E=74XX/5I&4B%?/5A+2C0Y*R%+.$975#(* M32=\<*T R*#=&-DE3)B1>32%#\,2E?.3HM/3P]6D9.15LY4R)63$1#/5=87C8Y M3%\,]/E5'2B\^\,B]3+54A8 I--6!1*2Q$\,%T_7U@​V+45*/U R1EHH.D=9+%- M-4Y\<*S520T)#3"PU)"$Y)BDB0S(P1R(_5B\<B0EM4."DY"DTD7E%.1#0F-ULS M7TA 0E-'.#E2/UHZ7DT_65!\<(4M"+%0Q450]5C)4/T5"-4 Z(48G.B-.7TDX M.5$H3#\<*34\K/2\]5$HV2CY!6F N-%0H759(4$Y%5BP[.B1*4E!\<+3(Q2$!2 M25@​O0E8X0RQ4*C@​C6#U$2TA*72(N1PI--DDH3$A@​/#9\<)SDJ34$G)T%'-#PK M0DU\,5U\<F)5@​H55(Y+E]+4$0C+D1+53%0-49/)C@​H5R@​G-R4C)"9?"DTL\,"\S M*C1(\,#XH5EQ?*& U.5HX)TLH0"8^24@​]720G-"\,A4TM$.4H_)SPS.E$I*"-1 M.6 K14\<]16 T-#X*35U.24H^+UM​:6D9(3U]66&!-62I$5S]76%Q/*T4F.5-> M2E@​D2RI(\,C5-.58P74XW-"A//3D^5UY​:)E)?40I-)392)"4M5UU((4%14SI\, M(4A​:23\<O62LW*5XK+R4R)SD_1BU(1%E\,-5Q$(S!-+E%;\,T-//C8L03=++4HN M"DTN3CU77#17/3@​U0BE$\,44R5C$A13=%72I\,)3==6B=&5C%#/% L*4P^\,4I? M62DG2U57*B5 )"\,K\,TP[6S *34-7.2Q\,1CLD3E-.7CM?\,TXR.$16+%XB6"U. M7&!7)3U\<62M\<44D^32LP2U\_2RTH53U\<-B\<L/5\\4"-?0@​I-+S ]*219(E9> M7D\<O4R\O*SXS)DU​:3$=.+4@​[6E@​D-%M15S%+\,EP_2BXO0CPG6UA7+RTC7S(C M*DM#4B53"DTH6C]​:)U(L*SM5.UU​:43@​V*")10#51*E@​R\,SU2*3(D2R922E\O M\,3$W6D]*1R-?-SH[7E@​M04H\\,TPE64\,*35\<^0"Y06#E74$%*/R-3.D=1/S\<I M)5LO)TLI8$M"\,"TA-$HR1BM 14PF1S(S05\<N62I.7T0_*T\]6DP_2PI-.CE( M\,F ].50T*DE>4U(C(D@​Q)DE)-#XV/DD^*R%'-4@​Q*C50\,R\<^)DXG-%0])3)= M-D]02DPH1$U/(55."DU/+"8Y74(Z-"A//CP^724Y6UI4+#@​H+5-;.%Q$.BLW M.#5*(U-#/#)70D1/6U\X-%T\.$\W74PL2CXX3UL*34\C45\,].5XW33)​:1S)? M.#DQ8$\<P4"E@​-&!61UDG6F J)E(W-EU5-2\,P/T=+7E- 14\,U5BLB5T8J.SD[ M7PI-0UY164\L\(R%>6SU/3T51/3\\W05D\\\-UE573@&#8203;C/T0V75\<Q\,5\]7\*$I*45+ M5E@​Z3"PC7SM)-U4I6E4^7U56"DTR*4A%5EXG-UPV.SQ#4B="0T(Q*%\<Q5U@​^ M)SY87$4A)TI\<4%Q+5UI$/THT+4A\<7C]9-DDN*B8F138^3%\,*35@​H*35\<2E@​[ M+B8D6C9))"\<_3RLQ-D5%0#Y*\,CA1\,5Q%+$LV(B0\24XT)U5$4D(\0U0[(C1. M6"0Z-S0W0 I-5S$Y7D=86C994T0I-$E#22@​T0"%//4]12%\<T+41 \,4)752%% M\,%$S4U\<P+4U\,/2='-$XW.%4P6U).6RU "DTX-4137$(E.EY!)3]154PD."PJ M+3TP/T9;+4H^*RM712A!2SLY7%TX5"@​B72M*4UTV3$4\*3I?7#\E03P*33]' M.3DW+UI&2RM2+%]#(RQ).B\,U2$0\)4]/7CXO5R8C)S=&4T8]155++#0B+TE& M7CLY*2]94TM6*$1". I-7#%923Q#0%(G\,#Q?4B\<P-R0C/E S-2@​G1%-#0D98 M0SQ\,0RTW8%8T1$@​M-3%%6U=8+TXL7D0I)TU#\,$\,P"DTQ.D]\,5S4R\,DXG2E- M0T@​M-T%+3BTH(2E2*TDE65Q\</T51)TXI6DM8.$-%5D8Q+%-$13TM0C4W(U\<A M-DP*35DD-S533RI+.C\<E2EXY5TH\-DM953DH4UTE8%E=2$E/2RLO12HU-6 L M35Q64C\]344E4R)'6R57+#%?)@​I-7DXQ7D)363 W5#4R)C!&(4HA2%)/.#PV M754V3%5$.UXR\,355\,S4C)3]#\,44[624X54M+5BL_+U9!+TY\,"DU$.$\<E6T!0 M6R%(.D\Q.UD^3D!#7%@​R7B\<X6B1=7RHU73$C63PF0B51+B-86CH_139\,+S$] M6B]96UXO3C4*35TY)#XD-%!4+E=>+59;-3HX-%4R)#M\<6U(^1SDH0U8S-%A. M/#59\,4]9(DDR*20E)3I'\,59)1#\<H\,2\,S-PI-02Y/)DY'0E\,D3%I1-R- 72$P M1RLQ-5HQ+D9/+$];1$Q$5T0R."E$4T9062M&54I\,*C]5/R%!\,#-3+CPJ"DTS M.3XQ1S5!(3998"E9-2% )D\E14E\)\+\#@&#8203;D2\#\!\!\-\#LP\(E4B\,24E53$I6SI04U\, M.UI+/E18/2Q30E\<I*C\<*34$[(CXU.#]52R$Q-BE07S9\,52DX1S$I."\<P.TM@​ M3%\B\,44O*BI0/C\,E1$T\7S(Q)5$B0$DZ0"8P3$) *PI-2DM06B)9448]2SHX M*RU142)$2U9>0C$K.%M..50I64=&+BU9*C$B3CTY*4=77EHZ.D\,F(DM/-%DR M)41*"DT^/$4U\,E%(\,#%@​.#PD/BA/2%Q?0$M365DS751(*E=1*4]\,5C]=4S=\< M/S=!+5=))C14/SL\+"DT4& O-20*335&.R%1)RDI)4A$/2\<B7$-$4T]*6E\<Q M6BQ1/4\<[4RM3/3]/4"E*25L_.UQ")4]52R$G0CXS2DT]-BHL10I-4T4F0S]0 M3V!11T8E8#M=.R)54U9"/UQ#8&!;+CA95SY-8"Y2*BI$4#0F-3U5/3 A8$5$ M-BTT*4\,C25\<X"DTE7TXQ*B)(4%0A\,2TE-C0].5DW6#8U-S5\,)4M​:3%Q.2D-$ M\,38W62I48#I63RHD238_-ULM-C0J4E-!3R@​*358F."LF1#-'6E\<D*T\,S-2$F M13M 0$([04 S3D4G5$HA)2M64$160#Y+5D!2.UHG0EHW*2$B63LN*%1'\,PI- M1%0B329/8#A"/THR2$Y!.4TV*RI%13)+1BPZ34H^+DTG/& _*%I36C8B3U(] M/CQ/2TA​:1"XU5DPV\,E%'"CDV8$TQ-U E*34P/"\,T*3)>24LM*E]0/BY3(40Z /*28P8&!@​8& *8 IE;F0* ` end

p5pRT commented 24 years ago

From @jhi

On Wed\, Jul 26\, 2000 at 11​:40​:18PM +0100\, Paul Marquess wrote​:

...

Could you rework the patch?

Here you are.

Paul

And there it is.

(double uuencoded patch\, eh?)

p5pRT commented 24 years ago

From @pmqs

From​: Jarkko Hietaniemi [mailto​:jhi@​iki.fi]

On Wed\, Jul 26\, 2000 at 11​:40​:18PM +0100\, Paul Marquess wrote​:

...

Could you rework the patch?

Here you are.

Paul

And there it is.

(double uuencoded patch\, eh?)

Belt & Braces. :-)

Paul