Closed aarondill closed 1 month ago
I've amended the commits to ensure all $VERSION
values match (https://github.com/Perl/perl5/issues/22346#issuecomment-2227173799)
I've amended the commits to ensure all
$VERSION
values match (#22346 (comment))
This looks good to me, but I'd like to see https://github.com/Perl/perl5/pull/22404 merged in first.
I've amended the commits to ensure all
$VERSION
values match (#22346 (comment))This looks good to me, but I'd like to see #22404 merged in first.
GH #22404 has been merged in to blead. That caused GitHub to append a hasConflicts
label to this p.r. I attempted to resolve it via the web editor, only for GH now to tell me "This branch cannot be rebased due to conflicts."
I think I'll let the GH CI testing proceed before taking further action. In the meantime, if there is anyone else who wants to look over this pull request, please do so. Thanks.
I've amended the commits to ensure all
$VERSION
values match (#22346 (comment))This looks good to me, but I'd like to see #22404 merged in first.
GH #22404 has been merged in to blead. That caused GitHub to append a
hasConflicts
label to this p.r. I attempted to resolve it via the web editor, only for GH now to tell me "This branch cannot be rebased due to conflicts."I think I'll let the GH CI testing proceed before taking further action. In the meantime, if there is anyone else who wants to look over this pull request, please do so. Thanks.
@tonycoz or @book, can either of you look at the code changes being requested here and approve? At that point, I'll deal with the merge problems. Thanks.
I'll rebase onto bleed
and force push. that should be the simplest way to resolve the conflicts.
@jkeenan I've rebased onto bleed
and resolved the conflicts. This should keep the commit history and diff cleaner :smile:
@jkeenan I've rebased onto
bleed
and resolved the conflicts. This should keep the commit history and diff cleaner 😄
Thanks for that legwork. I've approved this commit and self-assigned. I'll allow for 2 or 3 days for other committers to approve, and then proceed to merge unless there's an objection.
Fixes #22346 by ensuring that trailing PATH elements are maintained on Unix and OS2