search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.91k stars 542 forks source link

Add tests to exercise panic #22413

Closed jkeenan closed 2 months ago

jkeenan commented 2 months ago

Adapted from mauke comment in GH #10194: https://github.com/Perl/perl5/issues/10194#issuecomment-2234278355

TODO only the failing test.

iabyn commented 2 months ago

On Wed, Jul 17, 2024 at 03:27:45PM -0700, James E Keenan wrote:

Adapted from mauke comment in GH #10194: https://github.com/Perl/perl5/issues/10194#issuecomment-2234278355

TODO only the failing test.

As per my comment in that ticket, I don't think this is a bug in the regex engine, and we really shouldn't be adding test code which feeds malformed utf8 into the regex engine in the hope that it panics.

-- "Strange women lying in ponds distributing swords is no basis for a system of government. Supreme executive power derives from a mandate from the masses, not from some farcical aquatic ceremony." -- Dennis, "Monty Python and the Holy Grail"

jkeenan commented 2 months ago

On Wed, Jul 17, 2024 at 03:27:45PM -0700, James E Keenan wrote: Adapted from mauke comment in GH #10194: #10194 (comment) TODO only the failing test. As per my comment in that ticket, I don't think this is a bug in the regex engine, and we really shouldn't be adding test code which feeds malformed utf8 into the regex engine in the hope that it panics. …

Based on comment in https://github.com/Perl/perl5/issues/10194#issuecomment-2236038659 and ongoing discussion in that ticket, I'm withdrawing this pull request.