search

Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.9k stars 540 forks source link

Small fixes to make argnames in `embed.fnc` match the real functions #22419

Closed leonerd closed 1 month ago

leonerd commented 1 month ago

During some other work I found a few cases where the argument names in embed.fnc didn't match the actual names the function definitions really use. This is important for making the PERL_ARGS_ASSERT_... macros work properly.

The two invmap ones are fixed by changing the argument name in embed.fnc; the cvstash one is fixed by renaming the argument in the real code.

jkeenan commented 1 month ago

Do you have any hunch as to whether this change will break some CPAN modules that have been poking around where they should not have?

leonerd commented 1 month ago

@jkeenan I don't imagine it will be visible outside to CPAN modules. These are deep in the C-level internals of the interpreter.