Closed p5pRT closed 19 years ago
Bugs in win32/bin/search.pl
The version of win32/bin/search.pl in perl-5.6.0 is out of date\, see bug report:- "Out of date version of win32/bin/search.pl"
The constants defined to access elements of the response from stat() are wrong. I have changed $STAT_DEV to 0 and $STAT_INODE to 1.
The following command and associated warnings are from search.bat on a windows 95 system\, but search.bat is automatically generated from search.pl.
C:\> perl -x -W C:\PERL\bin\search.bat "test[^x]test" Argument "[^" isn't numeric in substr at C:\PERL\bin\search.bat line 503. Argument "test[^x]test" isn't numeric in numeric ge (>=) at C:\PERL\bin\search.bat line 503. Use of uninitialized value in concatenation (.) at C:\PERL\bin\search.bat line 504.
The deprecated $CTRL-W is used to disable warnings during some processsing\, this does not work on some systems\, so I have changed it to $^W.
The messages due to the problems below are normally suppressed on most systems due to the $CTRL-W. So the -W option to perl may be needed to see them\, if -W option is available on the system.
Messages for search.bat line 503 are due to the wrong perl function being used. I have changed "substr" to "index". The surrounding code indicates that the author's intention was a simple test of whether or not $regex contains [^ as a substring.
Message for search.bat line 504 is due to variable $mflag being uninitialised. So I have moved its initialisation up one line\, ie. before conditional block\, so it will always be initialised before use.
Version 960908.11 only\, man page info for -R says "Undoes -T"\, but there is no -T option\, I have changed it to "Undoes -F".
Version 960908.11 only\, the default filter through zcat is used for extensions .gz and .Z\, but the earlier versions included .z in the default case-insensitive iskip option. So I have added .z to the default filter through zcat. It might also be sensible to add .taz/.tgz/.tpz to the filter\, I think zcat will convert them to tar files. The .tarz in default iskip might also be moved\, case-insensitively.
patch for search.pl version 960908.11 attached.
____________________________________________________________ Do You Yahoo!? Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk or your free @yahoo.ie address at http://mail.yahoo.ie
[argoalby@yahoo.co.uk - Tue Aug 15 19:42:43 2000]:
Bugs in win32/bin/search.pl
The version of win32/bin/search.pl in perl-5.6.0 is out of date\, see bug report:- "Out of date version of win32/bin/search.pl"
The constants defined to access elements of the response from stat() are wrong. I have changed $STAT_DEV to 0 and $STAT_INODE to 1.
The following command and associated warnings are from search.bat on a windows 95 system\, but search.bat is automatically generated from search.pl.
C:\> perl -x -W C:\PERL\bin\search.bat "test[^x]test" Argument "[^" isn't numeric in substr at C:\PERL\bin\search.bat line 503. Argument "test[^x]test" isn't numeric in numeric ge (>=) at C:\PERL\bin\search.bat line 503. Use of uninitialized value in concatenation (.) at C:\PERL\bin\search.bat line 504.
The deprecated $CTRL-W is used to disable warnings during some processsing\, this does not work on some systems\, so I have changed it to $^W.
The messages due to the problems below are normally suppressed on most systems due to the $CTRL-W. So the -W option to perl may be needed to see them\, if -W option is available on the system.
Messages for search.bat line 503 are due to the wrong perl function being used. I have changed "substr" to "index". The surrounding code indicates that the author's intention was a simple test of whether or not $regex contains [^ as a substring.
Message for search.bat line 504 is due to variable $mflag being uninitialised. So I have moved its initialisation up one line\, ie. before conditional block\, so it will always be initialised before use.
Version 960908.11 only\, man page info for -R says "Undoes -T"\, but there is no -T option\, I have changed it to "Undoes -F".
Version 960908.11 only\, the default filter through zcat is used for extensions .gz and .Z\, but the earlier versions included .z in the default case-insensitive iskip option. So I have added .z to the default filter through zcat. It might also be sensible to add .taz/.tgz/.tpz to the filter\, I think zcat will convert them to tar files. The .tarz in default iskip might also be moved\, case-insensitively.
patch for search.pl version 960908.11 attached.
This file has been forked from the original and updated separately. This ticket is resolved.
@smpeters - Status changed from 'open' to 'resolved'
Migrated from rt.perl.org#3712 (status was 'resolved')
Searchable as RT3712$