Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.99k stars 559 forks source link

perlbug from address #3527

Closed p5pRT closed 21 years ago

p5pRT commented 23 years ago

Migrated from rt.perl.org#5975 (status was 'resolved')

Searchable as RT5975$

p5pRT commented 23 years ago

From abela@geneanet.org

----------------------------------------------------------------- perlbug asks for "your address"\, but it's not used for replies to the sender.

For this run\, I entered Jerome.Abela@​free.fr as my address\, but I already know that the automated reply and the subsequent discussions will go to abela@​geneanet.org.

Perl Info ``` Flags: category=utilities severity=medium Site configuration information for perl v5.6.0: Configured by pixel at Fri Mar 31 16:32:49 CEST 2000. Summary of my perl5 (revision 5.0 version 6 subversion 0) configuration: Platform: osname=linux, osvers=2.2.15-0.16mdksmp, archname=i386-linux uname='linux kenobi.mandrakesoft.com 2.2.15-0.16mdksmp #1 smp mon mar 13 16:40:10 cet 2000 i686 unknown ' config_args='-des -Dprefix=/usr -Darchname=i386-linux -Dd_dosuid -Dd_semctl_semun -Di_db -Di_ndbm -Di_gdbm -Ud_csh -Dman3dir=/usr/lib/perl5/man/man3 -Doptimize=-O3 -fomit-frame-pointer -fno-exceptions -fno-rtti -pipe -s -mpentium -mcpu=pentium -march=pentium -ffast-math -fexpensive-optimizations' hint=recommended, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=undef d_sfio=undef uselargefiles=define use64bitint=undef use64bitall=undef uselongdouble=undef usesocks=undef Compiler: cc='cc', optimize='-O3 -fomit-frame-pointer -fno-exceptions -fno-rtti -pipe -s -mpentium -mcpu=pentium -march=pentium -ffast-math -fexpensive-optimizations', gccversion=2.95.3 19991030 (prerelease) cppflags='-fno-strict-aliasing' ccflags ='-fno-strict-aliasing -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' stdchar='char', d_stdstdio=define, usevfork=false intsize=4, longsize=4, ptrsize=4, doublesize=8 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, usemymalloc=n, prototype=define Linker and Libraries: ld='cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lnsl -ldl -lm -lc -lposix -lcrypt libc=/lib/libc-2.1.3.so, so=so, useshrplib=false, libperl=libperl.a Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic' cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib' Locally applied patches: @INC for perl v5.6.0: /usr/lib/perl5/5.6.0/i386-linux /usr/lib/perl5/5.6.0 /usr/lib/perl5/site_perl/5.6.0/i386-linux /usr/lib/perl5/site_perl/5.6.0 /usr/lib/perl5/site_perl/5.005/i386-linux /usr/lib/perl5/site_perl/5.005 /usr/lib/perl5/site_perl . Environment for perl v5.6.0: HOME=/home/abela LANG=fr LANGUAGE=fr LC_ALL=fr_FR LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/usr/X11R6/bin:/usr/local/bin:/bin:/usr/bin:/home/abela/bin:/usr/java/jdk1.3/bin PERL_BADLANG (unset) SHELL=/bin/bash ```
p5pRT commented 23 years ago

From [Unknown Contact. See original ticket]

Lightning flashed\, thunder crashed and abela@​geneanet.org whispered​: | This is a bug report for perl from Jerome.Abela@​free.fr\, | generated with the help of perlbug 1.28 running under perl v5.6.0. | ----------------------------------------------------------------- | perlbug asks for "your address"\, but it's not used for replies to the | sender.

This appears to be a bug in the handling of addresses inside perlbug. The from address seems to get overwritten a couple of times. Someone with more knowledge of perlbug may be able to fix it quickly and easily. Otherwise\, it would take me some time to figure out the flow and fix it.

-spp

p5pRT commented 23 years ago

From [Unknown Contact. See original ticket]

"Stephen P. Potter" \spp@​spotter\.yi\.org writes​:

This appears to be a bug in the handling of addresses inside perlbug. The from address seems to get overwritten a couple of times. Someone with more knowledge of perlbug may be able to fix it quickly and easily. Otherwise\, it would take me some time to figure out the flow and fix it.

I had a look at perlbug and came to the opinion that it could do with a quite a clean up.

Before I tear the whole thing apart\, is anyone really attached to the structure? The main body of code pretty much looks like this​:

  Init();   Query();   Edit() unless $usefile || ($ok and not $​::opt_n);   NowWhat();   Send();   exit;

It's almost neat\, but it's not actually that nice\, as there are other things interespersed there\, and it means it's quite hard to keep track of all the variables and their scope.

So\, anyone mind if I totally change the structure of perlbug?

Tony

p5pRT commented 23 years ago

From [Unknown Contact. See original ticket]

Lightning flashed\, thunder crashed and Tony Bowden \tony@​blackstar\.co\.uk whisp ered​: | I had a look at perlbug and came to the opinion that it could do with | a quite a clean up.

Please\, feel free! I agree it needs cleaned up. I was having all sorts of fun tracing back and forth to see how the address was being handled.

-spp