Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

Tests fail when sources are under CVS control #5814

Closed p5pRT closed 21 years ago

p5pRT commented 21 years ago

Migrated from rt.perl.org#15987 (status was 'resolved')

Searchable as RT15987$

p5pRT commented 21 years ago

From wjones@tc.fluke.com

Created by wjones@tc.fluke.com

Two test scripts may fail when the Perl sources are under CVS control​:

  lib/strict.t   lib/warnings.t

On win32 systems\, the scripts die when they try to open the CVS directory as a file. These are the error messages​:

  Cannot open lib/strict/CVS​: Permission denied   Cannot open lib\warnings\CVS​: Permission denied

This seems to be harmless on Unix systems. Here's a patch​:

Index​: strict.t

RCS file​: /usr0/sweng/src/active/CVS.repo/perl/lib/strict.t\,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 strict.t --- strict.t 2002/07/29 16​:21​:01 1.1.1.1 +++ strict.t 2002/08/05 18​:47​:11 @​@​ -20\,7 +20\,7 @​@​

foreach (sort glob($^O eq 'MacOS' ? "​:lib​:strict​:*" : "lib/strict/*")) {

- next if /(~|\.orig|\,v)$/; + next if -d || /(~|\.orig|\,v)$/;

  open F\, "\<$_" or die "Cannot open $_​: $!\n" ;   while (\) { Index​: warnings.t

RCS file​: /usr0/sweng/src/active/CVS.repo/perl/lib/warnings.t\,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 warnings.t --- warnings.t 2002/07/29 16​:20​:54 1.1.1.1 +++ warnings.t 2002/08/05 18​:46​:49 @​@​ -40\,6 +40\,7 @​@​

  next if $file =~ /(~|\.orig|\,v)$/;   next if $file =~ /perlio$/ && !(find PerlIO​::Layer 'perlio'); + next if -d $file;

  open F\, "\<$file" or die "Cannot open $file​: $!\n" ;   my $line = 0;

Perl Info ``` Flags: category=core severity=low Site configuration information for perl v5.8.0: Configured by wjones at Wed Jul 31 16:20:20 PDT 2002. Summary of my perl5 (revision 5.0 version 8 subversion 0) configuration: Platform: osname=linux, osvers=2.4.7-4gb, archname=i686-linux uname='linux evtpc0935 2.4.7-4gb #1 thu oct 25 17:53:12 gmt 2001 i686 unknown ' config_args='-e -Dcf_email=wjones@tc.fluke.com -Dprefix=/usr/local/perl/5.8.0 -Dstartperl=#!/usr/local/bin/perl -Dmake=gmake -Dcc=gcc -Dprivlib=/usr/local/perl/5.8.0/lib -Darchlib=/usr/local/perl/5.8.0/lib/i686-linux -Dsitelib=/usr/local/perl/5.8.0/site_perl -Dsitearch=/usr/local/perl/5.8.0/site_perl/i686-linux -Uinstallusrbinperl' hint=recommended, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='gcc', ccflags ='-fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O3', cppflags='-fno-strict-aliasing -I/usr/local/include' ccversion='', gccversion='2.95.3 20010315 (SuSE)', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='gcc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lnsl -lndbm -lgdbm -ldl -lm -lc -lcrypt -lutil perllibs=-lnsl -ldl -lm -lc -lcrypt -lutil libc=, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='2.2.2' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic' cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib' Locally applied patches: @INC for perl v5.8.0: /usr/local/perl/5.8.0/lib/i686-linux /usr/local/perl/5.8.0/lib /usr/local/perl/5.8.0/site_perl/i686-linux /usr/local/perl/5.8.0/site_perl /usr/local/perl/5.8.0/site_perl . Environment for perl v5.8.0: HOME=/usr0/wjones LANG=en_US LANGUAGE (unset) LC_COLLATE=POSIX LD_LIBRARY_PATH=/opt/mozilla//:/opt/mozilla//components:/opt/kde/lib:/opt/mozilla//:/opt/mozilla//components: LOGDIR (unset) PATH=/usr0/wjones/bin/ix86.linux:/usr0/wjones/bin/scripts:/usr/local/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/X11R6/bin:/usr/games/bin:/opt/gnome/bin:/opt/kde2/bin:/opt/kde/bin:/apps/sweng/bin:/apps/gnu/bin:/usr/games/bin PERL_BADLANG (unset) SHELL=/bin/ksh ```
p5pRT commented 21 years ago

From @hvds

Warren Jones (via RT) \perlbug@&#8203;perl\.org wrote​: :Two test scripts may fail when the Perl sources are under :CVS control​: : : lib/strict.t : lib/warnings.t [...] :Here's a patch​:

Thanks\, I've applied your patch to the repository for the perl-5.9 development track as change #17719.

Hugo

p5pRT commented 21 years ago

@gbarr - Status changed from 'new' to 'resolved'