Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.85k stars 527 forks source link

fix for Net::Google::Search boolean representation #6960

Closed p5pRT closed 20 years ago

p5pRT commented 20 years ago

Migrated from rt.perl.org#24595 (status was 'rejected')

Searchable as RT24595$

p5pRT commented 20 years ago

From andrew@scoop.co.nz

This is a bug report for perl from root@​wol.bush.shack\, generated with the help of perlbug 1.34 running under perl v5.8.2.


Incorrect representation of Boolean values breaks some aspects of Net​::Google​::Search.

Patch against Net-Google-0.60.tar.gz follows.

Inline Patch ```diff --- Net/Google/Search.pm.orig Thu Dec 4 19:57:29 2003 +++ Net/Google/Search.pm Thu Dec 4 19:58:03 2003 @@ -580,10 +580,10 @@ $first, $count, SOAP::Data->type(boolean=>($self->filter() - ? "true" : "false")), + ? 1 : 0)), $self->restrict(), SOAP::Data->type(boolean=>($self->safe() - ? "true" : "false")), + ? 1 : 0)), $self->lr(), $self->ie(), $self->oe(), ----------------------------------------------------------------- --- ```

Flags:   category=library   severity=medium


Site configuration information for perl v5.8.2​:

Configured by root at Fri Nov 14 21​:32​:03 EST 2003.

Summary of my perl5 (revision 5.0 version 8 subversion 2) configuration​:   Platform​:   osname=freebsd\, osvers=4.9-prerelease\, archname=i386-freebsd   uname='freebsd wol.bush.shack 4.9-prerelease freebsd 4.9-prerelease #0​: thu nov 13 01​:13​:17 est 2003 root@​wol.bush.shack​:usrobjusrsrcsyswol i386 '   config_args='-sde -Dprefix=/usr/local -Darchlib=/usr/local/lib/perl5/5.8.2/mach -Dprivlib=/usr/local/lib/perl5/5.8.2 -Dman3dir=/usr/local/lib/perl5/5.8.2/man/man3 -Dsitearch=/usr/local/lib/perl5/site_perl/5.8.2/mach -Dsitelib=/usr/local/lib/perl5/site_perl/5.8.2 -Dscriptdir=/usr/local/bin -Ui_malloc -Ui_iconv -Uinstallusrbinperl -Dcc=cc -Doptimize=-O -pipe -march=pentiumpro -Duseshrplib -Dccflags=-DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.2/BSDPAN" -Ud_dosuid -Ui_gdbm -Dusethreads=n -Dusemymalloc=y'   hint=recommended\, useposix=true\, d_sigaction=define   usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef   useperlio=define d_sfio=undef uselargefiles=define usesocks=undef   use64bitint=undef use64bitall=undef uselongdouble=undef   usemymalloc=y\, bincompat5005=undef   Compiler​:   cc='cc'\, ccflags ='-DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.2/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include'\,   optimize='-O -pipe -march=pentiumpro'\,   cppflags='-DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.2/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include'   ccversion=''\, gccversion='2.95.4 20020320 [FreeBSD]'\, gccosandvers=''   intsize=4\, longsize=4\, ptrsize=4\, doublesize=8\, byteorder=1234   d_longlong=define\, longlongsize=8\, d_longdbl=define\, longdblsize=12   ivtype='long'\, ivsize=4\, nvtype='double'\, nvsize=8\, Off_t='off_t'\, lseeksize=8   alignbytes=4\, prototype=define   Linker and Libraries​:   ld='cc'\, ldflags ='-Wl\,-E -L/usr/local/lib'   libpth=/usr/lib /usr/local/lib   libs=-lm -lcrypt -lutil -lc   perllibs=-lm -lcrypt -lutil -lc   libc=\, so=so\, useshrplib=true\, libperl=libperl.so   gnulibc_version=''   Dynamic Linking​:   dlsrc=dl_dlopen.xs\, dlext=so\, d_dlsymun=undef\, ccdlflags=' -Wl\,-R/usr/local/lib/perl5/5.8.2/mach/CORE'   cccdlflags='-DPIC -fPIC'\, lddlflags='-shared -L/usr/local/lib'

Locally applied patches​:


@​INC for perl v5.8.2​:   /usr/local/lib/perl5/site_perl/5.8.2/mach   /usr/local/lib/perl5/site_perl/5.8.2   /usr/local/lib/perl5/site_perl/5.8.1   /usr/local/lib/perl5/site_perl/5.005   /usr/local/lib/perl5/site_perl   /usr/local/lib/perl5/5.8.2/BSDPAN   /usr/local/lib/perl5/5.8.2/mach   /usr/local/lib/perl5/5.8.2   .


Environment for perl v5.8.2​:   HOME=/root   LANG (unset)   LANGUAGE (unset)   LD_LIBRARY_PATH (unset)   LOGDIR (unset)   PATH=/bin​:/sbin​:/usr/bin​:/usr/sbin​:/usr/local/bin​:/usr/local/sbin​:/usr/X11R6/bin   PERL_BADLANG (unset)   SHELL=/usr/local/bin/bash --

No added Sugar. Not tested on animals. May contain traces of Nuts. If irritation occurs\, discontinue use.


Andrew McNaughton Currently in Boomer Bay\, Tasmania andrew@​scoop.co.nz Mobile​: +61 422 753 792 http​://staff.scoop.co.nz/andrew/cv.doc

p5pRT commented 20 years ago

From @nwc10

On Thu\, Dec 04\, 2003 at 09​:12​:46AM -0000\, Andrew McNaughton wrote​:

# New Ticket Created by Andrew McNaughton # Please include the string​: [perl #24595] # in the subject line of all future correspondence about this issue. # \<URL​: http​://rt.perl.org​:80/rt3/Ticket/Display.html?id=24595 >

This is a bug report for perl from root@​wol.bush.shack\, generated with the help of perlbug 1.34 running under perl v5.8.2.

-----------------------------------------------------------------

Incorrect representation of Boolean values breaks some aspects of Net​::Google​::Search.

Net​::Google​::Search is not a core perl module\, and not maintained by the perl5 maintainers. You'll need to resend your patch to the author of Net​::Google​::Search. According to search.cpan.org​:

http​://search.cpan.org/~ascope/

his address is cpan@​aaronland.net

Nicholas Clark

p5pRT commented 20 years ago

@nwc10 - Status changed from 'new' to 'rejected'

p5pRT commented 20 years ago

From andrew@scoop.co.nz

Thanks for taking the time to put me right on this. I have already been told I'd done things the wrong way\, and directed to rt.cpan.org. I'll mail the author as well.

Andrew McNaughton

On Sun\, 6 Dec 2003\, Nicholas Clark via RT wrote​:

On Thu\, Dec 04\, 2003 at 09​:12​:46AM -0000\, Andrew McNaughton wrote​:

# New Ticket Created by Andrew McNaughton # Please include the string​: [perl #24595] # in the subject line of all future correspondence about this issue. # \<URL​: http​://rt.perl.org​:80/rt3/Ticket/Display.html?id=24595 >

This is a bug report for perl from root@​wol.bush.shack\, generated with the help of perlbug 1.34 running under perl v5.8.2.

-----------------------------------------------------------------

Incorrect representation of Boolean values breaks some aspects of Net​::Google​::Search.

Net​::Google​::Search is not a core perl module\, and not maintained by the perl5 maintainers. You'll need to resend your patch to the author of Net​::Google​::Search. According to search.cpan.org​:

http​://search.cpan.org/~ascope/

his address is cpan@​aaronland.net

Nicholas Clark

--

No added Sugar. Not tested on animals. May contain traces of Nuts. If irritation occurs\, discontinue use.


Andrew McNaughton Currently in Boomer Bay\, Tasmania andrew@​scoop.co.nz Mobile​: +61 422 753 792 http​://staff.scoop.co.nz/andrew/cv.doc