p5pRT
commented
20 years ago From nzook@us.ibm.com
Created by nzook@us.ibm.com
Note: Problem persists in 5.8.0
The Time::Local module does not identify leap year properly. Demonstrating the bug requires a native 64-bit system\, because the epoch ends before any of the bad century years are reached.
Note: At this point in the code\, year has been reduced by 1900.
Logic test script:
nzook : perl -e ' $month = 1 ; for $year ( 1\, 4\, 100\, 200\, 300\, 400) { print "$year\n" unless $month != 1 or $year % 4 or ! ($year % 100) and $year % 400 != 100 ; }' 4 100
==
I have also taken the liberty of adding more robust code to the .*_nocheck functions in the module. My view is that the purpose of these functions is to permit users to modify timestamps without having to worry about range. I therefore force the month in-range & adjust the year.
Nathan Zook nzook@us.ibm.com nzook@bga.com
*** Local.pm Thu Mar 13 13:38:07 2003
--- Local_new.pm Wed Sep 1 11:35:34 2004
***************
*** 86\,92 ****
croak "Month '$month' out of range 0..11" if $month > 11 or $month \< 0;
my $md = $MonthDays[$month];
! ++$md unless $month != 1 or $year % 4 or !($year % 400);
croak "Day '$mday' out of range 1..$md" if $mday > $md or $mday \< 1;
croak "Hour '$hour' out of range 0..23" if $hour > 23 or $hour \< 0;
--- 86\,92 ----
croak "Month '$month' out of range 0..11" if $month > 11 or $month \< 0;
my $md = $MonthDays[$month];
! ++$md unless $month != 1 or $year % 4 or ! ($year % 100) and $year % 400 != 100 ;
croak "Day '$mday' out of range 1..$md" if $mday > $md or $mday \< 1;
croak "Hour '$hour' out of range 0..23" if $hour > 23 or $hour \< 0;
***************
*** 110\,117 ****
sub timegm_nocheck {
local $Options{no_range_check} = 1;
! &timegm;
}
--- 110\,123 ----
sub timegm_nocheck {
+
+ my ($sec\,$min\,$hour\,$mday\,$month\,$year) = @_;
+ my $real_month = $month % 12 ;
+
local $Options{no_range_check} = 1;
!
! $year += ($month - $real_month) / 12 ;
! &timegm($sec\,$min\,$hour\,$mday\,$real_month\,$year);
}
***************
*** 137\,144 ****
sub timelocal_nocheck {
local $Options{no_range_check} = 1;
! &timelocal;
}
1;
--- 143\,155 ----
sub timelocal_nocheck {
+ my ($sec\,$min\,$hour\,$mday\,$month\,$year) = @_;
+ my $real_month = $month % 12 ;
+
local $Options{no_range_check} = 1;
!
! $year += ($month - $real_month) / 12 ;
! &timelocal($sec\,$min\,$hour\,$mday\,$real_month\,$year);
}
1;
Migrated from rt.perl.org#31421 (status was 'resolved')
Searchable as RT31421$