Perl / perl5

🐪 The Perl programming language
https://dev.perl.org/perl5/
Other
1.91k stars 542 forks source link

Where to submit fixed scripts? #8893

Closed p5pRT closed 17 years ago

p5pRT commented 17 years ago

Migrated from rt.perl.org#42895 (status was 'rejected')

Searchable as RT42895$

p5pRT commented 17 years ago

From @StefanBertels

Hi\,

I patched two (old) perl scripts​:

1. /usr/lib/perl5/site_perl/5.8.0/Convert/TNEF.pm (0.17)

2. http​://www.cpan.org/authors/id/H/HI/HIGHTOWE/killtnef-1.0.2.pl

I'm no real perl programmer. I just fixed a few small things so I can use killtnef to auto-convert incoming ms-tnef mails. The original scripts did not work correctly -- probably because there older.

To whom should I send patches so others can use them (and I don't want my patched TNEF.pm to be overwritten in case of CPAN updates :-)).

Best regards Stefan

-- http​://stefan.bertels.org/

p5pRT commented 17 years ago

From @nwc10

On Sun\, May 06\, 2007 at 04​:39​:14PM -0700\, Stefan Bertels wrote​:

# New Ticket Created by Stefan Bertels # Please include the string​: [perl #42895] # in the subject line of all future correspondence about this issue. # \<URL​: http​://rt.perl.org/rt3/Ticket/Display.html?id=42895 >

Hi\,

I patched two (old) perl scripts​:

1. /usr/lib/perl5/site_perl/5.8.0/Convert/TNEF.pm (0.17)

Well\, I know nothing about Convert​::TNEF (which isn't surprising as it's not a core perl module\, and you're mailing the list about core perl) but I find that the documentation for it says​:

  Douglas Wilson\, dougw@​cpan.org

Have you tried mailing him?

2. http​://www.cpan.org/authors/id/H/HI/HIGHTOWE/killtnef-1.0.2.pl

scroll down down to

  Lester Hightower \hightowe@&#8203;10east\.com (maintainer)

and try mailing him.

Nicholas Clark

p5pRT commented 17 years ago

The RT System itself - Status changed from 'new' to 'open'

p5pRT commented 17 years ago

From guest@guest.guest.xxxxxxxx

Here's the killtnef patch (diff) and the patched TNEF.pm (attached as full file\, based on 0.17 / 2005-05-07).

Inline Patch ```diff --- killtnef-1.0.2.pl 2005-09-20 19:12:20.000000000 +0200 +++ killtnef.pl 2007-05-07 01:26:44.000000000 +0200 @@ -146,11 +146,12 @@ ```

#############################################################################

  for ($tnef->attachments) { - $_->longname=~/^[\w\W]+\.([A-Za-z]{2\,4})$/; + $_->longname=~/^[\w\W]+\.(\w+)$/;   my $ext = $1;   my $type = $mimetypes->mimeTypeOf($ext);   if (! $type) {   warn "No MIME type for (" . $_->longname . "/" . $_->name . ")\n"; + $type = "Application/OCTET-STREAM";   }   my $encoding;   if ($type) {

p5pRT commented 17 years ago

From guest@guest.guest.xxxxxxxx

TNEF.pm

p5pRT commented 17 years ago

@smpeters - Status changed from 'open' to 'rejected'