allow for multiple argument do_system

Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)

Other

35 stars 19 forks source link

allow for multiple argument do_system #103

Closed plicease closed 9 years ago

plicease commented 9 years ago

This patch allows for use of the multiple argument form of system. Sometimes this is desirable:

the multiple argument form doesn't usually invoke the shell
quoting is not portable, so the multiple argument version is frequently the more portable way to introduce space into an argument

I'd be using this in Alien::FFI which has some pretty hairy stuff for Windows and especially for Visual C++ support.

jberger commented 9 years ago

I like it. If I can make a small nit pick? Although you are using the list form of system, you are creating an array reference not a list reference. Small thing I know, but it's one I'm always careful about

mohawk2 commented 9 years ago

Looks good to me. Aye.

zmughal commented 9 years ago

Merge: Aye

plicease commented 9 years ago

Sent to CPAN as 0.008_01. If it looks good on cpantesters I plan to send a production release Tuesday or Wednesday.

plicease commented 9 years ago

Sent to CPAN as 0.009