Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)
Other
35 stars 19 forks source link

make a staged install the default #117

Closed plicease closed 9 years ago

plicease commented 9 years ago

As alluded to in #94 and #114 I would like to make alien_stage_install=1 be the default behavior. The main motivation for this is to make cpan testers work the same way as a regular install. This would, in my opinion, fix #94. The main reason not to do this up until now is that relocation weren't supported, especially on OS X. With the inclusion of #115 this does not appear to be a problem anymore.

Although I do not think this change should have an effect on most Alien::Base based distributions, this is a change in behavior, and I propose this conservative approach to deployment:

zmughal commented 9 years ago

This sounds like a good plan to remove some of the complexity in the build process. @plicease++

Merge: Aye

jberger commented 9 years ago

Especially with you volunteering to proactively watch the result I say aye. Does cpantesters report on modules versus dev versions of their dependencies? I.e. when you release a dev version will you see Alien:: module failures?

On Wed, Apr 22, 2015, 7:08 AM Zaki Mughal [sivoais] < notifications@github.com> wrote:

This sounds like a good plan to remove some of the complexity in the build process. @plicease https://github.com/plicease++

Merge: Aye

— Reply to this email directly or view it on GitHub https://github.com/Perl5-Alien/Alien-Base/pull/117#issuecomment-95151311 .

plicease commented 9 years ago

@jberger just from observation, although cpantesters give results from dev releases, they do not typically give results from reverse dependencies using that dev release (ie dev release of Alien::Base will not produce results of Alien::FFI using that dev release).

However, I've set alien_stage_install on a number of Alien::Base reverse dep, so I think we should get some pretty good feedback from that. That is the main motivation for proactively testing the dists that have XS reverse deps.

The dev release would mainly be to refer to in the blog post to say "hey try this version"

jberger commented 9 years ago

Right. Thanks!

On Wed, Apr 22, 2015 at 9:46 AM Graham Ollis notifications@github.com wrote:

@jberger https://github.com/jberger just from observation, although cpantesters give results from dev releases, they do not typically give results from reverse dependencies using that dev release (ie dev release of Alien::Base will not produce results of Alien::FFI using that dev release).

However, I've set alien_stage_install on a number of Alien::Base reverse dep, so I think we should get some pretty good feedback from that. That is the main motivation for proactively testing the dists that have XS reverse deps.

The dev release would mainly be to refer to in the blog post to say "hey try this version"

— Reply to this email directly or view it on GitHub https://github.com/Perl5-Alien/Alien-Base/pull/117#issuecomment-95216914 .

plicease commented 9 years ago

Since merging this branch has closed the PR, please continue discussion for this issue on #94