search

Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)
Other
35 stars 19 forks source link

honor alien_provides_* on system install #131

Closed plicease closed 9 years ago

plicease commented 9 years ago

alien_provides_cflags and alien_provides_libs aren't honored currently when the library is provided by the system (either with or without pkg-config). This PR will fix that. I have a test for the builder itself. I have tested this with

https://github.com/plicease/Alien-Libbz2

To ensure that it also works once installed. I will add that to the travis for AB so that we can catch any regressions there.

plicease commented 9 years ago

The first commit worked on OS X with PkgConfig.pm but was failing on Linux with a real pkg-config.

You can see the failure here:

https://travis-ci.org/plicease/Alien-Base/builds/69209383

The second commit makes it work with a real pkg-config.

I verified it with a travis branch:

https://travis-ci.org/plicease/Alien-Base/builds/69229344

I will update .travis.yml to test with Alien::Libbz2 once the next release of AB makes it to cpan, and I can put Alien::Libbz2 on CPAN.