search

Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)
Other
35 stars 19 forks source link

ACTION_test: fix testing when using a system library #146

Closed salva closed 8 years ago

salva commented 8 years ago

The ACTION_test method was trying to run the library test suit even when a system library has been detected (and so, no library was actually compiled).

salva commented 8 years ago

See also https://github.com/Perl5-Alien/Alien-Base/pull/145

mohawk2 commented 8 years ago

This looks like an interesting change: aye if Graham or Joel are keen. Just an observation; you don't need to close and resubmit to change your approach; you could also just change your branch and force-push, and it will automatically be reflected. If you feel you need to, you can experiment by PR-ing on your own repo.

plicease commented 8 years ago

More or less agree on this, I need to play around with it first.

jberger commented 8 years ago

Looks fine to me. Aye

plicease commented 8 years ago

rebased and merged.