search

Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)
Other
35 stars 19 forks source link

Test success on version probe #149

Closed plicease closed 8 years ago

plicease commented 8 years ago

If the command fails, but there is some output we get a false positive. This problem was discovered when using perl Build.PL verbose=1 (and demonstrated with Alien::LibYAML). While this exact problem will hopefully be fixed with PR #147, there are other strangeisms that could infect the captured output with bogus data.

jberger commented 8 years ago

Yes the command would have to succeed in order to provide useful results I suppose. Aye

mohawk2 commented 8 years ago

Currently I am finding it very difficult to make time for open-source stuff. What if we switch our merge policy from "two ayes" to "one aye plus some short delay"?

plicease commented 8 years ago

@mohawk2 this is more or less what I have been doing, although "short delay" is seven days. I am happy with this pace.

mohawk2 commented 8 years ago

Works for me! I'm also reassured that I'm not holding things up.