Perl5-Alien / Alien-Base

Base classes for Alien:: modules (deprecated, see Alien-Build)
Other
35 stars 19 forks source link

require HTTP::Tiny 0.044 #154

Closed plicease closed 8 years ago

plicease commented 8 years ago

I would just like to bump the requirement for HTTP::Tiny to 0.044. Combination of #151 and older version of HTTP::Tiny broke Alien::EditLine, and it may be problematic for other dists as well.

This does not effect 5.18 or more recent which already come with the newer version of HTTP::Tiny.

without: https://travis-ci.org/plicease/Alien-Editline/builds/105494917 with: https://travis-ci.org/plicease/Alien-Editline/builds/105505010

mohawk2 commented 8 years ago

If it's a real requirement, which it clearly is: aye.

plicease commented 8 years ago

Just saw this with Alien::gmake as well:

https://travis-ci.org/Perl5-Alien/Alien-gmake/builds/105585356

If anyone is curious, the reason it passes on versions 8 10 and 12, it is because HTTP::Tiny wasn't in core for those versions, so they latest version gets installed when tested in CI, but 14 and 16 already have an old version of HTTP::Tiny which doesn't get upgraded (without this PR).

zmughal commented 8 years ago

Seems reasonable and will improve Perl version coverage.

Merge: Aye