search

PerlAlien / Alien-Build

Build external dependencies for use in CPAN
16 stars 25 forks source link

bad invocation of `cp` causes t/alien_build_plugin_build_copy.t to fail #290

Closed doriantaylor closed 2 years ago

doriantaylor commented 2 years ago

This is an Intel Mac, 10.15.7 with Perl 5.34.0, trying to install Alien::Build 2.45. A few other subsequent tests fail but I assume for now they are related. At a glance it looks like it's not quoting the path. Sorry I'm in the middle of something and don't have time to do a better report; just putting this here to revisit in a few days.

t/alien_build_plugin_build_copy.t .................... 1/?     # Failed test 'builds okay'
    # at t/alien_build_plugin_build_copy.t line 33.
    # Alien::Build> single file, assuming archive
    # Alien::Build::Auto::Zvtb0::Alienfile> bin=/Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/.tmp/zvXKI00tbN/root/build_NGA1/bin/mycommand
    # Alien::Build::CommandSequence> + cp -pPR * /Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/.tmp/zvXKI00tbN/stage
    # usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
    #        cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory
    # build threw exception: external command failed at /Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/blib/lib/Alien/Build/CommandSequence.pm line 88.
    # Failed test 'file /Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/.tmp/zvXKI00tbN/stage/bin/mycommand exists'
    # at t/alien_build_plugin_build_copy.t line 38.
    # Failed test 'file /Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/.tmp/zvXKI00tbN/stage/bin/mycommand is executable'
    # at t/alien_build_plugin_build_copy.t line 39.
    # Failed test 'file /Users/dorian/Library/Application Support/.cpan/build/Alien-Build-2.45-2/.tmp/zvXKI00tbN/stage/include/foo.h exists'
    # at t/alien_build_plugin_build_copy.t line 43.

# Failed test 'basic'
# at t/alien_build_plugin_build_copy.t line 51.
t/alien_build_plugin_build_copy.t .................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
zmughal commented 2 years ago

Fixed by the PR linked above which is in v2.46.